From 3a4a6bb21fa994e399c47a6726385d0100cff28e Mon Sep 17 00:00:00 2001 From: sneak Date: Wed, 7 Oct 2026 08:37:34 +0000 Subject: [PATCH] Set a time limit on the canonical check job (closes #120) The canonical check workflow gave its job no time limit, so a hung script/cibuild held the shared runner until the runner's own default. The check job now sets timeout-minutes: 20. script/cibuild runs three Docker builds (the test phase, the lint phase, then the image, which runs both again), each held to the 5-minute build limit, plus the bootstrap. REPO_POLICIES.md and both checklists name the limit among what the workflow sets. Model: opus-5-5 --- .gitea/workflows/check.yml | 2 ++ TODO.md | 8 ++++++++ prompts/EXISTING_REPO_CHECKLIST.md | 9 +++++---- prompts/NEW_REPO_CHECKLIST.md | 7 ++++--- prompts/REPO_POLICIES.md | 18 +++++++++++------- 5 files changed, 30 insertions(+), 14 deletions(-) diff --git a/.gitea/workflows/check.yml b/.gitea/workflows/check.yml index 7c8c682..2e96965 100644 --- a/.gitea/workflows/check.yml +++ b/.gitea/workflows/check.yml @@ -7,6 +7,8 @@ concurrency: jobs: check: runs-on: ubuntu-latest + # Free the shared runner from a hung build. + timeout-minutes: 20 steps: # actions/checkout v4.2.2, 2026-02-22 - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 diff --git a/TODO.md b/TODO.md index 56f4b89..a486347 100644 --- a/TODO.md +++ b/TODO.md @@ -21,6 +21,14 @@ fmt-check, and commit. # Completed Steps +- 2026-10-07: The canonical `.gitea/workflows/check.yml` now sets + `timeout-minutes: 20` on its `check` job (issue 120), so a hung build frees + the shared runner instead of holding it until the runner's own limit. + `script/cibuild` runs three Docker builds, each held to the 5-minute Docker + build limit, plus the bootstrap; if that limit changes (issue 113), the value + follows it. `REPO_POLICIES.md` and both checklists name the limit among what + the workflow sets. Not yet tried on the shared runner. Repositories pick this + up on their next re-vendor. - 2026-10-07: The canonical `package.json` now has `"private": true` in place of `"license": "MIT"` (issue 119), so a repository that copies it no longer declares MIT whatever its own licence is. yarn does not print "No license diff --git a/prompts/EXISTING_REPO_CHECKLIST.md b/prompts/EXISTING_REPO_CHECKLIST.md index c501263..9cfc861 100644 --- a/prompts/EXISTING_REPO_CHECKLIST.md +++ b/prompts/EXISTING_REPO_CHECKLIST.md @@ -1,6 +1,6 @@ --- title: Existing Repo Checklist -last_modified: 2026-10-06 +last_modified: 2026-10-07 --- Use this checklist when beginning work in a repo that may not yet conform to our @@ -102,9 +102,10 @@ with your task. build finds the tag too. - [ ] Gitea Actions workflow in `.gitea/workflows/` runs `script/cibuild` on push, checks out with `persist-credentials: false` and with - `fetch-depth: 0` (which fetches the tags `git describe` needs), and - carries the `concurrency` block that lets a new push cancel only the same - branch's older run — reference + `fetch-depth: 0` (which fetches the tags `git describe` needs), carries + the `concurrency` block that lets a new push cancel only the same branch's + older run, and sets `timeout-minutes: 20` on the `check` job so a hung + build frees the shared runner — reference `https://git.eeqj.de/sneak/prompts/raw/branch/main/.gitea/workflows/check.yml` - [ ] Language-specific config: - [ ] Go: `go.mod`, `go.sum`, `.golangci.yml` (fetch from diff --git a/prompts/NEW_REPO_CHECKLIST.md b/prompts/NEW_REPO_CHECKLIST.md index 8152040..d9bc2da 100644 --- a/prompts/NEW_REPO_CHECKLIST.md +++ b/prompts/NEW_REPO_CHECKLIST.md @@ -1,6 +1,6 @@ --- title: New Repo Checklist -last_modified: 2026-10-06 +last_modified: 2026-10-07 --- Use this checklist when creating a new repository from scratch. Follow the steps @@ -113,9 +113,10 @@ Template files can be fetched from: - Image pinned by sha256 hash with version/date comment - [ ] Gitea Actions workflow at `.gitea/workflows/check.yml` that runs `script/cibuild` on push, checks out with `persist-credentials: false` and - with `fetch-depth: 0` (which fetches the tags `git describe` needs), and + with `fetch-depth: 0` (which fetches the tags `git describe` needs), carries the `concurrency` block that lets a new push cancel only the same - branch's older run — reference + branch's older run, and sets `timeout-minutes: 20` on the `check` job so a + hung build frees the shared runner — reference `https://git.eeqj.de/sneak/prompts/raw/branch/main/.gitea/workflows/check.yml` - [ ] Language-specific: - [ ] Go: `go mod init sneak.berlin/go/`, `.golangci.yml` (fetch from diff --git a/prompts/REPO_POLICIES.md b/prompts/REPO_POLICIES.md index ca2c195..d662eb2 100644 --- a/prompts/REPO_POLICIES.md +++ b/prompts/REPO_POLICIES.md @@ -1,6 +1,6 @@ --- title: Repository Policies -last_modified: 2026-10-06 +last_modified: 2026-10-07 --- This document covers repository structure, tooling, and workflow standards. Code @@ -304,12 +304,16 @@ style conventions are in separate documents: carry the same guarantee, because its gate phases may come from the cache. The image build is uncached and so runs the gate phases a second time. That is the price of the rule above, and it is worth paying: the image that ships is built - from a run of its own gates rather than from a cache entry. A separate - workflow limited to `main` by a `branches` list under `on: push` cannot be - checked by review: to try a change to it, add the feature branch to that list - and push, then remove the branch from the list again before merging. Keep any - job in it that publishes behind `if: github.ref_name == 'main'`, so the run - from the feature branch publishes nothing. + from a run of its own gates rather than from a cache entry. The `check` job + sets `timeout-minutes: 20`, so a hung build frees the shared runner after 20 + minutes. That allows for the three Docker builds described above (the test + phase, the lint phase, then the image), each held to the 5-minute Docker build + limit below, plus the bootstrap. A separate workflow limited to `main` by a + `branches` list under `on: push` cannot be checked by review: to try a change + to it, add the feature branch to that list and push, then remove the branch + from the list again before merging. Keep any job in it that publishes behind + `if: github.ref_name == 'main'`, so the run from the feature branch publishes + nothing. - Use platform-standard formatters: `black` for Python, `prettier` for JS/CSS/Markdown/HTML, `go fmt` for Go. Always use default configuration with -- 2.54.0