next still carries the pre-ruling 20s/30s test budget, so PR 34 will revert the org-wide ruling when it rebases #48

Open
opened 2026-08-19 14:14:55 +02:00 by clawbot · 0 comments
Collaborator

Found while checking the canonical test-timeout numbers on behalf of sneak/homoicon#122.

main is at a868689#42, merged 2026-08-10, implementing the org-wide ruling at #41 (comment): 60 s whole-suite hard cap, 20 s target with any overage filed as an improvement bug, and go test -timeout 90s as the backstop.

next predates that PR and still carries the superseded text in prompts/REPO_POLICIES.md: "must complete in under 20 seconds. Add a 30-second timeout", plus -timeout 30s on both Go example lines (:470, :490, :492).

#34 (next -> main) is currently mergeable: false. When it is rebased or the conflict is resolved, whoever does it will be choosing between two versions of that paragraph with nothing marking which one is authoritative — and taking next's side silently reverts the ruling in the one file every repo vendors. That is a quiet fleet-wide regression: repos re-vendoring afterwards would pick up 20 s/30 s again, and 30 s is the number measured to produce roughly 12% false-red builds on clean trees (evidence on sneak/homoicon#122).

No ruling is needed — this is reconciling a branch against a decision already made.

Definition of done: git grep -n 'timeout 30s' on next is empty; the test-budget paragraph on next matches main's (60 s cap, 20 s target, 90 s backstop, and the sentence explaining that the backstop deliberately sits above the hard cap so it catches a hung test rather than a merely slow one); #34 reports mergeable: true.

Found while checking the canonical test-timeout numbers on behalf of https://git.eeqj.de/sneak/homoicon/issues/122. `main` is at `a868689` — https://git.eeqj.de/sneak/prompts/pulls/42, merged 2026-08-10, implementing the org-wide ruling at https://git.eeqj.de/sneak/prompts/issues/41#issuecomment-53166: 60 s whole-suite hard cap, 20 s target with any overage filed as an improvement bug, and `go test -timeout 90s` as the backstop. `next` predates that PR and still carries the superseded text in `prompts/REPO_POLICIES.md`: "must complete in under 20 seconds. Add a 30-second timeout", plus `-timeout 30s` on both Go example lines (`:470`, `:490`, `:492`). https://git.eeqj.de/sneak/prompts/pulls/34 (`next` -> `main`) is currently `mergeable: false`. When it is rebased or the conflict is resolved, whoever does it will be choosing between two versions of that paragraph with nothing marking which one is authoritative — and taking `next`'s side silently reverts the ruling in the one file every repo vendors. That is a quiet fleet-wide regression: repos re-vendoring afterwards would pick up 20 s/30 s again, and 30 s is the number measured to produce roughly 12% false-red builds on clean trees (evidence on https://git.eeqj.de/sneak/homoicon/issues/122). No ruling is needed — this is reconciling a branch against a decision already made. Definition of done: `git grep -n 'timeout 30s'` on `next` is empty; the test-budget paragraph on `next` matches `main`'s (60 s cap, 20 s target, 90 s backstop, and the sentence explaining that the backstop deliberately sits above the hard cap so it catches a hung test rather than a merely slow one); https://git.eeqj.de/sneak/prompts/pulls/34 reports `mergeable: true`.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/prompts#48