Stop the lint and test builds writing an image (closes #123)
check / check (push) Canceled after 0s
check / check (push) Canceled after 0s
script/lint and script/test build their Dockerfile phase with --output type=cacheonly in place of a tag. The phase still runs uncached and a failing step still fails the build, but no image is written: nothing used those images, and writing one out took about 16 seconds of a Go repository's test build. script/cibuild and script/docker keep their tags. REPO_POLICIES.md, both checklists and the README now say the gate builds write no image. Model: opus-5-5
This commit was merged in pull request #124.
This commit is contained in:
1 parent
0b20f18734
commit
1d9b046b91
7 files changed
+55
-42
No files matched your search
@@ -143,11 +143,14 @@ are thin shims calling them. Model scripts:
|
||||
it
|
||||
- [ ] `script/setup` / `make setup` — readies a fresh clone: runs `bootstrap`,
|
||||
then `install-precommit`, plus repo-specific init
|
||||
- [ ] `script/test` / `make test` — `docker build --no-cache --target test .`,
|
||||
tagged; the phase runs real tests, not a no-op (90-second timeout,
|
||||
60-second hard cap on wall time)
|
||||
- [ ] `script/lint` / `make lint` — `docker build --no-cache --target lint .`,
|
||||
tagged. No lint verdict may come from a host invocation of the linter.
|
||||
- [ ] `script/test` / `make test` —
|
||||
`docker build --no-cache --target test --output type=cacheonly .`, which
|
||||
writes no image; the phase runs real tests, not a no-op (90-second
|
||||
timeout, 60-second hard cap on wall time)
|
||||
- [ ] `script/lint` / `make lint` —
|
||||
`docker build --no-cache --target lint --output type=cacheonly .`, which
|
||||
writes no image. No lint verdict may come from a host invocation of the
|
||||
linter.
|
||||
- [ ] `script/fmt` / `make fmt` — formats code (writes; native, never in a
|
||||
container)
|
||||
- [ ] `script/fmt-check` / `make fmt-check` — checks formatting (read-only;
|
||||
@@ -169,8 +172,9 @@ are thin shims calling them. Model scripts:
|
||||
`script/bootstrap` leaves the node and yarn it installs off the `PATH` of
|
||||
the shell that called it, so a bare `yarn` exits 127 on a runner carrying
|
||||
nothing but docker and git.
|
||||
- [ ] Every `docker build` in `script/` is tagged, so no invocation leaves a
|
||||
dangling image behind
|
||||
- [ ] No `docker build` in `script/` leaves a dangling image behind:
|
||||
`script/lint` and `script/test` write no image, and `script/docker` and
|
||||
`script/cibuild` tag theirs
|
||||
- [ ] `script/precommit` — called by the pre-commit hook; runs `script/check`
|
||||
- [ ] `script/install-precommit` — installs the pre-commit hook that runs
|
||||
`script/precommit`
|
||||
|
||||
Reference in new issue
Block a user