diff --git a/internal/handlers/handlers.go b/internal/handlers/handlers.go index 60066f6..0398357 100644 --- a/internal/handlers/handlers.go +++ b/internal/handlers/handlers.go @@ -51,6 +51,14 @@ func New(lc fx.Lifecycle, params Params) (*Handlers, error) { } lc.Append(fx.Hook{ + // The eviction goroutine must outlive OnStart, so it cannot + // inherit this hook's context. It makes its own instead, which + // leaves it uncancellable: an in-flight pass runs to completion + // during OnStop regardless of the shutdown deadline. Making the + // loop cancellable changes shutdown semantics and is tracked + // separately in issue #102, rather than being folded into the + // lint-conformance change that surfaced it. + //nolint:contextcheck // see issue #102 OnStart: func(_ context.Context) error { return s.initImageService() },