.dockerignore lacks the Go test-binary and coverage patterns the checklist asks for #155

Open
opened 2026-10-14 16:08:48 +02:00 by clawbot · 0 comments
Collaborator

.dockerignore lines 74 to 81, at v1.0.0-rc1: the repository's own entries are /dist, /tmp, /netwatch-server, /data and /*.log. A Go test binary (*.test) or coverage file (*.out) left at the root, which .gitignore lines 59 to 61 already anticipate, is sent into the build context of all four docker builds in script/ and copied into the lint and test layers.

How to see it: touch reportbuf.test cover.out at the root, build a probe image whose Dockerfile is COPY . /app and list /app: both files are there.

What is right: prompts/EXISTING_REPO_CHECKLIST.md lines 51 to 54: ".dockerignore excludes the repo's own host-built artifacts (compiled binaries, test binaries, coverage output), written root-anchored". REPO_POLICIES.md asks that .dockerignore be verified "by enumerating the image, not by reading the patterns".

Severity: low. The host never runs go test (it runs in Docker), so such files are unlikely.

Definition of done

  • .dockerignore gains root-anchored entries for Go test binaries and coverage output (/*.test, /*.out) after the shared content, in the repository's own section.
  • Verified by a probe image as the policy says: planted x.test and x.out at the root do not land in it; make check still passes.
  • TODO.md updated in the same commit; commit title ends (closes #N) with this issue's number.

Model: fable-5-1

`.dockerignore` lines 74 to 81, at `v1.0.0-rc1`: the repository's own entries are `/dist`, `/tmp`, `/netwatch-server`, `/data` and `/*.log`. A Go test binary (`*.test`) or coverage file (`*.out`) left at the root, which `.gitignore` lines 59 to 61 already anticipate, is sent into the build context of all four `docker build`s in `script/` and copied into the lint and test layers. **How to see it**: `touch reportbuf.test cover.out` at the root, build a probe image whose Dockerfile is `COPY . /app` and list `/app`: both files are there. **What is right**: `prompts/EXISTING_REPO_CHECKLIST.md` lines 51 to 54: "`.dockerignore` excludes the repo's own host-built artifacts (compiled binaries, test binaries, coverage output), written root-anchored". `REPO_POLICIES.md` asks that `.dockerignore` be verified "by enumerating the image, not by reading the patterns". **Severity**: low. The host never runs `go test` (it runs in Docker), so such files are unlikely. ## Definition of done - [ ] `.dockerignore` gains root-anchored entries for Go test binaries and coverage output (`/*.test`, `/*.out`) after the shared content, in the repository's own section. - [ ] Verified by a probe image as the policy says: planted `x.test` and `x.out` at the root do not land in it; `make check` still passes. - [ ] `TODO.md` updated in the same commit; commit title ends ` (closes #N)` with this issue's number. Model: fable-5-1
clawbot self-assigned this 2026-10-14 16:08:48 +02:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/netwatch#155