Frontend Dockerfile CI build does not run make check (only yarn build) #11

New Issue

2026-07-25T13:17:50+02:00

clawbot commented

2026-07-25 13:17:50 +02:00

During the STRTA conformance survey, netwatch's Makefile was confirmed conformant (it is our living reference for the scaffold). Separately, the survey observed that the frontend Dockerfile build appears to run only yarn build, not make check / script/cibuild. If that is how CI validates the frontend, the container build fails only on a broken build, not on lint, fmt-check, or test regressions.

Definition of done

Verify how the frontend is validated in CI (whether the repo-root script/cibuild / make check already gates it, or whether the frontend Dockerfile is the only gate).
If the gap is real: the frontend Docker build (or the CI entrypoint script/cibuild) runs make check so that lint, fmt-check, and tests gate the build, and CI goes red on any check failure — not merely on a failed yarn build.
If verification shows the frontend is already covered by make check in CI elsewhere, close this issue with a note explaining where, and no code change is needed.

The finishing commit's title must end with (closes #N) referencing this issue.

During the STRTA conformance survey, netwatch's `Makefile` was confirmed conformant (it is our living reference for the scaffold). Separately, the survey observed that the frontend `Dockerfile` build appears to run only `yarn build`, not `make check` / `script/cibuild`. If that is how CI validates the frontend, the container build fails only on a broken build, not on lint, `fmt-check`, or test regressions. ## Definition of done 1. Verify how the frontend is validated in CI (whether the repo-root `script/cibuild` / `make check` already gates it, or whether the frontend `Dockerfile` is the only gate). 2. If the gap is real: the frontend Docker build (or the CI entrypoint `script/cibuild`) runs `make check` so that lint, `fmt-check`, and tests gate the build, and CI goes red on any check failure — not merely on a failed `yarn build`. 3. If verification shows the frontend is already covered by `make check` in CI elsewhere, close this issue with a note explaining where, and no code change is needed. The finishing commit's title must end with ` (closes #N)` referencing this issue.

sneak referenced this issue from a commit

2026-07-26 20:54:00 +02:00

frontend: gate the Docker build on make check (closes #11)

clawbot referenced a pull request that will close this issue

2026-07-26 20:57:00 +02:00

frontend: gate the Docker build on make check (closes #11) #12

sneak closed this issue

2026-08-07 17:46:37 +02:00

sneak referenced this issue from a commit

2026-08-07 17:46:38 +02:00

frontend: gate the Docker build on make check (closes #11) (#12)

Sign in to join this conversation.