sneak/netwatch
1
0
Fork 0
Code Issues 2 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

Frontend Dockerfile CI build does not run make check (only yarn build) #11

New Issue
Open
opened 2026-07-25 13:17:50 +02:00 by clawbot · 0 comments
clawbot commented 2026-07-25 13:17:50 +02:00
Collaborator
Copy Link

During the STRTA conformance survey, netwatch's Makefile was confirmed conformant (it is our living reference for the scaffold). Separately, the survey observed that the frontend Dockerfile build appears to run only yarn build, not make check / script/cibuild. If that is how CI validates the frontend, the container build fails only on a broken build, not on lint, fmt-check, or test regressions.

Definition of done

  1. Verify how the frontend is validated in CI (whether the repo-root script/cibuild / make check already gates it, or whether the frontend Dockerfile is the only gate).
  2. If the gap is real: the frontend Docker build (or the CI entrypoint script/cibuild) runs make check so that lint, fmt-check, and tests gate the build, and CI goes red on any check failure — not merely on a failed yarn build.
  3. If verification shows the frontend is already covered by make check in CI elsewhere, close this issue with a note explaining where, and no code change is needed.

The finishing commit's title must end with (closes #N) referencing this issue.

During the STRTA conformance survey, netwatch's `Makefile` was confirmed conformant (it is our living reference for the scaffold). Separately, the survey observed that the frontend `Dockerfile` build appears to run only `yarn build`, not `make check` / `script/cibuild`. If that is how CI validates the frontend, the container build fails only on a broken build, not on lint, `fmt-check`, or test regressions. ## Definition of done 1. Verify how the frontend is validated in CI (whether the repo-root `script/cibuild` / `make check` already gates it, or whether the frontend `Dockerfile` is the only gate). 2. If the gap is real: the frontend Docker build (or the CI entrypoint `script/cibuild`) runs `make check` so that lint, `fmt-check`, and tests gate the build, and CI goes red on any check failure — not merely on a failed `yarn build`. 3. If verification shows the frontend is already covered by `make check` in CI elsewhere, close this issue with a note explaining where, and no code change is needed. The finishing commit's title must end with ` (closes #N)` referencing this issue.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
merge-ready
needs-checks
needs-rebase
needs-review
needs-rework
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
clawbot sneak
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/netwatch#11
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?