CI time limit on the step; no timeout in Dockerfile or scripts (closes #199)
check / check (push) Successful in 4m28s
check / check (push) Successful in 4m28s
The runner ignores a job's timeout-minutes, so the 20-minute limit moves to the step that runs script/cibuild. The Dockerfile frontend-test stage, script/frontend-test and script/frontend-viewport-test drop their timeout wrappers, which failed make check on a busy host. go test's -timeout 90s stays, as REPO_POLICIES.md requires it. Model: opus-5-5
This commit is contained in:
1 parent
437e0ea80c
commit
ee7ab101aa
5 files changed
+15
-10
No files matched your search
@@ -31,8 +31,8 @@ HARNESS="netwatch-viewport-harness-$RUN_ID"
|
||||
ARTIFACT_DIR="$ROOT/tmp/viewport"
|
||||
|
||||
# Every container is named and removed here, including the harness itself:
|
||||
# `timeout` below kills the `docker run` client, not the container it
|
||||
# started, and an unnamed survivor keeps the --internal network in use so
|
||||
# a `docker run` client that is killed outright leaves its container
|
||||
# running, and an unnamed survivor keeps the --internal network in use so
|
||||
# `docker network rm` fails too. This host runs many sessions at once and
|
||||
# neither may be left behind.
|
||||
cleanup() {
|
||||
@@ -122,7 +122,7 @@ main() {
|
||||
-f '{{range .NetworkSettings.Networks}}{{.IPAddress}}{{end}}' \
|
||||
"$BROWSER")"
|
||||
|
||||
timeout 900 docker run --rm --init --name "$HARNESS" \
|
||||
docker run --rm --init --name "$HARNESS" \
|
||||
--network "$NETWORK" \
|
||||
--user "$(id -u):$(id -g)" \
|
||||
-v "$ROOT:/app" \
|
||||
|
||||
Reference in new issue
Block a user