Target names, URLs and log lines reach the page as text (closes #29)
check / check (push) Successful in 3m57s
check / check (push) Successful in 3m57s
A host row escapes the name and URL it writes into its markup with a new escapeHTML function, and the debug log builds each line as an element whose text is set, so neither is read as HTML once targets can be configured. A unit test builds the row of a target whose name and URL hold < > " & and ' and checks each comes out escaped; hostRowHTML is exported for it. README.md stops calling CONFIG frozen: the interval menu sets updateInterval, and the timeouts, history span and axis ticks are computed from it. AppState declares _recoveryProbeId and _recoveryProbeChecks, the sparkline axis functions drop the parameters they never used, and HostState's history comment names both entry shapes. Model: opus-5-5
This commit is contained in:
@@ -104,8 +104,10 @@ files are served, with no backend required.
|
|||||||
The application is a single-page app built with Vite and Tailwind CSS v4. All
|
The application is a single-page app built with Vite and Tailwind CSS v4. All
|
||||||
code lives in `src/main.js` with a class-based architecture:
|
code lives in `src/main.js` with a class-based architecture:
|
||||||
|
|
||||||
- **`CONFIG`**: Frozen configuration object (update interval, timeouts, axis
|
- **`CONFIG`**: Configuration object (update interval, timeouts, axis ticks,
|
||||||
ticks, etc.)
|
etc.). The interval menu sets `updateInterval`, the one value the page writes
|
||||||
|
into `CONFIG`; the timeouts, the time the history spans and the x-axis ticks
|
||||||
|
are computed from it
|
||||||
- **`HostState`**: Per-host state management — history buffer, latency tracking,
|
- **`HostState`**: Per-host state management — history buffer, latency tracking,
|
||||||
status transitions
|
status transitions
|
||||||
- **`AppState`**: Top-level state container — WAN hosts, local hosts, pause
|
- **`AppState`**: Top-level state container — WAN hosts, local hosts, pause
|
||||||
|
|||||||
@@ -23,6 +23,15 @@ latest run passes.
|
|||||||
|
|
||||||
# Completed Steps
|
# Completed Steps
|
||||||
|
|
||||||
|
- 2026-10-04: a target's name and URL and a debug log message show as the
|
||||||
|
characters they are and are never read as HTML (issue #29): a host row escapes
|
||||||
|
the name and URL it writes into its markup, and the debug log sets each line
|
||||||
|
as text. A unit test checks a target whose name and URL hold `<`, `>`, `"`,
|
||||||
|
`&` and `'`. `README.md` no longer calls `CONFIG` frozen: the interval menu
|
||||||
|
sets its `updateInterval`, and the values computed from it follow. `AppState`
|
||||||
|
declares the recovery probe's two properties, the sparkline axis functions
|
||||||
|
lose the parameters they did not use, and the comment on a target's history
|
||||||
|
names both kinds of entry it holds. Nothing the page does changed
|
||||||
- 2026-10-04: `script/` and `Makefile` follow the org models (issue #28):
|
- 2026-10-04: `script/` and `Makefile` follow the org models (issue #28):
|
||||||
`make dev` shims to the new `script/dev`, the Vite dev server, and the new
|
`make dev` shims to the new `script/dev`, the Vite dev server, and the new
|
||||||
`make build` to `script/build`, the frontend production build.
|
`make build` to `script/build`, the frontend production build.
|
||||||
|
|||||||
+36
-14
@@ -8,6 +8,8 @@
|
|||||||
// display their real value in the latency figure. The history buffer holds
|
// display their real value in the latency figure. The history buffer holds
|
||||||
// maxHistoryPoints samples (historyDuration / updateInterval).
|
// maxHistoryPoints samples (historyDuration / updateInterval).
|
||||||
// reportInterval is how often collected samples are POSTed to the backend.
|
// reportInterval is how often collected samples are POSTed to the backend.
|
||||||
|
// The interval menu changes updateInterval while the page runs; the
|
||||||
|
// getters compute their values from it each time they are read.
|
||||||
export const CONFIG = {
|
export const CONFIG = {
|
||||||
updateInterval: 3000,
|
updateInterval: 3000,
|
||||||
maxHistoryPoints: 100,
|
maxHistoryPoints: 100,
|
||||||
@@ -201,7 +203,10 @@ export class HostState {
|
|||||||
constructor(host, pinned = false) {
|
constructor(host, pinned = false) {
|
||||||
this.name = host.name;
|
this.name = host.name;
|
||||||
this.url = host.url;
|
this.url = host.url;
|
||||||
this.history = []; // { timestamp, latency, paused }
|
// Each entry is either a check's result, { timestamp, latency,
|
||||||
|
// error }, or a round skipped while paused, { timestamp,
|
||||||
|
// latency: null, paused: true }.
|
||||||
|
this.history = [];
|
||||||
this.lastLatency = null;
|
this.lastLatency = null;
|
||||||
this.status = "pending"; // 'online' | 'offline' | 'error' | 'pending'
|
this.status = "pending"; // 'online' | 'offline' | 'error' | 'pending'
|
||||||
this.pinned = pinned;
|
this.pinned = pinned;
|
||||||
@@ -271,6 +276,10 @@ export class AppState {
|
|||||||
this.local = localHosts.map((h) => new HostState(h));
|
this.local = localHosts.map((h) => new HostState(h));
|
||||||
this.paused = false;
|
this.paused = false;
|
||||||
this.tickCount = 0;
|
this.tickCount = 0;
|
||||||
|
// The recovery probe's timer, null while it is not running, and the
|
||||||
|
// checks it started last.
|
||||||
|
this._recoveryProbeId = null;
|
||||||
|
this._recoveryProbeChecks = null;
|
||||||
}
|
}
|
||||||
|
|
||||||
get allHosts() {
|
get allHosts() {
|
||||||
@@ -580,8 +589,8 @@ class SparklineRenderer {
|
|||||||
const ch = h - m.top - m.bottom;
|
const ch = h - m.top - m.bottom;
|
||||||
|
|
||||||
ctx.clearRect(0, 0, w, h);
|
ctx.clearRect(0, 0, w, h);
|
||||||
SparklineRenderer._drawYAxis(ctx, w, h, m, ch);
|
SparklineRenderer._drawYAxis(ctx, w, m, ch);
|
||||||
SparklineRenderer._drawXAxis(ctx, w, h, m, cw);
|
SparklineRenderer._drawXAxis(ctx, h, m, cw);
|
||||||
|
|
||||||
const len = history.length;
|
const len = history.length;
|
||||||
const pw = cw / (CONFIG.maxHistoryPoints - 1);
|
const pw = cw / (CONFIG.maxHistoryPoints - 1);
|
||||||
@@ -597,7 +606,7 @@ class SparklineRenderer {
|
|||||||
SparklineRenderer._drawTip(ctx, history, getX, getY);
|
SparklineRenderer._drawTip(ctx, history, getX, getY);
|
||||||
}
|
}
|
||||||
|
|
||||||
static _drawYAxis(ctx, w, h, m, ch) {
|
static _drawYAxis(ctx, w, m, ch) {
|
||||||
ctx.font = "300 12px monospace";
|
ctx.font = "300 12px monospace";
|
||||||
ctx.textAlign = "right";
|
ctx.textAlign = "right";
|
||||||
ctx.textBaseline = "middle";
|
ctx.textBaseline = "middle";
|
||||||
@@ -614,7 +623,7 @@ class SparklineRenderer {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
static _drawXAxis(ctx, w, h, m, cw) {
|
static _drawXAxis(ctx, h, m, cw) {
|
||||||
ctx.textAlign = "center";
|
ctx.textAlign = "center";
|
||||||
ctx.textBaseline = "top";
|
ctx.textBaseline = "top";
|
||||||
for (const tick of CONFIG.xAxisTicks) {
|
for (const tick of CONFIG.xAxisTicks) {
|
||||||
@@ -702,7 +711,18 @@ class SparklineRenderer {
|
|||||||
// horizontally.
|
// horizontally.
|
||||||
const STATUS_TEXT_CLASS = "status-text text-xs text-right col-span-2 mt-5";
|
const STATUS_TEXT_CLASS = "status-text text-xs text-right col-span-2 mt-5";
|
||||||
|
|
||||||
function hostRowHTML(host, index, showPin = true) {
|
// Escapes text for HTML, so it shows as written inside an element or a
|
||||||
|
// quoted attribute and is never read as markup.
|
||||||
|
function escapeHTML(text) {
|
||||||
|
return text
|
||||||
|
.replaceAll("&", "&")
|
||||||
|
.replaceAll("<", "<")
|
||||||
|
.replaceAll(">", ">")
|
||||||
|
.replaceAll('"', """)
|
||||||
|
.replaceAll("'", "'");
|
||||||
|
}
|
||||||
|
|
||||||
|
export function hostRowHTML(host, index, showPin = true) {
|
||||||
const pinColor = host.pinned
|
const pinColor = host.pinned
|
||||||
? "text-blue-500"
|
? "text-blue-500"
|
||||||
: "text-gray-600 hover:text-gray-400";
|
: "text-gray-600 hover:text-gray-400";
|
||||||
@@ -721,12 +741,12 @@ function hostRowHTML(host, index, showPin = true) {
|
|||||||
<div class="w-[420px] flex-shrink-0 grid grid-cols-[minmax(0,1fr)_auto] items-center">
|
<div class="w-[420px] flex-shrink-0 grid grid-cols-[minmax(0,1fr)_auto] items-center">
|
||||||
<div class="flex items-center gap-2 min-w-[200px]">
|
<div class="flex items-center gap-2 min-w-[200px]">
|
||||||
<div class="w-3 h-3 rounded-full flex-shrink-0 bg-[#6b7280]"></div>
|
<div class="w-3 h-3 rounded-full flex-shrink-0 bg-[#6b7280]"></div>
|
||||||
<span class="font-medium text-white truncate">${host.name}</span>
|
<span class="font-medium text-white truncate">${escapeHTML(host.name)}</span>
|
||||||
</div>
|
</div>
|
||||||
<div class="latency-value text-4xl font-bold tabular-nums text-right mt-3" data-host="${index}">
|
<div class="latency-value text-4xl font-bold tabular-nums text-right mt-3" data-host="${index}">
|
||||||
<span class="text-gray-500">---</span>
|
<span class="text-gray-500">---</span>
|
||||||
</div>
|
</div>
|
||||||
<a href="${host.url}" target="_blank" rel="noopener" class="text-xs text-gray-500 truncate block col-span-2 -mt-2">${host.url}</a>
|
<a href="${escapeHTML(host.url)}" target="_blank" rel="noopener" class="text-xs text-gray-500 truncate block col-span-2 -mt-2">${escapeHTML(host.url)}</a>
|
||||||
<div class="${STATUS_TEXT_CLASS} text-gray-500" data-host="${index}">waiting...</div>
|
<div class="${STATUS_TEXT_CLASS} text-gray-500" data-host="${index}">waiting...</div>
|
||||||
</div>
|
</div>
|
||||||
<div class="flex-grow sparkline-container rounded overflow-hidden border border-gray-700/30">
|
<div class="flex-grow sparkline-container rounded overflow-hidden border border-gray-700/30">
|
||||||
@@ -1042,14 +1062,16 @@ function renderDebugLog() {
|
|||||||
info: "text-gray-300",
|
info: "text-gray-300",
|
||||||
debug: "text-gray-500",
|
debug: "text-gray-500",
|
||||||
};
|
};
|
||||||
el.innerHTML = debugLog
|
el.replaceChildren(
|
||||||
.map((entry) => {
|
...debugLog.map((entry) => {
|
||||||
const ts = formatUTCTimestamp(entry.timestamp);
|
const ts = formatUTCTimestamp(entry.timestamp);
|
||||||
const cls = levelColors[entry.level] || "text-gray-400";
|
|
||||||
const lvl = entry.level.toUpperCase().padEnd(7);
|
const lvl = entry.level.toUpperCase().padEnd(7);
|
||||||
return `<div class="${cls}">${ts} ${lvl} ${entry.message}</div>`;
|
const line = document.createElement("div");
|
||||||
})
|
line.className = levelColors[entry.level] || "text-gray-400";
|
||||||
.join("");
|
line.textContent = `${ts} ${lvl} ${entry.message}`;
|
||||||
|
return line;
|
||||||
|
}),
|
||||||
|
);
|
||||||
el.scrollTop = el.scrollHeight;
|
el.scrollTop = el.scrollHeight;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -8,6 +8,7 @@ import {
|
|||||||
AppState,
|
AppState,
|
||||||
CONFIG,
|
CONFIG,
|
||||||
greyOutUI,
|
greyOutUI,
|
||||||
|
hostRowHTML,
|
||||||
HostState,
|
HostState,
|
||||||
humanDuration,
|
humanDuration,
|
||||||
latencyClass,
|
latencyClass,
|
||||||
@@ -230,6 +231,32 @@ test("at a 30000ms interval, after the user pauses and resumes during a round, n
|
|||||||
}
|
}
|
||||||
});
|
});
|
||||||
|
|
||||||
|
// The page shows < > " & and ' in a row's markup as
|
||||||
|
// < > " & and '.
|
||||||
|
test(`a target whose name and URL hold < > " & and ' shows those characters in its row`, () => {
|
||||||
|
const host = new HostState({
|
||||||
|
name: `<b>"x" & 'y'</b>`,
|
||||||
|
url: `https://x.test/<b>?a="x"&b='y'`,
|
||||||
|
});
|
||||||
|
const row = hostRowHTML(host, 0);
|
||||||
|
assert.doesNotMatch(row, /<b>/);
|
||||||
|
assert.ok(
|
||||||
|
row.includes(
|
||||||
|
"><b>"x" & 'y'</b></span>",
|
||||||
|
),
|
||||||
|
);
|
||||||
|
assert.ok(
|
||||||
|
row.includes(
|
||||||
|
'href="https://x.test/<b>?a="x"&b='y'"',
|
||||||
|
),
|
||||||
|
);
|
||||||
|
assert.ok(
|
||||||
|
row.includes(
|
||||||
|
">https://x.test/<b>?a="x"&b='y'</a>",
|
||||||
|
),
|
||||||
|
);
|
||||||
|
});
|
||||||
|
|
||||||
for (const [seconds, text] of [
|
for (const [seconds, text] of [
|
||||||
[0, "0s"],
|
[0, "0s"],
|
||||||
[1, "1s"],
|
[1, "1s"],
|
||||||
|
|||||||
Reference in New Issue
Block a user