sneak/neoirc
1
0
Fork 0
Code Issues 10 Pull Requests 4 Actions 42 Packages Projects Releases Wiki Activity

The IRC listener tells peers Connection closed instead of the user's QUIT reason #216

New Issue
Open
opened 2026-10-27 14:21:59 +01:00 by clawbot · 0 comments
clawbot commented 2026-10-27 14:21:59 +01:00
Collaborator
Copy Link
Copy Source

On the IRC listener, handleQuit in internal/ircserver/commands.go reads the user's QUIT reason, sends it back in the ERROR :Closing Link line and marks the connection closed. When the connection then ends, cleanup in internal/ircserver/conn.go sends every peer a QUIT with the fixed reason Connection closed. The reason the user gave is lost, so peers on both transports see Connection closed for every IRC user who quits. Found by the rewrite of the README for #190; read from the code on ecf47c3.

Fix: the QUIT that peers receive carries the reason the user gave, or the listener's default Client quit when they gave none. A connection that ends without a QUIT keeps Connection closed. Change nothing else.

Definition of done

  1. An IRC listener user's QUIT :gone home reaches a peer on the IRC listener and a peer on the HTTP API with the reason gone home.
  2. A QUIT with no reason reaches peers as Client quit; a dropped connection still reaches them as Connection closed.
  3. Tests in internal/ircserver for items 1 and 2.
  4. If README.md describes the QUIT reason on the IRC listener, it says what the code now does.
  5. One reviewed PR against next.

Model: opus-5-5

On the IRC listener, `handleQuit` in `internal/ircserver/commands.go` reads the user's `QUIT` reason, sends it back in the `ERROR :Closing Link` line and marks the connection closed. When the connection then ends, `cleanup` in `internal/ircserver/conn.go` sends every peer a `QUIT` with the fixed reason `Connection closed`. The reason the user gave is lost, so peers on both transports see `Connection closed` for every IRC user who quits. Found by the rewrite of the README for https://git.eeqj.de/sneak/neoirc/issues/190; read from the code on `ecf47c3`. Fix: the `QUIT` that peers receive carries the reason the user gave, or the listener's default `Client quit` when they gave none. A connection that ends without a `QUIT` keeps `Connection closed`. Change nothing else. ## Definition of done 1. An IRC listener user's `QUIT :gone home` reaches a peer on the IRC listener and a peer on the HTTP API with the reason `gone home`. 2. A `QUIT` with no reason reaches peers as `Client quit`; a dropped connection still reaches them as `Connection closed`. 3. Tests in `internal/ircserver` for items 1 and 2. 4. If `README.md` describes the `QUIT` reason on the IRC listener, it says what the code now does. 5. One reviewed PR against `next`. Model: opus-5-5
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
critical
Extremely important: data loss, a security hole, production down, or basic use impossible
 merge-ready
All checks pass, reviewed, rebased, ready for merge
 needs-checks
make check does not pass cleanly
 needs-rebase
PR has merge conflicts or is behind main
 needs-review
Code review not yet done
 needs-rework
Code review found issues to fix
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
clawbot sneak (Jeffrey Paul)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/neoirc#216