Test databases lose all their data when a cancelled query makes the pool replace its connection #209

New Issue

2026-10-27T10:38:59+01:00

clawbot commented

2026-10-27 10:38:59 +01:00

Every package's tests open a shared in-memory SQLite database: NewTestDatabase in internal/db/export_test.go, and the test setup in internal/handlers/api_test.go, internal/ircserver/server_test.go, internal/server/server_test.go and internal/service/service_test.go (file:NAME?mode=memory&cache=shared). The server's pool has one connection. A query cancelled while it runs makes the driver report that connection broken, and the pool closes it. A shared in-memory database lasts only while a connection to it is open, so all its tables and rows are gone. That is what made TestIntegrationKill fail at random (#205), and the worker on it saw hundreds of no such table errors from other tests' cleanup. Any test whose query is cancelled, by a client going away or by the server stopping, can fail the same way at random and turn next red.

Fix: a test's database keeps its tables and rows when the pool closes and replaces its connection. Keep each test's database its own, and keep every package under the 20-second test target in REPO_POLICIES.md; a temporary file database was measured slower for internal/handlers (#204), so weigh that.

Definition of done

After a query cancelled while it runs, a test database still has its tables and rows.
A test in internal/db for item 1 that fails against the current helpers.
Every package's test time stays under 20 seconds.
One reviewed PR against next.

Model: opus-5-5

Every package's tests open a shared in-memory SQLite database: `NewTestDatabase` in `internal/db/export_test.go`, and the test setup in `internal/handlers/api_test.go`, `internal/ircserver/server_test.go`, `internal/server/server_test.go` and `internal/service/service_test.go` (`file:NAME?mode=memory&cache=shared`). The server's pool has one connection. A query cancelled while it runs makes the driver report that connection broken, and the pool closes it. A shared in-memory database lasts only while a connection to it is open, so all its tables and rows are gone. That is what made `TestIntegrationKill` fail at random (https://git.eeqj.de/sneak/neoirc/issues/205), and the worker on it saw hundreds of `no such table` errors from other tests' cleanup. Any test whose query is cancelled, by a client going away or by the server stopping, can fail the same way at random and turn `next` red. Fix: a test's database keeps its tables and rows when the pool closes and replaces its connection. Keep each test's database its own, and keep every package under the 20-second test target in `REPO_POLICIES.md`; a temporary file database was measured slower for `internal/handlers` (https://git.eeqj.de/sneak/neoirc/pulls/204), so weigh that. ## Definition of done 1. After a query cancelled while it runs, a test database still has its tables and rows. 2. A test in `internal/db` for item 1 that fails against the current helpers. 3. Every package's test time stays under 20 seconds. 4. One reviewed PR against `next`. Model: opus-5-5

clawbot referenced this issue

2026-10-27 10:39:22 +01:00

1.0: what stands between next and a release candidate #140

clawbot referenced this issue from a commit

2026-10-27 11:29:05 +01:00

Keep each test database when the pool replaces its connection (closes #209)

clawbot referenced a pull request that will close this issue

2026-10-27 11:33:39 +01:00

Keep each test database when the pool replaces its connection (closes #209) #210

clawbot commented

2026-10-27 11:33:46 +01:00

Built in #210: a test helper in internal/db holds one connection to each test database open until the test ends, so the database keeps its tables and rows when the pool replaces its connection. All five packages take their test database URL from it.

Model: opus-5-5

Built in https://git.eeqj.de/sneak/neoirc/pulls/210: a test helper in `internal/db` holds one connection to each test database open until the test ends, so the database keeps its tables and rows when the pool replaces its connection. All five packages take their test database URL from it. Model: opus-5-5

clawbot referenced this issue

2026-10-27 11:39:04 +01:00

internal/server tests can fail at random when another process takes the port they picked #211

clawbot referenced this issue

2026-10-27 11:48:09 +01:00

Keep each test database when the pool replaces its connection (closes #209) #210

clawbot referenced this issue from a commit

2026-10-27 11:56:47 +01:00

Keep each test database when the pool replaces its connection (closes #209)

clawbot referenced this issue

2026-10-27 12:09:41 +01:00

Keep each test database when the pool replaces its connection (closes #209) #210