sneak/neoirc
1
0
Fork 0
Code Issues 4 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Repo standards audit: divergences from EXISTING_REPO_CHECKLIST #17

New Issue
Closed
opened 2026-02-26 15:08:01 +01:00 by clawbot · 1 comment
clawbot commented 2026-02-26 15:08:01 +01:00
Collaborator
Copy Link
Copy Source

Audit of sneak/chat against EXISTING_REPO_CHECKLIST.md and REPO_POLICIES.md.

Divergences Found

Critical: Build Broken on main

  • Duplicate method declarations in internal/db/db.go and internal/db/queries.go (CreateUser, GetUserByToken, GetUserByNick) — code does not compile

Required Files Missing

  • LICENSE file missing (README says MIT but no LICENSE file)
  • REPO_POLICIES.md missing (has CONVENTIONS.md instead — wrong name, wrong content)
  • .editorconfig missing
  • .gitea/workflows/check.yml missing (no CI)

Makefile Issues

  • Missing fmt-check target
  • Missing docker target
  • Missing hooks target
  • make test has no 30-second timeout
  • make check does not use fmt-check as a prerequisite (inlines format check instead)

Dockerfile Issues

  • Dockerfile does not run make check as a build step
  • FROM golang:1.24-alpine — mutable tag, not pinned by sha256 hash
  • FROM alpine:3.21 — mutable tag, not pinned by sha256 hash

.gitignore Issues

  • Missing OS files: .DS_Store, Thumbs.db
  • Missing editor files: *.swp, *.swo, *~, *.bak, .idea/, .vscode/, *.sublime-*
  • Missing secrets: .env.*, *.pem, *.key

.dockerignore Issues

  • Should match standard template (missing .DS_Store, node_modules)

JS/Web Issues

  • web/package-lock.json exists — should use yarn not npm (per REPO_POLICIES)

Code Quality

  • 380 golangci-lint issues on current main (wsl_v5: 156, nlreturn: 107, errcheck: 15, etc.)

README Issues

  • Missing Author section with [@sneak](https://sneak.berlin) link format
Audit of sneak/chat against [EXISTING_REPO_CHECKLIST.md](https://git.eeqj.de/sneak/prompts/src/branch/main/prompts/EXISTING_REPO_CHECKLIST.md) and [REPO_POLICIES.md](https://git.eeqj.de/sneak/prompts/src/branch/main/prompts/REPO_POLICIES.md). ## Divergences Found ### Critical: Build Broken on main - [ ] Duplicate method declarations in `internal/db/db.go` and `internal/db/queries.go` (`CreateUser`, `GetUserByToken`, `GetUserByNick`) — code does not compile ### Required Files Missing - [ ] `LICENSE` file missing (README says MIT but no LICENSE file) - [ ] `REPO_POLICIES.md` missing (has `CONVENTIONS.md` instead — wrong name, wrong content) - [ ] `.editorconfig` missing - [ ] `.gitea/workflows/check.yml` missing (no CI) ### Makefile Issues - [ ] Missing `fmt-check` target - [ ] Missing `docker` target - [ ] Missing `hooks` target - [ ] `make test` has no 30-second timeout - [ ] `make check` does not use `fmt-check` as a prerequisite (inlines format check instead) ### Dockerfile Issues - [ ] Dockerfile does not run `make check` as a build step - [ ] `FROM golang:1.24-alpine` — mutable tag, not pinned by sha256 hash - [ ] `FROM alpine:3.21` — mutable tag, not pinned by sha256 hash ### .gitignore Issues - [ ] Missing OS files: `.DS_Store`, `Thumbs.db` - [ ] Missing editor files: `*.swp`, `*.swo`, `*~`, `*.bak`, `.idea/`, `.vscode/`, `*.sublime-*` - [ ] Missing secrets: `.env.*`, `*.pem`, `*.key` ### .dockerignore Issues - [ ] Should match standard template (missing `.DS_Store`, `node_modules`) ### JS/Web Issues - [ ] `web/package-lock.json` exists — should use `yarn` not `npm` (per REPO_POLICIES) ### Code Quality - [ ] 380 golangci-lint issues on current main (wsl_v5: 156, nlreturn: 107, errcheck: 15, etc.) ### README Issues - [ ] Missing Author section with `[@sneak](https://sneak.berlin)` link format
clawbot self-assigned this 2026-02-26 15:08:01 +01:00
clawbot commented 2026-02-26 15:08:09 +01:00
Author
Collaborator
Copy Link
Copy Source

Acknowledged — starting work on fixing these divergences now.

Acknowledged — starting work on fixing these divergences now.
sneak closed this issue 2026-02-27 05:10:00 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
merge-ready
All checks pass, reviewed, rebased, ready for merge
 needs-checks
make check does not pass cleanly
 needs-rebase
PR has merge conflicts or is behind main
 needs-review
Code review not yet done
 needs-rework
Code review found issues to fix
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
clawbot sneak (Jeffrey Paul)
No Assignees clawbot
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/neoirc#17