internal/handlers tests make make test miss its 20-second target #113

Closed
opened 2026-10-06 01:32:43 +02:00 by clawbot · 1 comment
Collaborator

REPO_POLICIES.md sets a target of under 20 seconds for the test run. In the go test -race run of the Docker test phase on next, internal/handlers takes about 20 to 34 seconds; every other package finishes in about 2 seconds or less. The suite is still under the policy's 60-second hard cap, so this is an improvement, not a red gate.

Definition of done

  1. Find where internal/handlers tests spend their time and remove that cost at its cause (for example a wait, a long-poll timeout or per-test setup that does not need to be that slow), so that every package's time as go test -race reports it in the Docker test phase is under 20 seconds. Compiling the test phase is not counted here: whether the cap covers it is open for the owner on sneak/prompts#113.
  2. No test is removed, skipped or weakened, -race stays, and the test timeout is not changed.
  3. One reviewed PR against next.

(Corrected 2026-10-06: the first version counted the whole test step, compile included, which test changes cannot bring under 20 seconds.)

Model: opus-5-5

`REPO_POLICIES.md` sets a target of under 20 seconds for the test run. In the `go test -race` run of the Docker test phase on `next`, `internal/handlers` takes about 20 to 34 seconds; every other package finishes in about 2 seconds or less. The suite is still under the policy's 60-second hard cap, so this is an improvement, not a red gate. ## Definition of done 1. Find where `internal/handlers` tests spend their time and remove that cost at its cause (for example a wait, a long-poll timeout or per-test setup that does not need to be that slow), so that every package's time as `go test -race` reports it in the Docker test phase is under 20 seconds. Compiling the test phase is not counted here: whether the cap covers it is open for the owner on https://git.eeqj.de/sneak/prompts/issues/113. 2. No test is removed, skipped or weakened, `-race` stays, and the test timeout is not changed. 3. One reviewed PR against `next`. (Corrected 2026-10-06: the first version counted the whole test step, compile included, which test changes cannot bring under 20 seconds.) Model: opus-5-5
clawbot self-assigned this 2026-10-06 01:32:43 +02:00
Author
Collaborator

#116: the time went to SQLite running under the unsafe-pointer checks that -race turns on; the test phase now turns those checks off for the modernc.org packages only. No test changed.

Model: opus-5-5

https://git.eeqj.de/sneak/neoirc/pulls/116: the time went to SQLite running under the unsafe-pointer checks that `-race` turns on; the test phase now turns those checks off for the `modernc.org` packages only. No test changed. Model: opus-5-5
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/neoirc#113