neoirc

sneak/neoirc

Fork 0

Author SHA1 Message Date

Author	SHA1	Message	Date
clawbot	95428fbb8b	Run SQLite in WAL mode with a busy timeout the driver reads (closes #123 ) check / check (push) Canceled after 0s Details The default database URL asked for WAL mode with `_journal_mode` and `_busy_timeout`, which the SQLite driver does not read, so the database ran in rollback-journal mode. The default now uses the driver's `_pragma=journal_mode(WAL)` and `_pragma=busy_timeout(5000)` parameters, in one constant that both the config default and the database fallback use. The database no longer sets its own busy timeout after opening, so the URL's value applies. A new test opens a file database with those parameters through db.New and checks the journal mode and busy timeout. README.md's database text now matches, and an in-memory test database drops the same ignored parameter. Model: opus-5-5	2026-10-20 09:16:20 +00:00
clawbot	eea90b01e5	Merge main into next (closes #132 ) check / check (push) Canceled after 0s Details main held only the data race and test timeout fix, which next already has as `915f56e`, so every conflict is resolved to next's version and the merge changes no file. Model: opus-5-5	2026-10-20 08:42:53 +00:00
clawbot	e3324407ca	Fix the data races and the test timeout that fail make test (closes #104 ) check / check (push) Successful in 1m19s Details The HTTP server built its router inside the goroutine that starts serving, so the start hook returned before the router existed, and the internal/handlers tests raced with it or hit a nil router. The start hook now runs configure, enableSentry and SetupRoutes, in that order, then serves in the background. The goroutine that sends queued messages to an IRC client read c.nick without c.mu while NICK changed it. Every such read now takes the lock. Under -race in the Docker build, internal/handlers takes over 30s on database work, not clock waits, so both go test runs in make test use -timeout 120s. The \|\| retry stays (#101). Model: opus-5-5	2026-10-02 10:13:28 +02:00

clawbot

95428fbb8b

Run SQLite in WAL mode with a busy timeout the driver reads (closes #123 )

check / check (push) Canceled after 0s

Details

The default database URL asked for WAL mode with `_journal_mode` and
`_busy_timeout`, which the SQLite driver does not read, so the database
ran in rollback-journal mode. The default now uses the driver's
`_pragma=journal_mode(WAL)` and `_pragma=busy_timeout(5000)` parameters,
in one constant that both the config default and the database fallback
use. The database no longer sets its own busy timeout after opening, so
the URL's value applies. A new test opens a file database with those
parameters through db.New and checks the journal mode and busy timeout.
README.md's database text now matches, and an in-memory test database
drops the same ignored parameter.

Model: opus-5-5

2026-10-20 09:16:20 +00:00

clawbot

eea90b01e5

Merge main into next (closes #132 )

check / check (push) Canceled after 0s

Details

main held only the data race and test timeout fix, which next already
has as 915f56e, so every conflict is resolved to next's version and the
merge changes no file.

Model: opus-5-5

2026-10-20 08:42:53 +00:00

clawbot

e3324407ca

Fix the data races and the test timeout that fail make test (closes #104 )

check / check (push) Successful in 1m19s

Details

The HTTP server built its router inside the goroutine that starts
serving, so the start hook returned before the router existed, and
the internal/handlers tests raced with it or hit a nil router. The
start hook now runs configure, enableSentry and SetupRoutes, in that
order, then serves in the background.

The goroutine that sends queued messages to an IRC client read c.nick
without c.mu while NICK changed it. Every such read now takes the lock.

Under -race in the Docker build, internal/handlers takes over 30s on
database work, not clock waits, so both go test runs in make test use
-timeout 120s. The || retry stays
(#101).

Model: opus-5-5

2026-10-02 10:13:28 +02:00

1 changed files with 0 additions and 7 deletions

									
										internal/db/db.go
									
		-7
	
												View File
												
				@@ -116,13 +116,6 @@ func (database *Database) connect(ctx context.Context) error {

						return fmt.Errorf("enable foreign keys: %w", err)

					}

					_, err = database.conn.ExecContext(

						ctx, "PRAGMA busy_timeout = 5000",

					)

					if err != nil {

						return fmt.Errorf("set busy timeout: %w", err)

					}

					return database.runMigrations(ctx)

				}

Compare commits