Fix IRC listener relay of bodies and modes, and JOIN names (closes #127)

The IRC listener relayed only the first line of a PRIVMSG or NOTICE
body; it now sends one line per body line. A MODE change reached IRC
listener members without its key, limit or mask, and "+o bob" went out
as one trailing parameter; each value is now its own parameter, in the
relay and in the echo to the IRC listener user who made the change.
Every line written to an IRC listener connection now has CR, LF and NUL
removed, so a stored body line, key or mask cannot start a line of its
own. The channel name check moved from the HTTP handler into
service.JoinChannel, so the IRC listener's JOIN refuses the same names
with 403.

Model: opus-5-5

internal/ircserver/relay_test.go

@@ -148,30 +148,30 @@ func TestRelayLineBreaks(t *testing.T) {
 
 	env := newTestEnv(t)
 
-	alice := env.dial(t)
-	alice.register("alice")
+	bob := env.dial(t)
+	bob.register("bob")
 
-	env.queueMessage(t, "alice", "PRIVMSG", "carol", "alice", []string{
-		"one\r\n:admin!a@b PRIVMSG alice :hi",
-		"two\n:admin!a@b NOTICE alice :hi\x00",
+	env.queueMessage(t, "bob", "PRIVMSG", "carol", "bob", []string{
+		"one\r\n:admin!a@b PRIVMSG bob :hi",
+		"two\n:admin!a@b NOTICE bob :hi\x00",
 	})
-	env.queueMessage(t, "alice", "MODE", "op", "#breaks",
+	env.queueMessage(t, "bob", "MODE", "op", "#breaks",
 		[]string{"+k", "key\r\nERROR :Closing link"})
-	env.queueMessage(t, "alice", "MODE", "op", "#breaks",
-		[]string{"+b", "*!*@*\r\n:admin!a@b KICK #breaks alice"})
-	env.queueMessage(t, "alice", "PRIVMSG", "carol", "alice",
+	env.queueMessage(t, "bob", "MODE", "op", "#breaks",
+		[]string{"+b", "*!*@*\r\n:admin!a@b KICK #breaks bob"})
+	env.queueMessage(t, "bob", "PRIVMSG", "carol", "bob",
 		[]string{"the end"})
 
-	lines := alice.readUntil(func(l string) bool {
+	lines := bob.readUntil(func(l string) bool {
 		return strings.HasSuffix(l, " :the end")
 	})
 
 	want := []string{
-		":carol!carol@* PRIVMSG alice :one:admin!a@b PRIVMSG alice :hi",
-		":carol!carol@* PRIVMSG alice :two:admin!a@b NOTICE alice :hi",
+		":carol!carol@* PRIVMSG bob :one:admin!a@b PRIVMSG bob :hi",
+		":carol!carol@* PRIVMSG bob :two:admin!a@b NOTICE bob :hi",
 		":op!op@* MODE #breaks +k :keyERROR :Closing link",
-		":op!op@* MODE #breaks +b :*!*@*:admin!a@b KICK #breaks alice",
-		":carol!carol@* PRIVMSG alice :the end",
+		":op!op@* MODE #breaks +b :*!*@*:admin!a@b KICK #breaks bob",
+		":carol!carol@* PRIVMSG bob :the end",
 	}
 
 	got := lines[max(0, len(lines)-len(want)):]