Keep neoirc-cli responding when a key or a typed line updates the screen (closes #223)

The Enter handler of the input line and the Alt and digit key handler
ran the typed line on the tview event loop. Every UI method that
changes the screen waits for that loop, so the client stopped
responding. Each line now runs on its own goroutine, which first waits
for the line before it, so lines keep the order they were typed in.

/window now runs off the event loop. It reads the buffer name through
the new BufferName, which runs on the loop, instead of reading the
buffer list directly.

A new test drives a running UI on a simulation screen with Alt and 1,
then a typed line and Enter.

Model: opus-5-5

internal/cli/app.go

@@ -610,17 +610,14 @@ func (a *App) cmdWindow(args string) {
 
 	_, _ = fmt.Sscanf(args, "%d", &bufIndex)
 
+	a.ui.SwitchBuffer(bufIndex)
+
 	a.mu.Lock()
 	nick := a.nick
 	a.mu.Unlock()
 
-	// Read the name before switching. A message from the server can
-	// add a buffer at any time, but only at the end, so bufIndex
-	// still names this buffer when SwitchBuffer runs.
 	name, found := a.ui.BufferName(bufIndex)
 	if found {
-		a.ui.SwitchBuffer(bufIndex)
-
 		if name != "(status)" {
 			a.mu.Lock()
 			a.target = name

internal/cli/app_internal_test.go

@@ -25,10 +25,6 @@ const (
 // be handled, or for the UI to stop, before it fails.
 const eventLoopTimeout = 5 * time.Second
 
-// holdTime is how long TestLinesKeepOrder holds the first line,
-// which gives the second line time to start too early.
-const holdTime = 200 * time.Millisecond
-
 func TestMemberPrefix(t *testing.T) {
 	t.Parallel()
 
@@ -287,8 +283,8 @@ func TestAltDigit(t *testing.T) {
 }
 
 // TestEventLoopKeepsRunning sends Alt and 1, then a typed line and
-// Enter, to a running UI. It checks that both are handled, so the
+// Enter, to a running UI. It checks that both are handled, in that
-// event loop did not stop on either.
+// order, so the event loop did not stop on either.
 func TestEventLoopKeepsRunning(t *testing.T) {
 	t.Parallel()
 
@@ -314,40 +310,6 @@ func TestEventLoopKeepsRunning(t *testing.T) {
 	waitHandled(t, handled, testText)
 }
 
-// TestLinesKeepOrder holds the handling of a first line until a
-// second line has been passed in. It fails if the second line is
-// handled while the first is still held.
-func TestLinesKeepOrder(t *testing.T) {
-	t.Parallel()
-
-	const firstLine, secondLine = "one", "two"
-
-	ui := NewUI()
-	handled := make(chan string)
-	release := make(chan struct{})
-
-	ui.OnInput(func(text string) {
-		if text == firstLine {
-			<-release
-		}
-
-		handled <- text
-	})
-
-	ui.callOnInput(firstLine)
-	ui.callOnInput(secondLine)
-
-	select {
-	case got := <-handled:
-		t.Fatalf("handled %q while the first line was held", got)
-	case <-time.After(holdTime):
-	}
-
-	close(release)
-	waitHandled(t, handled, firstLine)
-	waitHandled(t, handled, secondLine)
-}
-
 // TestOwnEventFromOtherClient checks that a message, notice,
 // join or part that the user's session makes from another
 // client shows as one line in the buffer it belongs to.