Share the ADMIN text and KILL reason, and test the review's gaps
check / check (push) Canceled after 0s
check / check (push) Canceled after 0s
ADMIN's location and email lines come from service.AdminLines, and KillUser applies the default reason, so both transports send the same reply. The Disconnect test now allows a quarter of one write window, so a Disconnect that writes before returning fails it. QueryUserMode and UserhostReply are tested with a read that fails. The handler tests again cover USERHOST for a nick with no session, MODE +o on your own nick, and the status of a successful KILL. handleMode's comment says what it does. Model: opus-5-5
This commit is contained in:
@@ -119,6 +119,15 @@ func (s *Service) InfoLines() []string {
|
||||
}
|
||||
}
|
||||
|
||||
// AdminLines returns the texts of the RPL_ADMINLOC1,
|
||||
// RPL_ADMINLOC2 and RPL_ADMINEMAIL replies, in that order,
|
||||
// that ADMIN sends on both transports.
|
||||
func (s *Service) AdminLines(
|
||||
serverName string,
|
||||
) (string, string, string) {
|
||||
return "neoirc server", "IRC over HTTP", "admin@" + serverName
|
||||
}
|
||||
|
||||
// UserhostReply returns the RPL_USERHOST text for the first
|
||||
// five of the given nicks: "nick=+user@host" entries joined
|
||||
// by spaces, with * after the nick of an operator and - in
|
||||
@@ -199,7 +208,8 @@ func (s *Service) UnregisterWireConn(
|
||||
|
||||
// KillUser carries out an operator's KILL: the target's
|
||||
// channel peers see it quit, its session is deleted, and
|
||||
// its IRC connection, if it has one, is closed.
|
||||
// its IRC connection, if it has one, is closed. An empty
|
||||
// reason is given as "KILLed".
|
||||
func (s *Service) KillUser(
|
||||
ctx context.Context,
|
||||
sessionID int64,
|
||||
@@ -231,6 +241,10 @@ func (s *Service) KillUser(
|
||||
}
|
||||
}
|
||||
|
||||
if reason == "" {
|
||||
reason = "KILLed"
|
||||
}
|
||||
|
||||
quitReason := "Killed (" + nick + " (" + reason + "))"
|
||||
|
||||
s.BroadcastQuit(ctx, targetSID, targetNick, quitReason)
|
||||
|
||||
Reference in New Issue
Block a user