diff --git a/internal/server/server.go b/internal/server/server.go index 50216fa..1006342 100644 --- a/internal/server/server.go +++ b/internal/server/server.go @@ -71,7 +71,14 @@ func New( lifecycle.Append(fx.Hook{ OnStart: func(_ context.Context) error { srv.startupTime = time.Now() - go srv.Run() //nolint:contextcheck + + // Build the router before OnStart returns, so srv can + // handle requests as soon as the app has started. + srv.configure() + srv.enableSentry() + srv.SetupRoutes() + + go srv.serve() //nolint:contextcheck return nil }, @@ -83,13 +90,6 @@ func New( return srv, nil } -// Run starts the server configuration, Sentry, and begins serving. -func (srv *Server) Run() { - srv.configure() - srv.enableSentry() - srv.serve() -} - // ServeHTTP delegates to the chi router. func (srv *Server) ServeHTTP( writer http.ResponseWriter, @@ -202,8 +202,6 @@ func (srv *Server) serveUntilShutdown() { Handler: srv, } - srv.SetupRoutes() - srv.log.Info( "http begin listen", "listenaddr", listenAddr, )