sneak/mfer
1
0
Fork 0
Code Issues 9 Pull Requests 3 Actions 18 Releases Wiki Activity

Loading a manifest ignores the inner message version #169

New Issue
Closed
opened 2026-10-07 10:38:41 +02:00 by clawbot · 1 comment
clawbot commented 2026-10-07 10:38:41 +02:00
Collaborator
Copy Link
Copy Source

Problem

docs/FORMAT.md says the inner message's version (field 100 of MFFile) must be VERSION_ONE, but deserializeInner in mfer/deserialize.go checks only the outer message's version. An inner message with version 0, or a later version, loads as if it were version one.

Definition of done

  • Failing test first: a manifest built with an inner version other than VERSION_ONE is refused when loaded, with the same error as an unknown outer version.
  • deserializeInner refuses it.
  • make check passes.

Model: opus-5-5

## Problem `docs/FORMAT.md` says the inner message's `version` (field 100 of `MFFile`) must be `VERSION_ONE`, but `deserializeInner` in `mfer/deserialize.go` checks only the outer message's version. An inner message with version 0, or a later version, loads as if it were version one. ## Definition of done - Failing test first: a manifest built with an inner version other than `VERSION_ONE` is refused when loaded, with the same error as an unknown outer version. - `deserializeInner` refuses it. - `make check` passes. Model: opus-5-5
clawbot commented 2026-10-07 14:42:26 +02:00
Author
Collaborator
Copy Link
Copy Source

Fixed in #173: loading now refuses an inner message whose version is not VERSION_ONE, with the same error as an unknown outer version. Two existing tests that built inner messages with no version now write version one.

Model: opus-5-5

Fixed in https://git.eeqj.de/sneak/mfer/pulls/173: loading now refuses an inner message whose `version` is not `VERSION_ONE`, with the same error as an unknown outer version. Two existing tests that built inner messages with no version now write version one. Model: opus-5-5
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
critical
Extremely important: data loss, a security hole, production down, or basic use impossible
 merge-ready
All checks pass, reviewed, rebased, ready for merge
 needs-checks
make check does not pass cleanly
 needs-rebase
PR has merge conflicts or is behind main
 needs-review
Code review not yet done
 needs-rework
Code review found issues to fix
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
clawbot sneak (Jeffrey Paul)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/mfer#169