From 7b61bdd62b80ffe30835a1ac2e34d5bb90a602a5 Mon Sep 17 00:00:00 2001 From: clawbot Date: Thu, 19 Feb 2026 23:41:14 -0800 Subject: [PATCH] fix: handle errcheck warnings in gpg.go and gpg_test.go --- mfer/gpg.go | 4 ++-- mfer/gpg_test.go | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/mfer/gpg.go b/mfer/gpg.go index c587b2e..943f102 100644 --- a/mfer/gpg.go +++ b/mfer/gpg.go @@ -100,7 +100,7 @@ func gpgExtractPubKeyFingerprint(pubKey []byte) (string, error) { if err != nil { return "", fmt.Errorf("failed to create temp dir: %w", err) } - defer os.RemoveAll(tmpDir) + defer func() { _ = os.RemoveAll(tmpDir) }() // Set restrictive permissions if err := os.Chmod(tmpDir, 0o700); err != nil { @@ -158,7 +158,7 @@ func gpgVerify(data, signature, pubKey []byte) error { if err != nil { return fmt.Errorf("failed to create temp dir: %w", err) } - defer os.RemoveAll(tmpDir) + defer func() { _ = os.RemoveAll(tmpDir) }() // Set restrictive permissions if err := os.Chmod(tmpDir, 0o700); err != nil { diff --git a/mfer/gpg_test.go b/mfer/gpg_test.go index 97f72e2..badc8ca 100644 --- a/mfer/gpg_test.go +++ b/mfer/gpg_test.go @@ -34,15 +34,15 @@ func testGPGEnv(t *testing.T) (GPGKeyID, func()) { // Save original GNUPGHOME and set new one origGPGHome := os.Getenv("GNUPGHOME") - os.Setenv("GNUPGHOME", gpgHome) + require.NoError(t, os.Setenv("GNUPGHOME", gpgHome)) cleanup := func() { if origGPGHome == "" { - os.Unsetenv("GNUPGHOME") + _ = os.Unsetenv("GNUPGHOME") } else { - os.Setenv("GNUPGHOME", origGPGHome) + _ = os.Setenv("GNUPGHOME", origGPGHome) } - os.RemoveAll(gpgHome) + _ = os.RemoveAll(gpgHome) } // Generate a test key with no passphrase