Arguments are checked only after the mnemonic has been read #79

New Issue

2026-10-13T00:50:54+02:00

clawbot commented

2026-10-13 00:50:54 +02:00

A key index above the largest, a --words the tool does not offer, a --to that is not a recipient, and an input file that cannot be opened are all reported only after the mnemonic has been obtained: after the user has typed it at the prompt, or after the mnemonic command has run, which for secret, a password manager or a hardware token means a passphrase prompt or a touch for nothing.

Where: internal/cli/age/age.go:380-397 (derived reads the mnemonic, then derive.Bytes checks the index); internal/cli/age/age.go:111-130 with internal/agekey/agekey.go:135-148 (--to is parsed inside the work, after the mnemonic and after the input file is opened); internal/cli/mnemonic/mnemonic.go:43-65 (--words is checked by childmnemonic.Derive, after the mnemonic).

How to see: on a terminal with no mnemonic source,

./keyfunc mnemonic --words 13

prompts mnemonic: first and says a child mnemonic has 12, 18 or 24 words, not 13 only after the mnemonic is typed. Likewise ./keyfunc age pub -n 2147483648 and ./keyfunc age encrypt --to bogus file.

Definition of done: every argument check (index at most 2147483647, --words, --to recipients parse, input file opens) runs before the mnemonic is looked for. Tests in internal/cli/cli_test.go and internal/cli/age_test.go set KEYFUNC_MNEMONIC_COMMAND to a command that fails loudly and check that the argument error, not the command's failure, is what comes back.

Severity: minor. No wrong key and nothing lost; the user gives up their secret, or triggers their secret manager, for a run that cannot succeed.

Model: fable-5-1

A key index above the largest, a `--words` the tool does not offer, a `--to` that is not a recipient, and an input file that cannot be opened are all reported only after the mnemonic has been obtained: after the user has typed it at the prompt, or after the mnemonic command has run, which for `secret`, a password manager or a hardware token means a passphrase prompt or a touch for nothing. Where: `internal/cli/age/age.go:380-397` (`derived` reads the mnemonic, then `derive.Bytes` checks the index); `internal/cli/age/age.go:111-130` with `internal/agekey/agekey.go:135-148` (`--to` is parsed inside the work, after the mnemonic and after the input file is opened); `internal/cli/mnemonic/mnemonic.go:43-65` (`--words` is checked by `childmnemonic.Derive`, after the mnemonic). How to see: on a terminal with no mnemonic source, ./keyfunc mnemonic --words 13 prompts `mnemonic:` first and says `a child mnemonic has 12, 18 or 24 words, not 13` only after the mnemonic is typed. Likewise `./keyfunc age pub -n 2147483648` and `./keyfunc age encrypt --to bogus file`. **Definition of done**: every argument check (index at most 2147483647, `--words`, `--to` recipients parse, input file opens) runs before the mnemonic is looked for. Tests in `internal/cli/cli_test.go` and `internal/cli/age_test.go` set `KEYFUNC_MNEMONIC_COMMAND` to a command that fails loudly and check that the argument error, not the command's failure, is what comes back. Severity: minor. No wrong key and nothing lost; the user gives up their secret, or triggers their secret manager, for a run that cannot succeed. Model: fable-5-1

clawbot referenced this issue

2026-10-13 02:03:24 +02:00

Read --index and --words as decimal numbers (closes #75) #81

clawbot referenced this issue

2026-10-13 02:03:24 +02:00

Read --index and --words as decimal numbers (closes #75) #81

clawbot referenced this issue

2026-10-13 02:34:11 +02:00

Finish 1.0 and tag it; after that, bugfixes only #73

clawbot referenced this issue

2026-10-13 02:38:06 +02:00

next → main: v1.0.0-rc2 #82