sneak/keyfunc
1
0
Fork 0
Code Issues 2 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Ctrl-D at the mnemonic prompt is ignored; only a mnemonic or a signal ends the prompt #78

New Issue
Closed
opened 2026-10-13 00:50:53 +02:00 by clawbot · 2 comments
clawbot commented 2026-10-13 00:50:53 +02:00
Collaborator
Copy Link
Copy Source

At the terminal prompt (mnemonic: ), pressing Ctrl-D (end of input) does nothing: the tool goes on waiting, however often it is pressed. The only ways out are typing a mnemonic or a signal (Ctrl-C). The README says the prompt reads "with echo turned off" and says what signals do; a user who wants to back out of the prompt expects Ctrl-D to end it, as it does for ssh or sudo.

Where: internal/mnemonic/mnemonic.go:96, term.ReadPassword. The library reads the terminal one byte at a time with a raw read that returns 0 bytes on Ctrl-D, and treats 0 bytes as "nothing yet" and reads again.

How to see: on a terminal, with no mnemonic source set,

./keyfunc age pub

then press Ctrl-D at the prompt, twice: nothing happens. Ctrl-C ends it with status 130.

Definition of done: end of input at the prompt ends the tool with a message on standard error, status 1 and the terminal's echo restored, and the README's "Giving it the mnemonic" says so. A test that runs the tool as a subprocess on a pseudo-terminal (as internal/cli/age_test.go already runs it as a subprocess) and sends end of input at the prompt.

Severity: minor. Nothing is derived or lost; the user is stuck until Ctrl-C.

Model: fable-5-1

At the terminal prompt (`mnemonic: `), pressing Ctrl-D (end of input) does nothing: the tool goes on waiting, however often it is pressed. The only ways out are typing a mnemonic or a signal (Ctrl-C). The README says the prompt reads "with echo turned off" and says what signals do; a user who wants to back out of the prompt expects Ctrl-D to end it, as it does for `ssh` or `sudo`. Where: `internal/mnemonic/mnemonic.go:96`, `term.ReadPassword`. The library reads the terminal one byte at a time with a raw read that returns 0 bytes on Ctrl-D, and treats 0 bytes as "nothing yet" and reads again. How to see: on a terminal, with no mnemonic source set, ./keyfunc age pub then press Ctrl-D at the prompt, twice: nothing happens. Ctrl-C ends it with status 130. **Definition of done**: end of input at the prompt ends the tool with a message on standard error, status 1 and the terminal's echo restored, and the README's "Giving it the mnemonic" says so. A test that runs the tool as a subprocess on a pseudo-terminal (as `internal/cli/age_test.go` already runs it as a subprocess) and sends end of input at the prompt. Severity: minor. Nothing is derived or lost; the user is stuck until Ctrl-C. Model: fable-5-1
clawbot commented 2026-10-14 19:40:24 +02:00
Author
Collaborator
Copy Link
Copy Source

Plan: as written. The pseudo-terminal test uses github.com/creack/pty at v1.1.25-0.20260601142114-9246436fffe8 (v1.1.24's Open on Linux can return another pty's terminal). It starts after #76 lands, which changes the same file.

Model: opus-5-5

Plan: as written. The pseudo-terminal test uses `github.com/creack/pty` at `v1.1.25-0.20260601142114-9246436fffe8` (v1.1.24's `Open` on Linux can return another pty's terminal). It starts after https://git.eeqj.de/sneak/keyfunc/issues/76 lands, which changes the same file. Model: opus-5-5
clawbot commented 2026-10-14 22:30:25 +02:00
Author
Collaborator
Copy Link
Copy Source

Fixed in #90: on the Unix systems the prompt reads the line itself instead of through term.ReadPassword, so Ctrl-D ends it. With nothing typed the mnemonic is empty and refused with status 1, and the terminal settings are put back. Windows and the other systems keep term.ReadPassword.

Model: opus-5-5

Fixed in https://git.eeqj.de/sneak/keyfunc/pulls/90: on the Unix systems the prompt reads the line itself instead of through `term.ReadPassword`, so Ctrl-D ends it. With nothing typed the mnemonic is empty and refused with status 1, and the terminal settings are put back. Windows and the other systems keep `term.ReadPassword`. Model: opus-5-5
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
critical
Extremely important: data loss, a security hole, production down, or basic use impossible
 merge-ready
reviewed and ready to merge
 needs-checks
waiting for checks to pass
 needs-rebase
Conflicts with the current next; rebase before review
 needs-review
waiting for review
 needs-rework
review found things to fix
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
clawbot sneak (Jeffrey Paul)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/keyfunc#78