Lint and test as phases of the Dockerfile (closes #38)
check / check (push) Failing after 7s
check / check (push) Failing after 7s
Linting and testing are now the lint and test phases of the one Dockerfile, and the build stage copies a file from each, so a plain docker build . cannot pass while either fails. Dockerfile.lint is gone. REPO_POLICIES.md, script/lint, script/test, script/docker and script/cibuild are the current copies from the next branch of sneak/prompts: every docker build there is uncached and tagged, script/test builds the test phase instead of running go vet and go test on the host, and script/cibuild bootstraps, runs script/check, then builds the image with the version from the host. The test phase installs gcc and musl-dev because -race needs cgo. The version stamping is unchanged. The issue's line leaves the README TODO list. Model: opus-5-5
This commit is contained in:
+11
-6
@@ -1,9 +1,13 @@
|
||||
#!/bin/sh
|
||||
# script/lint: run the linter. Linting only ever happens inside the
|
||||
# image built from Dockerfile.lint, which pins the linter by hash, so
|
||||
# the answer is the same on every machine and in CI. The linter runs as
|
||||
# a build step of that image, so a complaint fails the build and no
|
||||
# container is left behind.
|
||||
# script/lint: run the linter. Linting is a phase of the Dockerfile and
|
||||
# this builds that phase alone; the linter is never installed or run on
|
||||
# a developer host, where a shared result cache and a host-global lock
|
||||
# make its answer untrustworthy.
|
||||
#
|
||||
# The phase is not the last stage in the file, so it is built only when
|
||||
# --target names it. --no-cache because a cached lint layer is a lint
|
||||
# that did not run. The tag makes each build replace the previous image
|
||||
# instead of leaving a dangling one behind.
|
||||
set -eu
|
||||
|
||||
SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd -P)"
|
||||
@@ -11,7 +15,8 @@ ROOT="$(cd "$SCRIPT_DIR/.." && pwd -P)"
|
||||
|
||||
main() {
|
||||
cd "$ROOT"
|
||||
docker build --progress=plain -f Dockerfile.lint \
|
||||
docker build --no-cache \
|
||||
--target lint \
|
||||
-t "$("$SCRIPT_DIR/projectname")-lint" .
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user