sneak/go-ircevent
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix SASL where additional caps are requested

Browse Source 
Where additional caps were requested using `RequestCaps`, SASL would
send an `AUTHENTICATE` command for each one which servers don't like.
Check that we're responding to the correct `CAP ACK`.
This commit is contained in:
Russ Garrett 2019-02-21 12:20:50 +00:00
parent 14f3614f28
commit 9fa2a77567
No known key found for this signature in database
GPG Key ID: 68880BB652AB0570
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
irc_sasl.go
View File

@ -20,7 +20,7 @@ func (irc *Connection) setupSASLCallbacks(result chan<- *SASLResult) {
result <- &SASLResult{true, errors.New("no SASL capability " + e.Arguments[2])} result <- &SASLResult{true, errors.New("no SASL capability " + e.Arguments[2])}
} }
} }
if e.Arguments[1] == "ACK" { if e.Arguments[1] == "ACK" && e.Arguments[2] == "sasl" {
if irc.SASLMech != "PLAIN" { if irc.SASLMech != "PLAIN" {
result <- &SASLResult{true, errors.New("only PLAIN is supported")} result <- &SASLResult{true, errors.New("only PLAIN is supported")}
} }