sneak/go-ircevent
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Report on unterminated CTCP messages

Browse Source 
A bug was discovered where, under certain circumstances that are still
being researched, the library would panic on a message that started with
\0x01, but did not end with it. This would cause the re-slice to panic,
because the library assumes a terminating index >0, effectively
introducing the possibility of msg = msg[1:0]. Since this violates the
CTCP spec, it is an error, and should be logged, along with the
complete, escaped message.
This commit is contained in:
Andy Walker 2015-07-30 12:58:23 -04:00
parent 6112236593
commit 03b22b08f4
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
irc_callback.go
View File

@ -80,8 +80,10 @@ func (irc *Connection) RunCallbacks(event *Event) {
if event.Code == "PRIVMSG" && len(msg) > 2 && msg[0] == '\x01' { if event.Code == "PRIVMSG" && len(msg) > 2 && msg[0] == '\x01' {
event.Code = "CTCP" //Unknown CTCP event.Code = "CTCP" //Unknown CTCP
if i := strings.LastIndex(msg, "\x01"); i > -1 { if i := strings.LastIndex(msg, "\x01"); i > 0 {
msg = msg[1:i] msg = msg[1:i]
} else {
irc.Log.Printf("Invalid CTCP Message: %s\n", strconv.Quote(msg))
} }
if msg == "VERSION" { if msg == "VERSION" {