sneak
cc86473410
All checks were successful
check / check (push) Successful in 1m17s
golangci-lint is no longer installed or run on the host. script/lint is now a thin wrapper that builds the new root Dockerfile.lint, which COPYs the repo into the digest-pinned golangci/golangci-lint:v2.12.2 image and lints as a build step, so a successful build is a clean lint. This works even where the docker daemon is remote and bind mounts are impossible. Dockerfile.lint is split into a deps stage (base image, go mod download) and a lint stage (source copy, linter run). script/lint passes --no-cache-filter=lint so the lint stage executes on every invocation: caching is explicitly waived for linting, and a cached build lints nothing. The deps stage stays cached and no global cache invalidation is performed. --progress=plain keeps the linter's own output visible. golangci-lint config verify is deliberately omitted: it fetches its JSON schema over a live, unpinned HTTPS call, which would make linting network-dependent and defeat hash-pinning. script/bootstrap no longer installs golangci-lint and warns instead when docker is absent. The goimports install stays, since script/fmt and script/fmt-check still run it on the host. The root Dockerfile ran make check in its builder stage, which would now recurse into script/lint and shell out to docker build with no daemon available. It gains its own lint stage on the same pinned image, invoked directly, with the builder depending on it via COPY --from=lint and running make fmt-check, make test and make build.
29 lines
915 B
Bash
Executable File
29 lines
915 B
Bash
Executable File
#!/bin/sh
|
|
# script/lint: run the linter. golangci-lint is never installed or run
|
|
# on the host: it runs via docker only, one way, everywhere. This
|
|
# builds Dockerfile.lint, which COPYs the repo into the digest-pinned
|
|
# golangci-lint image and lints as a build step, so a successful build
|
|
# means a clean lint.
|
|
#
|
|
# --no-cache-filter=lint forces the lint stage (source copy + linter
|
|
# run) to execute on every invocation. Without it an unchanged tree
|
|
# returns success in well under a second having linted nothing. The
|
|
# deps stage (base image + go mod download) stays cached, and no global
|
|
# cache invalidation is performed. --progress=plain keeps the linter's
|
|
# own output visible.
|
|
set -eu
|
|
|
|
ROOT="$(cd "$(dirname "$0")/.." && pwd -P)"
|
|
|
|
main() {
|
|
cd "$ROOT"
|
|
docker build \
|
|
--progress=plain \
|
|
--no-cache-filter=lint \
|
|
--target lint \
|
|
-f Dockerfile.lint \
|
|
.
|
|
}
|
|
|
|
main "$@"
|