sneak/dnswatcher
1
0
Fork 0
Code Issues 3 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix: use context.Background() for watcher goroutine lifetime #63

Merged
sneak merged 2 commits from fix/issue-53-startup-context into main 2026-03-02 00:39:09 +01:00
Conversation 2 Commits 2 Files Changed 1 +7 -5
1 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
internal/watcher/watcher.go
View File

@@ -72,13 +72,15 @@ func New(
} }
lifecycle.Append(fx.Hook{ lifecycle.Append(fx.Hook{
OnStart: func(startCtx context.Context) error { OnStart: func(_ context.Context) error {
ctx, cancel := context.WithCancel( // Use context.Background() — the fx startup context
context.WithoutCancel(startCtx), // expires after startup completes, so deriving from it
) // would cancel the watcher immediately. The watcher's
// lifetime is controlled by w.cancel in OnStop.
ctx, cancel := context.WithCancel(context.Background())
w.cancel = cancel w.cancel = cancel
go w.Run(ctx) go w.Run(ctx) //nolint:contextcheck // intentionally not derived from startCtx
return nil return nil
}, },