A failed Mattermost delivery is logged as "slack notification failed" #227

Closed
opened 2026-10-02 07:35:33 +02:00 by clawbot · 1 comment
Collaborator

Found in the trial run for #149.

When the Mattermost endpoint answered with an HTTP error, the warning said "endpoint":"mattermost" but "error":"slack notification failed: status 503". Mattermost notifications are sent by the Slack sender, so the error names Slack; ErrMattermostFailed in internal/notify/notify.go is defined and never used. With both endpoints set, the error reads as a Slack failure.

To see it, point DNSWATCHER_MATTERMOST_WEBHOOK at a URL that answers 503 and read the retry warning. The Mattermost sender is set up in dispatchMattermost in internal/notify/notify.go.

Definition of done

  • A failed Mattermost delivery's error names Mattermost, and a failed Slack delivery's error names Slack.
  • A delivery test with a stand-in endpoint checks the Mattermost error.

Model: opus-5-5

Found in the trial run for https://git.eeqj.de/sneak/dnswatcher/issues/149. When the Mattermost endpoint answered with an HTTP error, the warning said `"endpoint":"mattermost"` but `"error":"slack notification failed: status 503"`. Mattermost notifications are sent by the Slack sender, so the error names Slack; `ErrMattermostFailed` in `internal/notify/notify.go` is defined and never used. With both endpoints set, the error reads as a Slack failure. To see it, point `DNSWATCHER_MATTERMOST_WEBHOOK` at a URL that answers 503 and read the retry warning. The Mattermost sender is set up in `dispatchMattermost` in `internal/notify/notify.go`. ## Definition of done - A failed Mattermost delivery's error names Mattermost, and a failed Slack delivery's error names Slack. - A delivery test with a stand-in endpoint checks the Mattermost error. Model: opus-5-5
clawbot added this to the 1.0 milestone 2026-10-02 07:35:33 +02:00
Author
Collaborator

Built in #240: the Slack sender now wraps an HTTP error in the error of the endpoint it is sending for, so a failed Mattermost delivery reads mattermost notification failed.

Model: opus-5-5

Built in https://git.eeqj.de/sneak/dnswatcher/pulls/240: the Slack sender now wraps an HTTP error in the error of the endpoint it is sending for, so a failed Mattermost delivery reads `mattermost notification failed`. Model: opus-5-5
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/dnswatcher#227