A check cut short by shutdown saves every port as closed and every certificate as failed #185

New Issue

2026-10-01T22:33:25+02:00

clawbot commented

2026-10-01 22:33:25 +02:00

When shutdown cancels a check that is under way, the rest of the check still runs, with the cancelled context. DNS lookups then fail and leave the saved state alone, because the resolver drops a query the context cut short. Port and TLS checks do not: a cancelled connection attempt is recorded as a closed port or a failed certificate check.

So a check on the DNS interval that is under way at shutdown saves every monitored port as closed and sends a Port Change notification for each one that was open. A check on the TLS interval saves every certificate as failed and sends TLS Failure. On the next start the real results come in and the watcher sends Port Change (now open) and TLS Recovery for all of them.

This could happen before, depending on timing. With the change for #114 the watcher's stop waits for the run loop to return, so the cut-short check always runs to its end, its notifications go out while the notifier still accepts them, and its results are saved.

Suggested fix: treat a port or TLS check the context cut short the way the resolver treats a cut-short query, and record and notify nothing for it.

Model: opus-5-5

When shutdown cancels a check that is under way, the rest of the check still runs, with the cancelled context. DNS lookups then fail and leave the saved state alone, because the resolver drops a query the context cut short. Port and TLS checks do not: a cancelled connection attempt is recorded as a closed port or a failed certificate check. So a check on the DNS interval that is under way at shutdown saves every monitored port as closed and sends a `Port Change` notification for each one that was open. A check on the TLS interval saves every certificate as failed and sends `TLS Failure`. On the next start the real results come in and the watcher sends `Port Change` (now open) and `TLS Recovery` for all of them. This could happen before, depending on timing. With the change for https://git.eeqj.de/sneak/dnswatcher/issues/114 the watcher's stop waits for the run loop to return, so the cut-short check always runs to its end, its notifications go out while the notifier still accepts them, and its results are saved. Suggested fix: treat a port or TLS check the context cut short the way the resolver treats a cut-short query, and record and notify nothing for it. Model: opus-5-5

~~clawbot referenced this issue 2026-10-01 22:33:33 +02:00~~

watcher: save state when it stops and wait for that save (closes #114) #186

clawbot referenced this issue

2026-10-01 22:33:50 +02:00

Final state persistence at shutdown depends on implicit fx hook ordering and is untested #114

clawbot added this to the 1.0 milestone 2026-10-01 22:34:34 +02:00

clawbot commented

2026-10-01 22:34:34 +02:00

Plan. It lands before #186 (#114), which makes this happen whenever shutdown falls during a check.

Definition of done:

A port or TLS check that the context cut short records nothing and notifies nothing, the way the resolver already drops a query the context cut short. A check that ran to completion is handled as today.
Tests: a port check and a TLS check run with a context cancelled during the check leave the saved port and certificate state as it was and send no notification; each test fails with the fix removed. The connections go to local listeners started in the test; nothing involving DNS is stood in for.
README, if it describes shutdown behaviour, says so.

Model: opus-5-5

Plan. It lands before https://git.eeqj.de/sneak/dnswatcher/pulls/186 (https://git.eeqj.de/sneak/dnswatcher/issues/114), which makes this happen whenever shutdown falls during a check. Definition of done: - A port or TLS check that the context cut short records nothing and notifies nothing, the way the resolver already drops a query the context cut short. A check that ran to completion is handled as today. - Tests: a port check and a TLS check run with a context cancelled during the check leave the saved port and certificate state as it was and send no notification; each test fails with the fix removed. The connections go to local listeners started in the test; nothing involving DNS is stood in for. - README, if it describes shutdown behaviour, says so. Model: opus-5-5

clawbot referenced this issue from a commit

2026-10-01 22:43:06 +02:00

watcher: save and notify nothing for a cut-short port or TLS check (closes #185)

clawbot referenced a pull request that will close this issue

2026-10-01 22:43:25 +02:00

watcher: save and notify nothing for a cut-short port or TLS check (closes #185) #188

clawbot commented

2026-10-01 22:43:41 +02:00

Fixed in #188: a port or TLS check whose context was cancelled is now dropped by the watcher, the way the resolver drops a cut-short lookup. The test cancels the context before the check rather than during a connection; the PR says why.

Model: opus-5-5

Fixed in https://git.eeqj.de/sneak/dnswatcher/pulls/188: a port or TLS check whose context was cancelled is now dropped by the watcher, the way the resolver drops a cut-short lookup. The test cancels the context before the check rather than during a connection; the PR says why. Model: opus-5-5

clawbot closed this issue

2026-10-01 22:49:45 +02:00

clawbot referenced this issue from a commit

2026-10-01 22:49:46 +02:00

watcher: save and notify nothing for a cut-short port or TLS check (closes #185)

clawbot referenced this issue

2026-10-01 23:11:33 +02:00

watcher: save state when it stops and wait for that save (closes #114) #186

Sign in to join this conversation.