resolver: never resend a refused query asking for recursion (closes #206 )

queryDNS resent a query that a server refused, this time asking for recursion, so on a network that intercepts DNS the answers could come from a recursive resolver without anyone knowing. A refusal is now only a refusal, and the server is passed over for the next. When every server of a zone refuses, the error says so. When every root server refuses, the error is ErrIntercepted: root servers refuse no query, so something on the network is answering in their place. FindAuthoritativeNameservers stops at that error instead of trying each parent name, so the watcher's log line says it. A live test asks Quad9, which refuses a query not asking for recursion, so that the resend cannot come back unnoticed. Model: opus-5-5
2026-10-02 01:42:33 +00:00
1 changed files with 0 additions and 41 deletions
@@ -444,47 +444,6 @@ func TestQueryServers_EveryRootServerRefused(t *testing.T) {
 	)
 }
 // TestQueryServers_NotEveryRootServerRefused passes google.com's
 // nameservers and 192.0.2.1 to QueryServers as the servers of the root
 // zone. The google.com nameservers refuse a query about cloudflare.com,
 // but nothing answers at 192.0.2.1, a documentation address, so not
 // every server refused, wherever 192.0.2.1 falls in the random order:
 // the error is not ErrIntercepted and does not say every server refused.
 func TestQueryServers_NotEveryRootServerRefused(t *testing.T) {
 	t.Parallel()
 	r := newTestResolver(t)
 	servers := googleNameserverIPv4s(t, r)
 	servers = append(servers, "192.0.2.1")
 	var err error
 	livednstest.Retry(
 		t,
 		"QueryServers(google.com servers and 192.0.2.1, cloudflare.com)",
 		func(ctx context.Context) error {
 			_, err = r.QueryServers(
 				ctx, servers, ".", "cloudflare.com.", dns.TypeNS,
 			)
 			// An attempt that ran out of time may not have asked every
 			// server, so it is tried again.
 			if ctx.Err() != nil {
 				return fmt.Errorf(
 					"%w: %w", livednstest.ErrNoAnswer, err,
 				)
 			}
 			return nil
 		},
 	)
 	require.Error(t, err)
 	require.NotErrorIs(t, err, resolver.ErrIntercepted)
 	// Both errors for every server refusing say "refused a query for".
 	require.NotContains(t, err.Error(), "refused a query for")
 }
 func TestQueryNameserver_RecordsSorted(t *testing.T) {
 	t.Parallel()