README: correct claims the code does not bear out (closes #108)

Checked every README claim against the code on next and fixed the ones
that were wrong or missing: what /metrics serves and when, what
DNSWATCHER_MAINTENANCE_MODE does, CORS on the public routes,
notification retries and the in-memory alert history, the certificate
error field and old port entries in the state file, and the Design
tree's missing files. Also corrected: CNAMEs are not followed for
watched names, the root server list is never refreshed, the NS set is
the zone's own answer, notification contents, and the system resolver
being used for webhooks. Code problems found are filed separately.

Model: opus-5-5

README.md

@@ -72,8 +72,9 @@ notification endpoint set, changes show only on the dashboard; see
 - Every **1 hour** by default, performs a full iterative trace from root servers
   to discover all authoritative nameservers (NS records) for each domain.
 - Queries **every** discovered authoritative nameserver independently.
-- Stores the domain's NS record set, as its parent zone's servers delegate it,
-  and the IPv4 and IPv6 addresses each nameserver's name resolves to.
+- Stores the domain's NS record set, as the first of its own nameservers to
+  answer returns it, and the IPv4 and IPv6 addresses each nameserver's name
+  resolves to.
 - Any change triggers a notification:
     - NS added to or removed from that set.
     - NS address change: a nameserver that stays in the set resolves to
@@ -401,8 +402,8 @@ it watches. Instead, it performs full iterative resolution:
    built into the binary; the list is not refreshed.
 2. **TLD delegation**: Queries root servers for the TLD NS records.
 3. **Domain delegation**: Queries TLD nameservers for the domain's NS records.
-   The delegation they give, from the domain's parent zone, is the domain's NS
-   record set.
+   They refer it to the domain's own nameservers, and the first of those to
+   answer gives the domain's NS record set.
 4. **Authoritative query**: Queries all discovered authoritative nameservers
    directly for the requested records.
 

TODO.md

@@ -21,10 +21,6 @@ trial run of the finished image: https://git.eeqj.de/sneak/dnswatcher/issues/149
 
 - 2026-10-01: README checked against the code and corrected: metrics, CORS,
   notification retries, CNAMEs, state file fields, Design tree (closes #108).
-- 2026-10-01: a certificate within the expiry warning period is warned about on
-  every TLS check, where some checks used to skip it at random (closes #204).
-- 2026-10-01: a domain's NS set is its delegation from the parent zone's
-  servers, not whichever of its own servers answered first (closes #200).
 - 2026-10-01: README has Getting Started, Rationale and TODO sections, and its
   Architecture section is now Design, in the order policy sets (closes #173).
 - 2026-10-01: a zone's server that answers SERVFAIL or a referral leading no

internal/resolver/export_test.go

@@ -16,11 +16,6 @@ func UsableReply(resp *dns.Msg, zone string, name string) bool {
 	return usableReply(resp, zone, name)
 }
 
-// NSSetFrom exports nsSetFrom for testing.
-func NSSetFrom(resp *dns.Msg, domain string) []string {
-	return nsSetFrom(resp, domain)
-}
-
 // CollectIPs exports collectIPs for testing.
 func CollectIPs(
 	results map[string]*NameserverResponse,

internal/resolver/iterative.go

@@ -222,9 +222,9 @@ func (r *Resolver) followDelegation(
 			return nil, err
 		}
 
-		nsSet := nsSetFrom(resp, domain)
-		if len(nsSet) > 0 {
-			return nsSet, nil
+		ansNS := extractNSSet(resp.Answer)
+		if len(ansNS) > 0 {
+			return ansNS, nil
 		}
 
 		// An authoritative reply comes from the servers of the zone
@@ -325,21 +325,6 @@ func referralZone(resp *dns.Msg) string {
 	return ""
 }
 
-// nsSetFrom returns the NS set of domain that resp, a reply to a query
-// for domain's NS records, gives: the delegation in a referral to domain
-// itself, or else the NS records in the answer; empty when it gives
-// neither. A referral to domain comes from its parent zone's servers,
-// which all hold the same delegation, so the set does not depend on
-// which of them answered. domain's own servers, which can disagree about
-// their NS records, are then not asked.
-func nsSetFrom(resp *dns.Msg, domain string) []string {
-	if referralZone(resp) == domain {
-		return extractNSSet(resp.Ns)
-	}
-
-	return extractNSSet(resp.Answer)
-}
-
 func (r *Resolver) resolveNSIPs(
 	ctx context.Context,
 	nsNames []string,
@@ -387,7 +372,7 @@ func (r *Resolver) resolveNSIterative(
 			return nil, err
 		}
 
-		nsNames := nsSetFrom(resp, domain)
+		nsNames := extractNSSet(resp.Answer)
 		if len(nsNames) > 0 {
 			return nsNames, nil
 		}
@@ -480,8 +465,7 @@ func (r *Resolver) resolveARecord(
 
 // FindAuthoritativeNameservers traces the delegation chain from
 // root servers to discover all authoritative nameservers for the
-// given domain, as the delegation from its parent zone's servers lists
-// them. For a name that is not a zone apex it tries each
+// given domain. For a name that is not a zone apex it tries each
 // parent name in turn, so it returns the nameservers of the zone the
 // name is in.
 func (r *Resolver) FindAuthoritativeNameservers(
@@ -647,10 +631,9 @@ func (r *Resolver) querySingleType(
 
 	// A reply with no answer that lists other nameservers, from a server
 	// that does not hold the name's zone, is a referral and says nothing
-	// about the name's records. A server named in the delegation that
-	// does not hold the zone may send one, as do a parent zone's servers
-	// when FindAuthoritativeNameservers found no delegation for the
-	// name's zone and moved on to a parent name.
+	// about the name's records. A parent zone's servers send one when
+	// every server of the name's own zone failed and
+	// FindAuthoritativeNameservers moved on to the parent name.
 	if !msg.Authoritative && len(msg.Answer) == 0 &&
 		len(extractNSSet(msg.Ns)) > 0 {
 		state.gotReferral = true

internal/resolver/iterative_test.go

@@ -41,15 +41,8 @@ func TestCollectIPs_FailedIsNoAnswer(t *testing.T) {
 	assert.Empty(t, ips)
 }
 
-const (
-	// exampleCom is the zone most cases of TestUsableReply and
-	// TestNSSetFrom are about, and wwwExampleCom a name in it.
-	exampleCom    = "example.com."
-	wwwExampleCom = "www.example.com."
-
-	// exampleNS is the server the NS records nsRecord builds name.
-	exampleNS = "ns1.example.net."
-)
+// exampleCom is the zone most cases of TestUsableReply are about.
+const exampleCom = "example.com."
 
 // nsRecord builds an NS record that names a server of zone.
 func nsRecord(zone string) *dns.NS {
@@ -57,7 +50,7 @@ func nsRecord(zone string) *dns.NS {
 		Hdr: dns.RR_Header{
 			Name: zone, Rrtype: dns.TypeNS, Class: dns.ClassINET,
 		},
-		Ns: exampleNS,
+		Ns: "ns1.example.net.",
 	}
 }
 
@@ -112,7 +105,7 @@ func TestUsableReply(t *testing.T) {
 		},
 		{
 			name: "com refers to example.com", resp: referralTo(exampleCom),
-			zone: "com.", query: wwwExampleCom, want: true,
+			zone: "com.", query: "www.example.com.", want: true,
 		},
 		{
 			name: "referral back to the zone", resp: referralTo(exampleCom),
@@ -139,51 +132,6 @@ func TestUsableReply(t *testing.T) {
 	}
 }
 
-// TestNSSetFrom checks which NS set a reply gives for a domain; a set
-// that is not empty ends the walk. The referral to example.com that
-// com's servers all send alike gives its delegation, so the set is the
-// same whichever of them answered, and example.com's own servers, which
-// can disagree, are not asked.
-func TestNSSetFrom(t *testing.T) {
-	t.Parallel()
-
-	answer := new(dns.Msg)
-	answer.Authoritative = true
-	answer.Answer = []dns.RR{nsRecord(exampleCom)}
-
-	tests := []struct {
-		name   string
-		resp   *dns.Msg
-		domain string
-		want   []string
-	}{
-		{
-			name: "com refers to example.com", resp: referralTo(exampleCom),
-			domain: exampleCom, want: []string{exampleNS},
-		},
-		{
-			name: "com refers on, for www.example.com",
-			resp: referralTo(exampleCom), domain: wwwExampleCom,
-			want: nil,
-		},
-		{
-			name: "answer from a server that holds example.com",
-			resp: answer, domain: exampleCom,
-			want: []string{exampleNS},
-		},
-	}
-
-	for _, tt := range tests {
-		t.Run(tt.name, func(t *testing.T) {
-			t.Parallel()
-
-			assert.ElementsMatch(t, tt.want,
-				resolver.NSSetFrom(tt.resp, tt.domain),
-			)
-		})
-	}
-}
-
 func TestExtractRecordValue_LetterCase(t *testing.T) {
 	t.Parallel()
 

internal/watcher/export_test.go

@@ -28,6 +28,7 @@ func NewForTest(
 		tlsCheck:       tc,
 		notify:         n,
 		firstRun:       true,
+		expiryNotified: make(map[string]time.Time),
 	}
 }
 
@@ -71,11 +72,6 @@ func (w *Watcher) CheckAllPorts(ctx context.Context) {
 	w.checkAllPorts(ctx)
 }
 
-// RunTLSChecks exports runTLSChecks for testing.
-func (w *Watcher) RunTLSChecks(ctx context.Context) {
-	w.runTLSChecks(ctx)
-}
-
 // BuildHostnameState exports buildHostnameState for testing.
 func BuildHostnameState(
 	results map[string]*resolver.NameserverResponse,

internal/watcher/watcher.go

@@ -7,6 +7,7 @@ import (
 	"slices"
 	"sort"
 	"strings"
+	"sync"
 	"time"
 
 	"go.uber.org/fx"
@@ -58,6 +59,8 @@ type Watcher struct {
 	cancel           context.CancelFunc
 	done             chan struct{} // closed when Run returns
 	firstRun         bool
+	expiryNotifiedMu sync.Mutex
+	expiryNotified   map[string]time.Time
 }
 
 // New creates a new Watcher instance wired into the fx lifecycle.
@@ -74,6 +77,7 @@ func New(
 		tlsCheck:       params.TLSCheck,
 		notify:         params.Notify,
 		firstRun:       true,
+		expiryNotified: make(map[string]time.Time),
 	}
 
 	lifecycle.Append(fx.Hook{
@@ -1024,6 +1028,22 @@ func (w *Watcher) checkTLSExpiry(
 		return
 	}
 
+	// Deduplicate expiry warnings: don't re-notify for the same
+	// hostname within the TLS check interval.
+	dedupKey := fmt.Sprintf("expiry:%s:%s", hostname, ip)
+
+	w.expiryNotifiedMu.Lock()
+
+	lastNotified, seen := w.expiryNotified[dedupKey]
+	if seen && time.Since(lastNotified) < w.config.TLSInterval {
+		w.expiryNotifiedMu.Unlock()
+
+		return
+	}
+
+	w.expiryNotified[dedupKey] = time.Now()
+	w.expiryNotifiedMu.Unlock()
+
 	msg := fmt.Sprintf(
 		"Host: %s\nIP: %s\nCN: %s\n"+
 			"Expires: %s (%.0f days)",

internal/watcher/watcher_test.go

@@ -615,55 +615,34 @@ func TestTLSExpiryWarning(t *testing.T) {
 	assertNotified(t, deps, "TLS Expiry Warning: "+testHost, "warning")
 }
 
-// TestTLSExpiryWarningEachCheck runs the TLS checks three times in a
-// row on hostname and port state built here, for a certificate that
-// expires within the warning period. Each check warns once, whether the
-// TLS interval is a nanosecond, shorter than the time between two
-// checks, or a day, longer than it.
-func TestTLSExpiryWarningEachCheck(t *testing.T) {
-	t.Parallel()
-
-	title := "TLS Expiry Warning: " + host
-
-	for _, interval := range []time.Duration{time.Nanosecond, 24 * time.Hour} {
-		t.Run(interval.String(), func(t *testing.T) {
+func TestTLSExpiryWarningDedup(t *testing.T) {
 	t.Parallel()
 
 	cfg := defaultTestConfig(t)
-			cfg.Hostnames = []string{host}
-			cfg.TLSInterval = interval
+	cfg.Hostnames = []string{testHost}
+	cfg.TLSInterval = 24 * time.Hour
 
-			// The TLS checks read the saved hostname and port state and
-			// look nothing up, so the watcher has no resolver.
-			deps := newTestDeps(t, cfg)
-			w := watcher.NewForTest(
-				cfg, deps.state, nil,
-				deps.portChecker, deps.tlsChecker, deps.notifier,
-			)
+	title := "TLS Expiry Warning: " + testHost
 
-			expiresInThreeDays(deps)
-			deps.state.SetHostnameState(host, saved(
-				map[string]*state.NameserverRecordState{
-					nsA: answered(map[string][]string{"A": {ip1}}),
-				},
-			))
-			deps.state.SetPortState(ip1+":443", &state.PortState{
-				Open: true, Hostnames: []string{host},
+	// The second check comes within the TLS interval of the first,
+	// so it must not warn again.
+	var warnings int
+
+	deps := runChecks(t, cfg, expiresInThreeDays, func(deps *testDeps) {
+		warnings = countNotifications(deps, title)
 	})
 
-			for check := 1; check <= 3; check++ {
-				w.RunTLSChecks(t.Context())
+	if warnings == 0 {
+		t.Fatal("expected expiry warnings from the first check")
+	}
 
 	got := countNotifications(deps, title)
-				if got != check {
-					t.Fatalf(
-						"after check %d: %d expiry warnings, want %d",
-						check, got, check,
+	if got != warnings {
+		t.Errorf(
+			"expected %d expiry warnings (dedup), got %d",
+			warnings, got,
 		)
 	}
-			}
-		})
-	}
 }
 
 func TestGracefulShutdown(t *testing.T) {