build: isolate golangci-lint cache and lock per checkout (closes #121)
All checks were successful
check / check (push) Successful in 54s
All checks were successful
check / check (push) Successful in 54s
script/lint used golangci-lint's per-user global state, which breaks when several checkouts on one host lint concurrently. Two independent failure modes, two causes: - Cross-contamination. The analysis cache (GOLANGCI_LINT_CACHE, default ~/.cache/golangci-lint) is keyed by content, not by checkout, so a hit written by another checkout is replayed with that checkout's file paths. A run reports findings for files it never linted. - Lock collision. golangci-lint locks os.TempDir()/golangci-lint.lock (pkg/commands/run.go, acquireFileLock), which is NOT in the cache directory, with a 5s timeout. Peers that hold it longer make the run abort with "parallel golangci-lint is running" - a non-result that reads as a lint failure. Isolating the cache does not move it. Point GOLANGCI_LINT_CACHE and TMPDIR at .lint-cache/ under the checkout root, using the existing $ROOT idiom. TMPDIR is what makes the lock per-checkout, so the lock keeps serialising the runs that actually share a cache instead of being disabled. .lint-cache/ is git-ignored and Docker-ignored, and the cache persists across runs in a checkout, so caching is not lost. Reproduced both modes on the unfixed script across 12 copies of this tree: 10 of 12 concurrent runs void with the lock error, and 11 of 12 sequential runs reported findings at ../w1/... after an identical lint-failing file was added to every copy. After the fix, 20-way concurrency gives 0 void and 0 foreign paths, and each copy reports only its own relative path.
This commit is contained in:
9
TODO.md
9
TODO.md
@@ -25,6 +25,15 @@ confirm make check still passes.
|
||||
|
||||
# Completed Steps
|
||||
|
||||
- 2026-08-09: `script/lint` now isolates golangci-lint's per-user global
|
||||
state to the checkout (#121): `GOLANGCI_LINT_CACHE` and `TMPDIR` are
|
||||
both pointed at the git-ignored, Docker-ignored `.lint-cache/`. The
|
||||
cache fixes cross-contamination; `TMPDIR` is what moves the lock,
|
||||
which lives at `$TMPDIR/golangci-lint.lock` and not in the cache
|
||||
directory. Reproduced both failure modes on the unfixed script (10 of
|
||||
12 concurrent runs void with `parallel golangci-lint is running`; 11
|
||||
of 12 reporting another checkout's paths) and both are gone at 20-way
|
||||
concurrency after the fix
|
||||
- 2026-08-07: golangci-lint bumped to v2.12.2 (commit-pinned installs
|
||||
in `Dockerfile` and `script/bootstrap`); `.golangci.yml` set to the
|
||||
org-standard v2-schema config used across the org's repos
|
||||
|
||||
Reference in New Issue
Block a user