Fix code review feedback from PR #4 #5

New Issue

clawbot · 2026-02-10T06:15:55+01:00

clawbot commented

2026-02-10 06:15:55 +01:00

Address all code review items from PR #4:

Duplicated find-by-ID queries — extract shared lookup methods
Relation methods return nil on empty — return [] not null
No timestamps on Create methods — populate CreatedAt/UpdatedAt
No transactions in migration runner — wrap in tx
QueueMessage ignores LastInsertId error — check the error
No dequeue/ack for message queue — add DequeueMessages/AckMessages
Missing lookup methods — add GetUserByNick, GetUserByToken, DeleteAuthToken, UpdateUserLastSeen
SQLite foreign keys not enabled — PRAGMA foreign_keys = ON
General cleanup — builds clean, tests pass

Address all code review items from PR #4: 1. **Duplicated find-by-ID queries** — extract shared lookup methods 2. **Relation methods return nil on empty** — return `[]` not `null` 3. **No timestamps on Create methods** — populate CreatedAt/UpdatedAt 4. **No transactions in migration runner** — wrap in tx 5. **QueueMessage ignores LastInsertId error** — check the error 6. **No dequeue/ack for message queue** — add DequeueMessages/AckMessages 8. **Missing lookup methods** — add GetUserByNick, GetUserByToken, DeleteAuthToken, UpdateUserLastSeen 9. **SQLite foreign keys not enabled** — PRAGMA foreign_keys = ON 10. **General cleanup** — builds clean, tests pass

clawbot referenced a pull request that will close this issue

2026-02-10 06:16:11 +01:00

Fix code review feedback (closes #5) #6

clawbot closed this issue

2026-02-10 18:18:06 +01:00

clawbot referenced this issue from a commit

2026-02-10 18:18:07 +01:00

Merge pull request 'Fix code review feedback (closes #5)' (#6) from fix/review-feedback into feature/database-schema

Sign in to join this conversation.