sneak/chat
1
0
Fork 0
Code Issues 5 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

Fix code review feedback from PR #4 #5

New Issue
Closed
opened 2026-02-10 06:15:55 +01:00 by clawbot · 0 comments
clawbot commented 2026-02-10 06:15:55 +01:00
Collaborator
Copy Link

Address all code review items from PR #4:

  1. Duplicated find-by-ID queries — extract shared lookup methods
  2. Relation methods return nil on empty — return [] not null
  3. No timestamps on Create methods — populate CreatedAt/UpdatedAt
  4. No transactions in migration runner — wrap in tx
  5. QueueMessage ignores LastInsertId error — check the error
  6. No dequeue/ack for message queue — add DequeueMessages/AckMessages
  7. Missing lookup methods — add GetUserByNick, GetUserByToken, DeleteAuthToken, UpdateUserLastSeen
  8. SQLite foreign keys not enabled — PRAGMA foreign_keys = ON
  9. General cleanup — builds clean, tests pass
Address all code review items from PR #4: 1. **Duplicated find-by-ID queries** — extract shared lookup methods 2. **Relation methods return nil on empty** — return `[]` not `null` 3. **No timestamps on Create methods** — populate CreatedAt/UpdatedAt 4. **No transactions in migration runner** — wrap in tx 5. **QueueMessage ignores LastInsertId error** — check the error 6. **No dequeue/ack for message queue** — add DequeueMessages/AckMessages 8. **Missing lookup methods** — add GetUserByNick, GetUserByToken, DeleteAuthToken, UpdateUserLastSeen 9. **SQLite foreign keys not enabled** — PRAGMA foreign_keys = ON 10. **General cleanup** — builds clean, tests pass
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
merge-ready
All checks pass, reviewed, rebased, ready for merge
 needs-checks
make check does not pass cleanly
 needs-rebase
PR has merge conflicts or is behind main
 needs-review
Code review not yet done
 needs-review
needs-rework
Code review found issues to fix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
clawbot sneak
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/chat#5
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?