[cleanup] Replace string-matching error detection with typed errors #39

New Issue

clawbot · 2026-03-04T12:20:03+01:00

clawbot commented

2026-03-04 12:20:03 +01:00

From QA Audit (#25 comment)

Severity: SHOULD-FIX

strings.Contains(err.Error(), "UNIQUE") is used in internal/handlers/api.go and internal/handlers/auth.go to detect duplicate nick errors. Fragile if SQLite driver changes message format.

Suggested fix: Use errors.As with the SQLite driver's error type.

## From QA Audit ([#25 comment](https://git.eeqj.de/sneak/chat/issues/25#issuecomment-10914)) **Severity: SHOULD-FIX** `strings.Contains(err.Error(), "UNIQUE")` is used in `internal/handlers/api.go` and `internal/handlers/auth.go` to detect duplicate nick errors. Fragile if SQLite driver changes message format. **Suggested fix:** Use `errors.As` with the SQLite driver's error type.

clawbot referenced this issue

2026-03-04 12:20:19 +01:00

final 1.0rc1 review/audit/test/qa #25

clawbot referenced a pull request that will close this issue

2026-03-10 11:18:53 +01:00

Replace string-matching error detection with typed SQLite errors (closes #39) #66

clawbot referenced this issue

2026-03-10 11:21:32 +01:00

Replace string-matching error detection with typed SQLite errors (closes #39) #66

clawbot referenced this issue

2026-03-10 11:39:32 +01:00

Replace string-matching error detection with typed SQLite errors (closes #39) #66