sneak/chat
1
0
Fork 0
Code Issues 5 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

[security] handleTopic: enforce channel membership check #33

New Issue
Closed
opened 2026-03-04 12:19:59 +01:00 by clawbot · 0 comments
clawbot commented 2026-03-04 12:19:59 +01:00
Collaborator
Copy Link

From QA Audit (#25 comment)

Severity: BLOCKER

handleTopic in internal/handlers/api.go does NOT check that the user is a member of the channel before allowing them to set a topic. Any authenticated user can set the topic on any channel they haven't joined.

Suggested fix: Add an IsChannelMember check before SetTopic, similar to handleChannelMsg.

## From QA Audit ([#25 comment](https://git.eeqj.de/sneak/chat/issues/25#issuecomment-10914)) **Severity: BLOCKER** `handleTopic` in `internal/handlers/api.go` does NOT check that the user is a member of the channel before allowing them to set a topic. Any authenticated user can set the topic on any channel they haven't joined. **Suggested fix:** Add an `IsChannelMember` check before `SetTopic`, similar to `handleChannelMsg`.
clawbot self-assigned this 2026-03-15 22:09:37 +01:00
sneak closed this issue 2026-03-17 12:47:00 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
merge-ready
All checks pass, reviewed, rebased, ready for merge
 needs-checks
make check does not pass cleanly
 needs-rebase
PR has merge conflicts or is behind main
 needs-review
Code review not yet done
 needs-review
needs-rework
Code review found issues to fix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
clawbot sneak
No Assignees clawbot
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/chat#33
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?