22 Commits

Author SHA1 Message Date
user
0b132cfbf4 fix: replace conflicting migration 003 with no-op
Migration 003 tried to recreate tables (users, channel_members, messages)
with INTEGER IDs, conflicting with 002_schema.sql which already defines
them with TEXT UUIDs. This caused all tests to fail.
2026-02-20 03:31:02 -08:00
user
a9586eb95f fix: resolve funcorder and noinlineerr issues 2026-02-20 03:30:01 -08:00
user
2f6d1f284c fix: resolve cyclop, funlen issues by extracting helper methods 2026-02-20 03:29:18 -08:00
user
037202280b fix: resolve nestif issues by extracting helper methods 2026-02-20 03:26:46 -08:00
user
e0da78f17c fix: resolve wsl_v5, lll, noinlineerr, and gosec lint issues 2026-02-20 03:26:06 -08:00
user
db3b0bfee1 fix: resolve ireturn lint issues 2026-02-20 03:22:32 -08:00
user
a3c26c415e fix: resolve funcorder lint issues 2026-02-20 03:22:03 -08:00
user
2c89b23bea fix: resolve forcetypeassert lint issues 2026-02-20 03:21:14 -08:00
user
0be5e80b85 fix: resolve rowserrcheck lint issues 2026-02-20 03:21:02 -08:00
user
f6ca154315 fix: resolve mnd lint issues with named constants 2026-02-20 03:20:26 -08:00
user
c6c5aaf48e fix: resolve noctx lint issues 2026-02-20 03:19:19 -08:00
user
4fe5227cbf fix: resolve err113 lint issues with sentinel errors 2026-02-20 03:18:56 -08:00
user
dd5e9e61ab fix: resolve errcheck lint issues 2026-02-20 03:17:50 -08:00
user
3d968a1102 fix: resolve noinlineerr lint issues 2026-02-20 03:17:09 -08:00
user
f125a3f591 fix: resolve revive lint issues 2026-02-20 03:16:09 -08:00
user
5fad27ff4c fix: resolve lll lint issues 2026-02-20 03:15:37 -08:00
user
6ca3ad0e99 fix: resolve tagliatelle lint issues 2026-02-20 03:15:25 -08:00
user
d8c63640f5 fix: resolve wastedassign and gosmopolitan lint issues 2026-02-20 03:15:10 -08:00
user
3adc5479b7 fix: resolve wsl_v5 lint issues 2026-02-20 03:14:46 -08:00
clawbot
ed96c6ccde fix: format cmd/chat-cli/api/client.go with gofmt 2026-02-20 03:02:32 -08:00
clawbot
c1040ff69d fix: resolve nlreturn, modernize, perfsprint, wsl_v5, and partial err113 lint issues 2026-02-20 02:59:15 -08:00
clawbot
c65c9bbe5a fix: resolve typecheck errors by removing duplicate db methods and updating handlers to use models-based API 2026-02-20 02:57:16 -08:00
20 changed files with 987 additions and 2084 deletions

View File

@@ -1,9 +1,8 @@
.git
node_modules
.DS_Store
bin/ bin/
chatd
data.db data.db
.env .env
.git
*.test *.test
*.out *.out
debug.log debug.log

View File

@@ -1,12 +0,0 @@
root = true
[*]
indent_style = space
indent_size = 4
end_of_line = lf
charset = utf-8
trim_trailing_whitespace = true
insert_final_newline = true
[Makefile]
indent_style = tab

View File

@@ -1,9 +0,0 @@
name: check
on: [push]
jobs:
check:
runs-on: ubuntu-latest
steps:
# actions/checkout v4.2.2, 2026-02-22
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
- run: docker build .

30
.gitignore vendored
View File

@@ -1,28 +1,7 @@
# OS
.DS_Store
Thumbs.db
# Editors
*.swp
*.swo
*~
*.bak
.idea/
.vscode/
*.sublime-*
# Node
node_modules/
# Environment / secrets
.env
.env.*
*.pem
*.key
# Build artifacts
/chatd /chatd
/bin/ /bin/
data.db
.env
*.exe *.exe
*.dll *.dll
*.so *.so
@@ -30,9 +9,6 @@ node_modules/
*.test *.test
*.out *.out
vendor/ vendor/
# Project
data.db
debug.log debug.log
/chat-cli
web/node_modules/ web/node_modules/
chat-cli

View File

@@ -1,7 +1,6 @@
# golang:1.24-alpine, 2026-02-26 FROM golang:1.24-alpine AS builder
FROM golang@sha256:8bee1901f1e530bfb4a7850aa7a479d17ae3a18beb6e09064ed54cfd245b7191 AS builder
RUN apk add --no-cache git build-base RUN apk add --no-cache git
WORKDIR /src WORKDIR /src
COPY go.mod go.sum ./ COPY go.mod go.sum ./
@@ -9,15 +8,10 @@ RUN go mod download
COPY . . COPY . .
# Run all checks — build fails if branch is not green
RUN go install github.com/golangci/golangci-lint/cmd/golangci-lint@v2.1.6
RUN make check
ARG VERSION=dev ARG VERSION=dev
RUN go build -ldflags "-X main.Version=${VERSION}" -o /chatd ./cmd/chatd RUN go build -ldflags "-X main.Version=${VERSION}" -o /chatd ./cmd/chatd
# alpine:3.21, 2026-02-26 FROM alpine:3.21
FROM alpine@sha256:c3f8e73fdb79deaebaa2037150150191b9dcbfba68b4a46d70103204c53f4709
RUN apk add --no-cache ca-certificates RUN apk add --no-cache ca-certificates
COPY --from=builder /chatd /usr/local/bin/chatd COPY --from=builder /chatd /usr/local/bin/chatd

21
LICENSE
View File

@@ -1,21 +0,0 @@
MIT License
Copyright (c) 2025 sneak
Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:
The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.

View File

@@ -1,4 +1,4 @@
.PHONY: all build lint fmt fmt-check test check clean run debug docker hooks .PHONY: all build lint fmt test check clean run debug
BINARY := chatd BINARY := chatd
VERSION := $(shell git describe --tags --always --dirty 2>/dev/null || echo "dev") VERSION := $(shell git describe --tags --always --dirty 2>/dev/null || echo "dev")
@@ -17,15 +17,18 @@ fmt:
gofmt -s -w . gofmt -s -w .
goimports -w . goimports -w .
fmt-check:
@test -z "$$(gofmt -l .)" || (echo "Files not formatted:" && gofmt -l . && exit 1)
test: test:
go test -timeout 30s -v -race -cover ./... go test -v -race -cover ./...
# check runs all validation without making changes # Check runs all validation without making changes
# Used by CI and Docker build — fails if anything is wrong # Used by CI and Docker build — fails if anything is wrong
check: test lint fmt-check check:
@echo "==> Checking formatting..."
@test -z "$$(gofmt -l .)" || (echo "Files not formatted:" && gofmt -l . && exit 1)
@echo "==> Running linter..."
golangci-lint run --config .golangci.yml ./...
@echo "==> Running tests..."
go test -v -race ./...
@echo "==> Building..." @echo "==> Building..."
go build -ldflags "$(LDFLAGS)" -o /dev/null ./cmd/chatd go build -ldflags "$(LDFLAGS)" -o /dev/null ./cmd/chatd
@echo "==> All checks passed!" @echo "==> All checks passed!"
@@ -38,12 +41,3 @@ debug: build
clean: clean:
rm -rf bin/ chatd data.db rm -rf bin/ chatd data.db
docker:
docker build -t chat .
hooks:
@printf '#!/bin/sh\nset -e\n' > .git/hooks/pre-commit
@printf 'go mod tidy\ngo fmt ./...\ngit diff --exit-code -- go.mod go.sum || { echo "go mod tidy changed files; please stage and retry"; exit 1; }\n' >> .git/hooks/pre-commit
@printf 'make check\n' >> .git/hooks/pre-commit
@chmod +x .git/hooks/pre-commit

View File

@@ -656,8 +656,3 @@ embedded web client.
## License ## License
MIT MIT
## Author
[@sneak](https://sneak.berlin)

View File

@@ -1,182 +0,0 @@
---
title: Repository Policies
last_modified: 2026-02-22
---
This document covers repository structure, tooling, and workflow standards. Code
style conventions are in separate documents:
- [Code Styleguide](https://git.eeqj.de/sneak/prompts/raw/branch/main/prompts/CODE_STYLEGUIDE.md)
(general, bash, Docker)
- [Go](https://git.eeqj.de/sneak/prompts/raw/branch/main/prompts/CODE_STYLEGUIDE_GO.md)
- [JavaScript](https://git.eeqj.de/sneak/prompts/raw/branch/main/prompts/CODE_STYLEGUIDE_JS.md)
- [Python](https://git.eeqj.de/sneak/prompts/raw/branch/main/prompts/CODE_STYLEGUIDE_PYTHON.md)
- [Go HTTP Server Conventions](https://git.eeqj.de/sneak/prompts/raw/branch/main/prompts/GO_HTTP_SERVER_CONVENTIONS.md)
---
- Cross-project documentation (such as this file) must include
`last_modified: YYYY-MM-DD` in the YAML front matter so it can be kept in sync
with the authoritative source as policies evolve.
- **ALL external references must be pinned by cryptographic hash.** This
includes Docker base images, Go modules, npm packages, GitHub Actions, and
anything else fetched from a remote source. Version tags (`@v4`, `@latest`,
`:3.21`, etc.) are server-mutable and therefore remote code execution
vulnerabilities. The ONLY acceptable way to reference an external dependency
is by its content hash (Docker `@sha256:...`, Go module hash in `go.sum`, npm
integrity hash in lockfile, GitHub Actions `@<commit-sha>`). No exceptions.
This also means never `curl | bash` to install tools like pyenv, nvm, rustup,
etc. Instead, download a specific release archive from GitHub, verify its hash
(hardcoded in the Dockerfile or script), and only then install. Unverified
install scripts are arbitrary remote code execution. This is the single most
important rule in this document. Double-check every external reference in
every file before committing. There are zero exceptions to this rule.
- Every repo with software must have a root `Makefile` with these targets:
`make test`, `make lint`, `make fmt` (writes), `make fmt-check` (read-only),
`make check` (prereqs: `test`, `lint`, `fmt-check`), `make docker`, and
`make hooks` (installs pre-commit hook). A model Makefile is at
`https://git.eeqj.de/sneak/prompts/raw/branch/main/Makefile`.
- Always use Makefile targets (`make fmt`, `make test`, `make lint`, etc.)
instead of invoking the underlying tools directly. The Makefile is the single
source of truth for how these operations are run.
- The Makefile is authoritative documentation for how the repo is used. Beyond
the required targets above, it should have targets for every common operation:
running a local development server (`make run`, `make dev`), re-initializing
or migrating the database (`make db-reset`, `make migrate`), building
artifacts (`make build`), generating code, seeding data, or anything else a
developer would do regularly. If someone checks out the repo and types
`make<tab>`, they should see every meaningful operation available. A new
contributor should be able to understand the entire development workflow by
reading the Makefile.
- Every repo should have a `Dockerfile`. All Dockerfiles must run `make check`
as a build step so the build fails if the branch is not green. For non-server
repos, the Dockerfile should bring up a development environment and run
`make check`. For server repos, `make check` should run as an early build
stage before the final image is assembled.
- Every repo should have a Gitea Actions workflow (`.gitea/workflows/`) that
runs `docker build .` on push. Since the Dockerfile already runs `make check`,
a successful build implies all checks pass.
- Use platform-standard formatters: `black` for Python, `prettier` for
JS/CSS/Markdown/HTML, `go fmt` for Go. Always use default configuration with
two exceptions: four-space indents (except Go), and `proseWrap: always` for
Markdown (hard-wrap at 80 columns). Documentation and writing repos (Markdown,
HTML, CSS) should also have `.prettierrc` and `.prettierignore`.
- Pre-commit hook: `make check` if local testing is possible, otherwise
`make lint && make fmt-check`. The Makefile should provide a `make hooks`
target to install the pre-commit hook.
- All repos with software must have tests that run via the platform-standard
test framework (`go test`, `pytest`, `jest`/`vitest`, etc.). If no meaningful
tests exist yet, add the most minimal test possible — e.g. importing the
module under test to verify it compiles/parses. There is no excuse for
`make test` to be a no-op.
- `make test` must complete in under 20 seconds. Add a 30-second timeout in the
Makefile.
- Docker builds must complete in under 5 minutes.
- `make check` must not modify any files in the repo. Tests may use temporary
directories.
- `main` must always pass `make check`, no exceptions.
- Never commit secrets. `.env` files, credentials, API keys, and private keys
must be in `.gitignore`. No exceptions.
- `.gitignore` should be comprehensive from the start: OS files (`.DS_Store`),
editor files (`.swp`, `*~`), language build artifacts, and `node_modules/`.
Fetch the standard `.gitignore` from
`https://git.eeqj.de/sneak/prompts/raw/branch/main/.gitignore` when setting up
a new repo.
- Never use `git add -A` or `git add .`. Always stage files explicitly by name.
- Never force-push to `main`.
- Make all changes on a feature branch. You can do whatever you want on a
feature branch.
- `.golangci.yml` is standardized and must _NEVER_ be modified by an agent, only
manually by the user. Fetch from
`https://git.eeqj.de/sneak/prompts/raw/branch/main/.golangci.yml`.
- When pinning images or packages by hash, add a comment above the reference
with the version and date (YYYY-MM-DD).
- Use `yarn`, not `npm`.
- Write all dates as YYYY-MM-DD (ISO 8601).
- Simple projects should be configured with environment variables.
- Dockerized web services listen on port 8080 by default, overridable with
`PORT`.
- `README.md` is the primary documentation. Required sections:
- **Description**: First line must include the project name, purpose,
category (web server, SPA, CLI tool, etc.), license, and author. Example:
"µPaaS is an MIT-licensed Go web application by @sneak that receives
git-frontend webhooks and deploys applications via Docker in realtime."
- **Getting Started**: Copy-pasteable install/usage code block.
- **Rationale**: Why does this exist?
- **Design**: How is the program structured?
- **TODO**: Update meticulously, even between commits. When planning, put
the todo list in the README so a new agent can pick up where the last one
left off.
- **License**: MIT, GPL, or WTFPL. Ask the user for new projects. Include a
`LICENSE` file in the repo root and a License section in the README.
- **Author**: [@sneak](https://sneak.berlin).
- First commit of a new repo should contain only `README.md`.
- Go module root: `sneak.berlin/go/<name>`. Always run `go mod tidy` before
committing.
- Use SemVer.
- Database migrations live in `internal/db/migrations/` and must be embedded in
the binary. Pre-1.0.0: modify existing migrations (no installed base assumed).
Post-1.0.0: add new migration files.
- All repos should have an `.editorconfig` enforcing the project's indentation
settings.
- Avoid putting files in the repo root unless necessary. Root should contain
only project-level config files (`README.md`, `Makefile`, `Dockerfile`,
`LICENSE`, `.gitignore`, `.editorconfig`, `REPO_POLICIES.md`, and
language-specific config). Everything else goes in a subdirectory. Canonical
subdirectory names:
- `bin/` — executable scripts and tools
- `cmd/` — Go command entrypoints
- `configs/` — configuration templates and examples
- `deploy/` — deployment manifests (k8s, compose, terraform)
- `docs/` — documentation and markdown (README.md stays in root)
- `internal/` — Go internal packages
- `internal/db/migrations/` — database migrations
- `pkg/` — Go library packages
- `share/` — systemd units, data files
- `static/` — static assets (images, fonts, etc.)
- `web/` — web frontend source
- When setting up a new repo, files from the `prompts` repo may be used as
templates. Fetch them from
`https://git.eeqj.de/sneak/prompts/raw/branch/main/<path>`.
- New repos must contain at minimum:
- `README.md`, `.git`, `.gitignore`, `.editorconfig`
- `LICENSE`, `REPO_POLICIES.md` (copy from the `prompts` repo)
- `Makefile`
- `Dockerfile`, `.dockerignore`
- `.gitea/workflows/check.yml`
- Go: `go.mod`, `go.sum`, `.golangci.yml`
- JS: `package.json`, `yarn.lock`, `.prettierrc`, `.prettierignore`
- Python: `pyproject.toml`

View File

@@ -1,8 +1,9 @@
// Package chatapi provides a client for the chat server HTTP API. // Package api provides the HTTP client for the chat server API.
package chatapi package api
import ( import (
"bytes" "bytes"
"context"
"encoding/json" "encoding/json"
"errors" "errors"
"fmt" "fmt"
@@ -14,17 +15,20 @@ import (
) )
const ( const (
httpTimeout = 30 * time.Second // httpClientTimeout is the default HTTP client timeout in seconds.
pollExtraDelay = 5 httpClientTimeout = 30
httpErrThreshold = 400 // httpStatusErrorThreshold is the minimum status code considered an error.
httpStatusErrorThreshold = 400
// pollTimeoutBuffer is extra seconds added to HTTP timeout beyond the poll timeout.
pollTimeoutBuffer = 5
) )
// ErrHTTP is returned for non-2xx responses. var (
var ErrHTTP = errors.New("http error") // ErrHTTPStatus is returned when the server responds with an error status code.
ErrHTTPStatus = errors.New("HTTP error")
// ErrUnexpectedFormat is returned when the response format is // ErrUnexpectedFormat is returned when the response format is unexpected.
// not recognised. ErrUnexpectedFormat = errors.New("unexpected format")
var ErrUnexpectedFormat = errors.New("unexpected format") )
// Client wraps HTTP calls to the chat server API. // Client wraps HTTP calls to the chat server API.
type Client struct { type Client struct {
@@ -38,19 +42,14 @@ func NewClient(baseURL string) *Client {
return &Client{ return &Client{
BaseURL: baseURL, BaseURL: baseURL,
HTTPClient: &http.Client{ HTTPClient: &http.Client{
Timeout: httpTimeout, Timeout: httpClientTimeout * time.Second,
}, },
} }
} }
// CreateSession creates a new session on the server. // CreateSession creates a new session on the server.
func (c *Client) CreateSession( func (c *Client) CreateSession(nick string) (*SessionResponse, error) {
nick string, data, err := c.do("POST", "/api/v1/session", &SessionRequest{Nick: nick})
) (*SessionResponse, error) {
data, err := c.do(
"POST", "/api/v1/session",
&SessionRequest{Nick: nick},
)
if err != nil { if err != nil {
return nil, err return nil, err
} }
@@ -92,15 +91,9 @@ func (c *Client) SendMessage(msg *Message) error {
} }
// PollMessages long-polls for new messages. // PollMessages long-polls for new messages.
func (c *Client) PollMessages( func (c *Client) PollMessages(afterID string, timeout int) ([]Message, error) {
afterID string, // Use a longer HTTP timeout than the server long-poll timeout.
timeout int, client := &http.Client{Timeout: time.Duration(timeout+pollTimeoutBuffer) * time.Second}
) ([]Message, error) {
pollTimeout := time.Duration(
timeout+pollExtraDelay,
) * time.Second
client := &http.Client{Timeout: pollTimeout}
params := url.Values{} params := url.Values{}
if afterID != "" { if afterID != "" {
@@ -114,16 +107,14 @@ func (c *Client) PollMessages(
path += "?" + params.Encode() path += "?" + params.Encode()
} }
req, err := http.NewRequest( //nolint:noctx // CLI tool req, err := http.NewRequestWithContext(context.Background(), http.MethodGet, c.BaseURL+path, nil)
http.MethodGet, c.BaseURL+path, nil,
)
if err != nil { if err != nil {
return nil, err return nil, err
} }
req.Header.Set("Authorization", "Bearer "+c.Token) req.Header.Set("Authorization", "Bearer "+c.Token)
resp, err := client.Do(req) //nolint:gosec // URL from user config resp, err := client.Do(req) //nolint:gosec // G704: BaseURL is set by user at connect time, not tainted input
if err != nil { if err != nil {
return nil, err return nil, err
} }
@@ -135,51 +126,37 @@ func (c *Client) PollMessages(
return nil, err return nil, err
} }
if resp.StatusCode >= httpErrThreshold { if resp.StatusCode >= httpStatusErrorThreshold {
return nil, fmt.Errorf( return nil, fmt.Errorf("%w: %d: %s", ErrHTTPStatus, resp.StatusCode, string(data))
"%w: %d: %s",
ErrHTTP, resp.StatusCode, string(data),
)
} }
return decodeMessages(data) // The server may return an array directly or wrapped.
}
func decodeMessages(data []byte) ([]Message, error) {
var msgs []Message var msgs []Message
err := json.Unmarshal(data, &msgs) err = json.Unmarshal(data, &msgs)
if err == nil { if err != nil {
return msgs, nil // Try wrapped format.
}
var wrapped MessagesResponse var wrapped MessagesResponse
err2 := json.Unmarshal(data, &wrapped) err2 := json.Unmarshal(data, &wrapped)
if err2 != nil { if err2 != nil {
return nil, fmt.Errorf( return nil, fmt.Errorf("decode messages: %w (raw: %s)", err, string(data))
"decode messages: %w (raw: %s)",
err, string(data),
)
} }
return wrapped.Messages, nil msgs = wrapped.Messages
}
return msgs, nil
} }
// JoinChannel joins a channel via the unified command // JoinChannel joins a channel via the unified command endpoint.
// endpoint.
func (c *Client) JoinChannel(channel string) error { func (c *Client) JoinChannel(channel string) error {
return c.SendMessage( return c.SendMessage(&Message{Command: "JOIN", To: channel})
&Message{Command: "JOIN", To: channel},
)
} }
// PartChannel leaves a channel via the unified command // PartChannel leaves a channel via the unified command endpoint.
// endpoint.
func (c *Client) PartChannel(channel string) error { func (c *Client) PartChannel(channel string) error {
return c.SendMessage( return c.SendMessage(&Message{Command: "PART", To: channel})
&Message{Command: "PART", To: channel},
)
} }
// ListChannels returns all channels on the server. // ListChannels returns all channels on the server.
@@ -200,13 +177,8 @@ func (c *Client) ListChannels() ([]Channel, error) {
} }
// GetMembers returns members of a channel. // GetMembers returns members of a channel.
func (c *Client) GetMembers( func (c *Client) GetMembers(channel string) ([]string, error) {
channel string, data, err := c.do("GET", "/api/v1/channels/"+url.PathEscape(channel)+"/members", nil)
) ([]string, error) {
path := "/api/v1/channels/" +
url.PathEscape(channel) + "/members"
data, err := c.do("GET", path, nil)
if err != nil { if err != nil {
return nil, err return nil, err
} }
@@ -215,10 +187,15 @@ func (c *Client) GetMembers(
err = json.Unmarshal(data, &members) err = json.Unmarshal(data, &members)
if err != nil { if err != nil {
return nil, fmt.Errorf( // Try object format.
"%w: members: %s", var obj map[string]any
ErrUnexpectedFormat, string(data),
) err2 := json.Unmarshal(data, &obj)
if err2 != nil {
return nil, err
}
// Extract member names from whatever format.
return nil, fmt.Errorf("%w: members: %s", ErrUnexpectedFormat, string(data))
} }
return members, nil return members, nil
@@ -241,10 +218,7 @@ func (c *Client) GetServerInfo() (*ServerInfo, error) {
return &info, nil return &info, nil
} }
func (c *Client) do( func (c *Client) do(method, path string, body any) ([]byte, error) {
method, path string,
body any,
) ([]byte, error) {
var bodyReader io.Reader var bodyReader io.Reader
if body != nil { if body != nil {
@@ -256,9 +230,7 @@ func (c *Client) do(
bodyReader = bytes.NewReader(data) bodyReader = bytes.NewReader(data)
} }
req, err := http.NewRequest( //nolint:noctx // CLI tool req, err := http.NewRequestWithContext(context.Background(), method, c.BaseURL+path, bodyReader)
method, c.BaseURL+path, bodyReader,
)
if err != nil { if err != nil {
return nil, fmt.Errorf("request: %w", err) return nil, fmt.Errorf("request: %w", err)
} }
@@ -269,7 +241,7 @@ func (c *Client) do(
req.Header.Set("Authorization", "Bearer "+c.Token) req.Header.Set("Authorization", "Bearer "+c.Token)
} }
resp, err := c.HTTPClient.Do(req) //nolint:gosec // URL from user config resp, err := c.HTTPClient.Do(req) //nolint:gosec // URL constructed from trusted base URL
if err != nil { if err != nil {
return nil, fmt.Errorf("http: %w", err) return nil, fmt.Errorf("http: %w", err)
} }
@@ -281,11 +253,8 @@ func (c *Client) do(
return nil, fmt.Errorf("read body: %w", err) return nil, fmt.Errorf("read body: %w", err)
} }
if resp.StatusCode >= httpErrThreshold { if resp.StatusCode >= httpStatusErrorThreshold {
return data, fmt.Errorf( return data, fmt.Errorf("%w: %d: %s", ErrHTTPStatus, resp.StatusCode, string(data))
"%w: %d: %s",
ErrHTTP, resp.StatusCode, string(data),
)
} }
return data, nil return data, nil

View File

@@ -1,4 +1,4 @@
package chatapi package api //nolint:revive // package name "api" is conventional for API client packages
import "time" import "time"
@@ -35,13 +35,11 @@ type Message struct {
Meta any `json:"meta,omitempty"` Meta any `json:"meta,omitempty"`
} }
// BodyLines returns the body as a slice of strings (for text // BodyLines returns the body as a slice of strings (for text messages).
// messages).
func (m *Message) BodyLines() []string { func (m *Message) BodyLines() []string {
switch v := m.Body.(type) { switch v := m.Body.(type) {
case []any: case []any:
lines := make([]string, 0, len(v)) lines := make([]string, 0, len(v))
for _, item := range v { for _, item := range v {
if s, ok := item.(string); ok { if s, ok := item.(string); ok {
lines = append(lines, s) lines = append(lines, s)

View File

@@ -1,21 +1,23 @@
// Package main implements chat-cli, an IRC-style terminal client. // Package main implements the chat-cli terminal client.
package main package main
import ( import (
"fmt" "fmt"
"os" "os"
"strconv"
"strings" "strings"
"sync" "sync"
"time" "time"
api "git.eeqj.de/sneak/chat/cmd/chat-cli/api" "git.eeqj.de/sneak/chat/cmd/chat-cli/api"
) )
const ( const (
pollTimeoutSec = 15 // splitParts is the number of parts to split a command into (command + args).
retryDelay = 2 * time.Second splitParts = 2
maxNickLength = 32 // pollTimeout is the long-poll timeout in seconds.
pollTimeout = 15
// pollRetryDelay is the delay before retrying a failed poll.
pollRetryDelay = 2 * time.Second
) )
// App holds the application state. // App holds the application state.
@@ -40,18 +42,12 @@ func main() {
app.ui.OnInput(app.handleInput) app.ui.OnInput(app.handleInput)
app.ui.SetStatus(app.nick, "", "disconnected") app.ui.SetStatus(app.nick, "", "disconnected")
app.ui.AddStatus( app.ui.AddStatus("Welcome to chat-cli — an IRC-style client")
"Welcome to chat-cli \u2014 an IRC-style client", app.ui.AddStatus("Type [yellow]/connect <server-url>[white] to begin, or [yellow]/help[white] for commands")
)
app.ui.AddStatus(
"Type [yellow]/connect <server-url>[white] " +
"to begin, or [yellow]/help[white] for commands",
)
err := app.ui.Run() err := app.ui.Run()
if err != nil { if err != nil {
_, _ = fmt.Fprintf(os.Stderr, "Error: %v\n", err) fmt.Fprintf(os.Stderr, "Error: %v\n", err)
os.Exit(1) os.Exit(1)
} }
} }
@@ -63,29 +59,20 @@ func (a *App) handleInput(text string) {
return return
} }
a.sendPlainText(text) // Plain text → PRIVMSG to current target.
}
func (a *App) sendPlainText(text string) {
a.mu.Lock() a.mu.Lock()
target := a.target target := a.target
connected := a.connected connected := a.connected
nick := a.nick
a.mu.Unlock() a.mu.Unlock()
if !connected { if !connected {
a.ui.AddStatus( a.ui.AddStatus("[red]Not connected. Use /connect <url>")
"[red]Not connected. Use /connect <url>",
)
return return
} }
if target == "" { if target == "" {
a.ui.AddStatus( a.ui.AddStatus("[red]No target. Use /join #channel or /query nick")
"[red]No target. " +
"Use /join #channel or /query nick",
)
return return
} }
@@ -96,26 +83,40 @@ func (a *App) sendPlainText(text string) {
Body: []string{text}, Body: []string{text},
}) })
if err != nil { if err != nil {
a.ui.AddStatus( a.ui.AddStatus(fmt.Sprintf("[red]Send error: %v", err))
fmt.Sprintf("[red]Send error: %v", err),
)
return return
} }
// Echo locally.
ts := time.Now().Format("15:04") ts := time.Now().Format("15:04")
a.ui.AddLine( a.mu.Lock()
target, nick := a.nick
fmt.Sprintf( a.mu.Unlock()
"[gray]%s [green]<%s>[white] %s", a.ui.AddLine(target, fmt.Sprintf("[gray]%s [green]<%s>[white] %s", ts, nick, text))
ts, nick, text,
),
)
} }
func (a *App) handleCommand(text string) { //nolint:cyclop // command dispatch func (a *App) commandHandlers() map[string]func(string) {
parts := strings.SplitN(text, " ", 2) //nolint:mnd // split into cmd+args return map[string]func(string){
"/connect": a.cmdConnect,
"/nick": a.cmdNick,
"/join": a.cmdJoin,
"/part": a.cmdPart,
"/msg": a.cmdMsg,
"/query": a.cmdQuery,
"/topic": a.cmdTopic,
"/names": func(_ string) { a.cmdNames() },
"/list": func(_ string) { a.cmdList() },
"/window": a.cmdWindow,
"/w": a.cmdWindow,
"/quit": func(_ string) { a.cmdQuit() },
"/help": func(_ string) { a.cmdHelp() },
}
}
func (a *App) handleCommand(text string) {
parts := strings.SplitN(text, " ", splitParts)
cmd := strings.ToLower(parts[0]) cmd := strings.ToLower(parts[0])
args := "" args := ""
@@ -123,52 +124,23 @@ func (a *App) handleCommand(text string) { //nolint:cyclop // command dispatch
args = parts[1] args = parts[1]
} }
switch cmd { if handler, ok := a.commandHandlers()[cmd]; ok {
case "/connect": handler(args)
a.cmdConnect(args) } else {
case "/nick": a.ui.AddStatus("[red]Unknown command: " + cmd)
a.cmdNick(args)
case "/join":
a.cmdJoin(args)
case "/part":
a.cmdPart(args)
case "/msg":
a.cmdMsg(args)
case "/query":
a.cmdQuery(args)
case "/topic":
a.cmdTopic(args)
case "/names":
a.cmdNames()
case "/list":
a.cmdList()
case "/window", "/w":
a.cmdWindow(args)
case "/quit":
a.cmdQuit()
case "/help":
a.cmdHelp()
default:
a.ui.AddStatus(
"[red]Unknown command: " + cmd,
)
} }
} }
func (a *App) cmdConnect(serverURL string) { func (a *App) cmdConnect(serverURL string) {
if serverURL == "" { if serverURL == "" {
a.ui.AddStatus( a.ui.AddStatus("[red]Usage: /connect <server-url>")
"[red]Usage: /connect <server-url>",
)
return return
} }
serverURL = strings.TrimRight(serverURL, "/") serverURL = strings.TrimRight(serverURL, "/")
a.ui.AddStatus( a.ui.AddStatus(fmt.Sprintf("Connecting to %s...", serverURL))
fmt.Sprintf("Connecting to %s...", serverURL),
)
a.mu.Lock() a.mu.Lock()
nick := a.nick nick := a.nick
@@ -178,11 +150,7 @@ func (a *App) cmdConnect(serverURL string) {
resp, err := client.CreateSession(nick) resp, err := client.CreateSession(nick)
if err != nil { if err != nil {
a.ui.AddStatus( a.ui.AddStatus(fmt.Sprintf("[red]Connection failed: %v", err))
fmt.Sprintf(
"[red]Connection failed: %v", err,
),
)
return return
} }
@@ -194,16 +162,11 @@ func (a *App) cmdConnect(serverURL string) {
a.lastMsgID = "" a.lastMsgID = ""
a.mu.Unlock() a.mu.Unlock()
a.ui.AddStatus( a.ui.AddStatus(fmt.Sprintf("[green]Connected! Nick: %s, Session: %s", resp.Nick, resp.SessionID))
fmt.Sprintf(
"[green]Connected! Nick: %s, Session: %s",
resp.Nick, resp.SessionID,
),
)
a.ui.SetStatus(resp.Nick, "", "connected") a.ui.SetStatus(resp.Nick, "", "connected")
// Start polling.
a.stopPoll = make(chan struct{}) a.stopPoll = make(chan struct{})
go a.pollLoop() go a.pollLoop()
} }
@@ -222,13 +185,7 @@ func (a *App) cmdNick(nick string) {
a.mu.Lock() a.mu.Lock()
a.nick = nick a.nick = nick
a.mu.Unlock() a.mu.Unlock()
a.ui.AddStatus(fmt.Sprintf("Nick set to %s (will be used on connect)", nick))
a.ui.AddStatus(
fmt.Sprintf(
"Nick set to %s (will be used on connect)",
nick,
),
)
return return
} }
@@ -238,11 +195,7 @@ func (a *App) cmdNick(nick string) {
Body: []string{nick}, Body: []string{nick},
}) })
if err != nil { if err != nil {
a.ui.AddStatus( a.ui.AddStatus(fmt.Sprintf("[red]Nick change failed: %v", err))
fmt.Sprintf(
"[red]Nick change failed: %v", err,
),
)
return return
} }
@@ -251,11 +204,8 @@ func (a *App) cmdNick(nick string) {
a.nick = nick a.nick = nick
target := a.target target := a.target
a.mu.Unlock() a.mu.Unlock()
a.ui.SetStatus(nick, target, "connected") a.ui.SetStatus(nick, target, "connected")
a.ui.AddStatus( a.ui.AddStatus("Nick changed to " + nick)
"Nick changed to " + nick,
)
} }
func (a *App) cmdJoin(channel string) { func (a *App) cmdJoin(channel string) {
@@ -281,9 +231,7 @@ func (a *App) cmdJoin(channel string) {
err := a.client.JoinChannel(channel) err := a.client.JoinChannel(channel)
if err != nil { if err != nil {
a.ui.AddStatus( a.ui.AddStatus(fmt.Sprintf("[red]Join failed: %v", err))
fmt.Sprintf("[red]Join failed: %v", err),
)
return return
} }
@@ -294,16 +242,12 @@ func (a *App) cmdJoin(channel string) {
a.mu.Unlock() a.mu.Unlock()
a.ui.SwitchToBuffer(channel) a.ui.SwitchToBuffer(channel)
a.ui.AddLine( a.ui.AddLine(channel, "[yellow]*** Joined "+channel)
channel,
"[yellow]*** Joined "+channel,
)
a.ui.SetStatus(nick, channel, "connected") a.ui.SetStatus(nick, channel, "connected")
} }
func (a *App) cmdPart(channel string) { func (a *App) cmdPart(channel string) {
a.mu.Lock() a.mu.Lock()
if channel == "" { if channel == "" {
channel = a.target channel = a.target
} }
@@ -325,20 +269,14 @@ func (a *App) cmdPart(channel string) {
err := a.client.PartChannel(channel) err := a.client.PartChannel(channel)
if err != nil { if err != nil {
a.ui.AddStatus( a.ui.AddStatus(fmt.Sprintf("[red]Part failed: %v", err))
fmt.Sprintf("[red]Part failed: %v", err),
)
return return
} }
a.ui.AddLine( a.ui.AddLine(channel, "[yellow]*** Left "+channel)
channel,
"[yellow]*** Left "+channel,
)
a.mu.Lock() a.mu.Lock()
if a.target == channel { if a.target == channel {
a.target = "" a.target = ""
} }
@@ -351,8 +289,8 @@ func (a *App) cmdPart(channel string) {
} }
func (a *App) cmdMsg(args string) { func (a *App) cmdMsg(args string) {
parts := strings.SplitN(args, " ", 2) //nolint:mnd // split into target+text parts := strings.SplitN(args, " ", splitParts)
if len(parts) < 2 { //nolint:mnd // min args if len(parts) < splitParts {
a.ui.AddStatus("[red]Usage: /msg <nick> <text>") a.ui.AddStatus("[red]Usage: /msg <nick> <text>")
return return
@@ -377,22 +315,13 @@ func (a *App) cmdMsg(args string) {
Body: []string{text}, Body: []string{text},
}) })
if err != nil { if err != nil {
a.ui.AddStatus( a.ui.AddStatus(fmt.Sprintf("[red]Send failed: %v", err))
fmt.Sprintf("[red]Send failed: %v", err),
)
return return
} }
ts := time.Now().Format("15:04") ts := time.Now().Format("15:04")
a.ui.AddLine(target, fmt.Sprintf("[gray]%s [green]<%s>[white] %s", ts, nick, text))
a.ui.AddLine(
target,
fmt.Sprintf(
"[gray]%s [green]<%s>[white] %s",
ts, nick, text,
),
)
} }
func (a *App) cmdQuery(nick string) { func (a *App) cmdQuery(nick string) {
@@ -430,16 +359,13 @@ func (a *App) cmdTopic(args string) {
} }
if args == "" { if args == "" {
// Query topic.
err := a.client.SendMessage(&api.Message{ err := a.client.SendMessage(&api.Message{
Command: "TOPIC", Command: "TOPIC",
To: target, To: target,
}) })
if err != nil { if err != nil {
a.ui.AddStatus( a.ui.AddStatus(fmt.Sprintf("[red]Topic query failed: %v", err))
fmt.Sprintf(
"[red]Topic query failed: %v", err,
),
)
} }
return return
@@ -451,11 +377,7 @@ func (a *App) cmdTopic(args string) {
Body: []string{args}, Body: []string{args},
}) })
if err != nil { if err != nil {
a.ui.AddStatus( a.ui.AddStatus(fmt.Sprintf("[red]Topic set failed: %v", err))
fmt.Sprintf(
"[red]Topic set failed: %v", err,
),
)
} }
} }
@@ -479,20 +401,12 @@ func (a *App) cmdNames() {
members, err := a.client.GetMembers(target) members, err := a.client.GetMembers(target)
if err != nil { if err != nil {
a.ui.AddStatus( a.ui.AddStatus(fmt.Sprintf("[red]Names failed: %v", err))
fmt.Sprintf("[red]Names failed: %v", err),
)
return return
} }
a.ui.AddLine( a.ui.AddLine(target, fmt.Sprintf("[cyan]*** Members of %s: %s", target, strings.Join(members, " ")))
target,
fmt.Sprintf(
"[cyan]*** Members of %s: %s",
target, strings.Join(members, " "),
),
)
} }
func (a *App) cmdList() { func (a *App) cmdList() {
@@ -508,9 +422,7 @@ func (a *App) cmdList() {
channels, err := a.client.ListChannels() channels, err := a.client.ListChannels()
if err != nil { if err != nil {
a.ui.AddStatus( a.ui.AddStatus(fmt.Sprintf("[red]List failed: %v", err))
fmt.Sprintf("[red]List failed: %v", err),
)
return return
} }
@@ -518,12 +430,7 @@ func (a *App) cmdList() {
a.ui.AddStatus("[cyan]*** Channel list:") a.ui.AddStatus("[cyan]*** Channel list:")
for _, ch := range channels { for _, ch := range channels {
a.ui.AddStatus( a.ui.AddStatus(fmt.Sprintf(" %s (%d members) %s", ch.Name, ch.Members, ch.Topic))
fmt.Sprintf(
" %s (%d members) %s",
ch.Name, ch.Members, ch.Topic,
),
)
} }
a.ui.AddStatus("[cyan]*** End of channel list") a.ui.AddStatus("[cyan]*** End of channel list")
@@ -536,21 +443,21 @@ func (a *App) cmdWindow(args string) {
return return
} }
n, _ := strconv.Atoi(args) n := 0
_, _ = fmt.Sscanf(args, "%d", &n)
a.ui.SwitchBuffer(n) a.ui.SwitchBuffer(n)
a.mu.Lock() a.mu.Lock()
nick := a.nick nick := a.nick
a.mu.Unlock() a.mu.Unlock()
if n >= 0 && n < a.ui.BufferCount() { // Update target based on buffer.
if n < a.ui.BufferCount() {
buf := a.ui.buffers[n] buf := a.ui.buffers[n]
if buf.Name != "(status)" { if buf.Name != "(status)" {
a.mu.Lock() a.mu.Lock()
a.target = buf.Name a.target = buf.Name
a.mu.Unlock() a.mu.Unlock()
a.ui.SetStatus(nick, buf.Name, "connected") a.ui.SetStatus(nick, buf.Name, "connected")
} else { } else {
a.ui.SetStatus(nick, "", "connected") a.ui.SetStatus(nick, "", "connected")
@@ -560,17 +467,13 @@ func (a *App) cmdWindow(args string) {
func (a *App) cmdQuit() { func (a *App) cmdQuit() {
a.mu.Lock() a.mu.Lock()
if a.connected && a.client != nil { if a.connected && a.client != nil {
_ = a.client.SendMessage( _ = a.client.SendMessage(&api.Message{Command: "QUIT"})
&api.Message{Command: "QUIT"},
)
} }
if a.stopPoll != nil { if a.stopPoll != nil {
close(a.stopPoll) close(a.stopPoll)
} }
a.mu.Unlock() a.mu.Unlock()
a.ui.Stop() a.ui.Stop()
} }
@@ -578,21 +481,20 @@ func (a *App) cmdQuit() {
func (a *App) cmdHelp() { func (a *App) cmdHelp() {
help := []string{ help := []string{
"[cyan]*** chat-cli commands:", "[cyan]*** chat-cli commands:",
" /connect <url> \u2014 Connect to server", " /connect <url> Connect to server",
" /nick <name> \u2014 Change nickname", " /nick <name> Change nickname",
" /join #channel \u2014 Join channel", " /join #channel Join channel",
" /part [#chan] \u2014 Leave channel", " /part [#chan] Leave channel",
" /msg <nick> <text> \u2014 Send DM", " /msg <nick> <text> Send DM",
" /query <nick> \u2014 Open DM window", " /query <nick> Open DM window",
" /topic [text] \u2014 View/set topic", " /topic [text] View/set topic",
" /names \u2014 List channel members", " /names List channel members",
" /list \u2014 List channels", " /list List channels",
" /window <n> \u2014 Switch buffer (Alt+0-9)", " /window <n> Switch buffer (Alt+0-9)",
" /quit \u2014 Disconnect and exit", " /quit Disconnect and exit",
" /help \u2014 This help", " /help This help",
" Plain text sends to current target.", " Plain text sends to current target.",
} }
for _, line := range help { for _, line := range help {
a.ui.AddStatus(line) a.ui.AddStatus(line)
} }
@@ -616,31 +518,38 @@ func (a *App) pollLoop() {
return return
} }
msgs, err := client.PollMessages( msgs, err := client.PollMessages(lastID, pollTimeout)
lastID, pollTimeoutSec,
)
if err != nil { if err != nil {
time.Sleep(retryDelay) // Transient error — retry after delay.
time.Sleep(pollRetryDelay)
continue continue
} }
for i := range msgs { for _, msg := range msgs {
a.handleServerMessage(&msgs[i]) a.handleServerMessage(&msg)
if msgs[i].ID != "" { if msg.ID != "" {
a.mu.Lock() a.mu.Lock()
a.lastMsgID = msgs[i].ID a.lastMsgID = msg.ID
a.mu.Unlock() a.mu.Unlock()
} }
} }
} }
} }
func (a *App) handleServerMessage( func (a *App) messageTimestamp(msg *api.Message) string {
msg *api.Message, if msg.TS != "" {
) { t := msg.ParseTS()
ts := a.parseMessageTS(msg)
return t.Local().Format("15:04") //nolint:gosmopolitan // CLI displays local time intentionally
}
return time.Now().Format("15:04")
}
func (a *App) handleServerMessage(msg *api.Message) {
ts := a.messageTimestamp(msg)
a.mu.Lock() a.mu.Lock()
myNick := a.nick myNick := a.nick
@@ -648,38 +557,25 @@ func (a *App) handleServerMessage(
switch msg.Command { switch msg.Command {
case "PRIVMSG": case "PRIVMSG":
a.handlePrivmsgMsg(msg, ts, myNick) a.handleMsgPrivmsg(msg, ts, myNick)
case "JOIN": case "JOIN":
a.handleJoinMsg(msg, ts) a.handleMsgJoin(msg, ts)
case "PART": case "PART":
a.handlePartMsg(msg, ts) a.handleMsgPart(msg, ts)
case "QUIT": case "QUIT":
a.handleQuitMsg(msg, ts) a.handleMsgQuit(msg, ts)
case "NICK": case "NICK":
a.handleNickMsg(msg, ts, myNick) a.handleMsgNick(msg, ts, myNick)
case "NOTICE": case "NOTICE":
a.handleNoticeMsg(msg, ts) a.handleMsgNotice(msg, ts)
case "TOPIC": case "TOPIC":
a.handleTopicMsg(msg, ts) a.handleMsgTopic(msg, ts)
default: default:
a.handleDefaultMsg(msg, ts) a.handleMsgDefault(msg, ts)
} }
} }
func (a *App) parseMessageTS(msg *api.Message) string { func (a *App) handleMsgPrivmsg(msg *api.Message, ts, myNick string) {
if msg.TS != "" {
t := msg.ParseTS()
return t.In(time.Local).Format("15:04") //nolint:gosmopolitan // CLI uses local time
}
return time.Now().Format("15:04")
}
func (a *App) handlePrivmsgMsg(
msg *api.Message,
ts, myNick string,
) {
lines := msg.BodyLines() lines := msg.BodyLines()
text := strings.Join(lines, " ") text := strings.Join(lines, " ")
@@ -692,88 +588,40 @@ func (a *App) handlePrivmsgMsg(
target = msg.From target = msg.From
} }
a.ui.AddLine( a.ui.AddLine(target, fmt.Sprintf("[gray]%s [green]<%s>[white] %s", ts, msg.From, text))
target,
fmt.Sprintf(
"[gray]%s [green]<%s>[white] %s",
ts, msg.From, text,
),
)
} }
func (a *App) handleJoinMsg( func (a *App) handleMsgJoin(msg *api.Message, ts string) {
msg *api.Message, ts string, if msg.To != "" {
) { a.ui.AddLine(msg.To, fmt.Sprintf("[gray]%s [yellow]*** %s has joined %s", ts, msg.From, msg.To))
}
}
func (a *App) handleMsgPart(msg *api.Message, ts string) {
target := msg.To target := msg.To
reason := strings.Join(msg.BodyLines(), " ")
if target == "" { if target == "" {
return return
} }
a.ui.AddLine(
target,
fmt.Sprintf(
"[gray]%s [yellow]*** %s has joined %s",
ts, msg.From, target,
),
)
}
func (a *App) handlePartMsg(
msg *api.Message, ts string,
) {
target := msg.To
if target == "" {
return
}
lines := msg.BodyLines()
reason := strings.Join(lines, " ")
if reason != "" { if reason != "" {
a.ui.AddLine( a.ui.AddLine(target, fmt.Sprintf("[gray]%s [yellow]*** %s has left %s (%s)", ts, msg.From, target, reason))
target,
fmt.Sprintf(
"[gray]%s [yellow]*** %s has left %s (%s)",
ts, msg.From, target, reason,
),
)
} else { } else {
a.ui.AddLine( a.ui.AddLine(target, fmt.Sprintf("[gray]%s [yellow]*** %s has left %s", ts, msg.From, target))
target,
fmt.Sprintf(
"[gray]%s [yellow]*** %s has left %s",
ts, msg.From, target,
),
)
} }
} }
func (a *App) handleQuitMsg( func (a *App) handleMsgQuit(msg *api.Message, ts string) {
msg *api.Message, ts string, reason := strings.Join(msg.BodyLines(), " ")
) {
lines := msg.BodyLines()
reason := strings.Join(lines, " ")
if reason != "" { if reason != "" {
a.ui.AddStatus( a.ui.AddStatus(fmt.Sprintf("[gray]%s [yellow]*** %s has quit (%s)", ts, msg.From, reason))
fmt.Sprintf(
"[gray]%s [yellow]*** %s has quit (%s)",
ts, msg.From, reason,
),
)
} else { } else {
a.ui.AddStatus( a.ui.AddStatus(fmt.Sprintf("[gray]%s [yellow]*** %s has quit", ts, msg.From))
fmt.Sprintf(
"[gray]%s [yellow]*** %s has quit",
ts, msg.From,
),
)
} }
} }
func (a *App) handleNickMsg( func (a *App) handleMsgNick(msg *api.Message, ts, myNick string) {
msg *api.Message, ts, myNick string,
) {
lines := msg.BodyLines() lines := msg.BodyLines()
newNick := "" newNick := ""
@@ -786,65 +634,27 @@ func (a *App) handleNickMsg(
a.nick = newNick a.nick = newNick
target := a.target target := a.target
a.mu.Unlock() a.mu.Unlock()
a.ui.SetStatus(newNick, target, "connected") a.ui.SetStatus(newNick, target, "connected")
} }
a.ui.AddStatus( a.ui.AddStatus(fmt.Sprintf("[gray]%s [yellow]*** %s is now known as %s", ts, msg.From, newNick))
fmt.Sprintf(
"[gray]%s [yellow]*** %s is now known as %s",
ts, msg.From, newNick,
),
)
} }
func (a *App) handleNoticeMsg( func (a *App) handleMsgNotice(msg *api.Message, ts string) {
msg *api.Message, ts string, text := strings.Join(msg.BodyLines(), " ")
) { a.ui.AddStatus(fmt.Sprintf("[gray]%s [magenta]--%s-- %s", ts, msg.From, text))
lines := msg.BodyLines()
text := strings.Join(lines, " ")
a.ui.AddStatus(
fmt.Sprintf(
"[gray]%s [magenta]--%s-- %s",
ts, msg.From, text,
),
)
} }
func (a *App) handleTopicMsg( func (a *App) handleMsgTopic(msg *api.Message, ts string) {
msg *api.Message, ts string, text := strings.Join(msg.BodyLines(), " ")
) { if msg.To != "" {
if msg.To == "" { a.ui.AddLine(msg.To, fmt.Sprintf("[gray]%s [cyan]*** %s set topic: %s", ts, msg.From, text))
return
} }
lines := msg.BodyLines()
text := strings.Join(lines, " ")
a.ui.AddLine(
msg.To,
fmt.Sprintf(
"[gray]%s [cyan]*** %s set topic: %s",
ts, msg.From, text,
),
)
} }
func (a *App) handleDefaultMsg( func (a *App) handleMsgDefault(msg *api.Message, ts string) {
msg *api.Message, ts string, text := strings.Join(msg.BodyLines(), " ")
) { if text != "" {
lines := msg.BodyLines() a.ui.AddStatus(fmt.Sprintf("[gray]%s [white][%s] %s", ts, msg.Command, text))
text := strings.Join(lines, " ")
if text == "" {
return
} }
a.ui.AddStatus(
fmt.Sprintf(
"[gray]%s [white][%s] %s",
ts, msg.Command, text,
),
)
} }

View File

@@ -31,7 +31,6 @@ type UI struct {
} }
// NewUI creates the tview-based IRC-like UI. // NewUI creates the tview-based IRC-like UI.
func NewUI() *UI { func NewUI() *UI {
ui := &UI{ ui := &UI{
app: tview.NewApplication(), app: tview.NewApplication(),
@@ -40,35 +39,53 @@ func NewUI() *UI {
}, },
} }
ui.setupMessages() // Message area.
ui.setupStatusBar() ui.messages = tview.NewTextView().
SetDynamicColors(true).
SetScrollable(true).
SetWordWrap(true).
SetChangedFunc(func() {
ui.app.Draw()
})
ui.messages.SetBorder(false)
// Status bar.
ui.statusBar = tview.NewTextView().
SetDynamicColors(true)
ui.statusBar.SetBackgroundColor(tcell.ColorNavy)
ui.statusBar.SetTextColor(tcell.ColorWhite)
ui.setupInput() ui.setupInput()
ui.setupKeybindings() ui.setupKeyCapture()
ui.setupLayout()
// Layout: messages on top, status bar, input at bottom.
ui.layout = tview.NewFlex().SetDirection(tview.FlexRow).
AddItem(ui.messages, 0, 1, false).
AddItem(ui.statusBar, 1, 0, false).
AddItem(ui.input, 1, 0, true)
ui.app.SetRoot(ui.layout, true)
ui.app.SetFocus(ui.input)
return ui return ui
} }
// Run starts the UI event loop (blocks). // Run starts the UI event loop (blocks).
func (ui *UI) Run() error { func (ui *UI) Run() error {
return ui.app.Run() return ui.app.Run()
} }
// Stop stops the UI. // Stop stops the UI.
func (ui *UI) Stop() { func (ui *UI) Stop() {
ui.app.Stop() ui.app.Stop()
} }
// OnInput sets the callback for user input. // OnInput sets the callback for user input.
func (ui *UI) OnInput(fn func(string)) { func (ui *UI) OnInput(fn func(string)) {
ui.onInput = fn ui.onInput = fn
} }
// AddLine adds a line to the specified buffer. // AddLine adds a line to the specified buffer.
func (ui *UI) AddLine(bufferName string, line string) { func (ui *UI) AddLine(bufferName string, line string) {
ui.app.QueueUpdateDraw(func() { ui.app.QueueUpdateDraw(func() {
buf := ui.getOrCreateBuffer(bufferName) buf := ui.getOrCreateBuffer(bufferName)
@@ -89,18 +106,12 @@ func (ui *UI) AddLine(bufferName string, line string) {
} }
// AddStatus adds a line to the status buffer (buffer 0). // AddStatus adds a line to the status buffer (buffer 0).
func (ui *UI) AddStatus(line string) { func (ui *UI) AddStatus(line string) {
ts := time.Now().Format("15:04") ts := time.Now().Format("15:04")
ui.AddLine("(status)", fmt.Sprintf("[gray]%s[white] %s", ts, line))
ui.AddLine(
"(status)",
fmt.Sprintf("[gray]%s[white] %s", ts, line),
)
} }
// SwitchBuffer switches to the buffer at index n. // SwitchBuffer switches to the buffer at index n.
func (ui *UI) SwitchBuffer(n int) { func (ui *UI) SwitchBuffer(n int) {
ui.app.QueueUpdateDraw(func() { ui.app.QueueUpdateDraw(func() {
if n < 0 || n >= len(ui.buffers) { if n < 0 || n >= len(ui.buffers) {
@@ -108,7 +119,6 @@ func (ui *UI) SwitchBuffer(n int) {
} }
ui.currentBuffer = n ui.currentBuffer = n
buf := ui.buffers[n] buf := ui.buffers[n]
buf.Unread = 0 buf.Unread = 0
@@ -123,12 +133,10 @@ func (ui *UI) SwitchBuffer(n int) {
}) })
} }
// SwitchToBuffer switches to the named buffer, creating it // SwitchToBuffer switches to the named buffer, creating it if needed.
func (ui *UI) SwitchToBuffer(name string) { func (ui *UI) SwitchToBuffer(name string) {
ui.app.QueueUpdateDraw(func() { ui.app.QueueUpdateDraw(func() {
buf := ui.getOrCreateBuffer(name) buf := ui.getOrCreateBuffer(name)
for i, b := range ui.buffers { for i, b := range ui.buffers {
if b == buf { if b == buf {
ui.currentBuffer = i ui.currentBuffer = i
@@ -151,23 +159,18 @@ func (ui *UI) SwitchToBuffer(name string) {
} }
// SetStatus updates the status bar text. // SetStatus updates the status bar text.
func (ui *UI) SetStatus(nick, target, connStatus string) {
func (ui *UI) SetStatus(
nick, target, connStatus string,
) {
ui.app.QueueUpdateDraw(func() { ui.app.QueueUpdateDraw(func() {
ui.refreshStatusWith(nick, target, connStatus) ui.refreshStatusWith(nick, target, connStatus)
}) })
} }
// BufferCount returns the number of buffers. // BufferCount returns the number of buffers.
func (ui *UI) BufferCount() int { func (ui *UI) BufferCount() int {
return len(ui.buffers) return len(ui.buffers)
} }
// BufferIndex returns the index of a named buffer, or -1. // BufferIndex returns the index of a named buffer, or -1.
func (ui *UI) BufferIndex(name string) int { func (ui *UI) BufferIndex(name string) int {
for i, buf := range ui.buffers { for i, buf := range ui.buffers {
if buf.Name == name { if buf.Name == name {
@@ -178,29 +181,10 @@ func (ui *UI) BufferIndex(name string) int {
return -1 return -1
} }
func (ui *UI) setupMessages() {
ui.messages = tview.NewTextView().
SetDynamicColors(true).
SetScrollable(true).
SetWordWrap(true).
SetChangedFunc(func() {
ui.app.Draw()
})
ui.messages.SetBorder(false)
}
func (ui *UI) setupStatusBar() {
ui.statusBar = tview.NewTextView().
SetDynamicColors(true)
ui.statusBar.SetBackgroundColor(tcell.ColorNavy)
ui.statusBar.SetTextColor(tcell.ColorWhite)
}
func (ui *UI) setupInput() { func (ui *UI) setupInput() {
ui.input = tview.NewInputField(). ui.input = tview.NewInputField().
SetFieldBackgroundColor(tcell.ColorBlack). SetFieldBackgroundColor(tcell.ColorBlack).
SetFieldTextColor(tcell.ColorWhite) SetFieldTextColor(tcell.ColorWhite)
ui.input.SetDoneFunc(func(key tcell.Key) { ui.input.SetDoneFunc(func(key tcell.Key) {
if key != tcell.KeyEnter { if key != tcell.KeyEnter {
return return
@@ -219,13 +203,9 @@ func (ui *UI) setupInput() {
}) })
} }
func (ui *UI) setupKeybindings() { func (ui *UI) setupKeyCapture() {
ui.app.SetInputCapture( ui.app.SetInputCapture(func(event *tcell.EventKey) *tcell.EventKey {
func(event *tcell.EventKey) *tcell.EventKey { if event.Modifiers()&tcell.ModAlt != 0 {
if event.Modifiers()&tcell.ModAlt == 0 {
return event
}
r := event.Rune() r := event.Rune()
if r >= '0' && r <= '9' { if r >= '0' && r <= '9' {
idx := int(r - '0') idx := int(r - '0')
@@ -233,63 +213,36 @@ func (ui *UI) setupKeybindings() {
return nil return nil
} }
}
return event return event
}, })
)
} }
func (ui *UI) setupLayout() {
ui.layout = tview.NewFlex().
SetDirection(tview.FlexRow).
AddItem(ui.messages, 0, 1, false).
AddItem(ui.statusBar, 1, 0, false).
AddItem(ui.input, 1, 0, true)
ui.app.SetRoot(ui.layout, true)
ui.app.SetFocus(ui.input)
}
// if needed.
func (ui *UI) refreshStatus() { func (ui *UI) refreshStatus() {
// Rebuilt from app state by parent QueueUpdateDraw. // Will be called from the main goroutine via QueueUpdateDraw parent.
// Rebuild status from app state — caller must provide context.
} }
func (ui *UI) refreshStatusWith( func (ui *UI) refreshStatusWith(nick, target, connStatus string) {
nick, target, connStatus string,
) {
var unreadParts []string var unreadParts []string
for i, buf := range ui.buffers { for i, buf := range ui.buffers {
if buf.Unread > 0 { if buf.Unread > 0 {
unreadParts = append( unreadParts = append(unreadParts, fmt.Sprintf("%d:%s(%d)", i, buf.Name, buf.Unread))
unreadParts,
fmt.Sprintf(
"%d:%s(%d)", i, buf.Name, buf.Unread,
),
)
} }
} }
unread := "" unread := ""
if len(unreadParts) > 0 { if len(unreadParts) > 0 {
unread = " [Act: " + unread = " [Act: " + strings.Join(unreadParts, ",") + "]"
strings.Join(unreadParts, ",") + "]"
} }
bufInfo := fmt.Sprintf( bufInfo := fmt.Sprintf("[%d:%s]", ui.currentBuffer, ui.buffers[ui.currentBuffer].Name)
"[%d:%s]",
ui.currentBuffer,
ui.buffers[ui.currentBuffer].Name,
)
ui.statusBar.Clear() ui.statusBar.Clear()
_, _ = fmt.Fprintf(ui.statusBar, " [%s] %s %s %s%s",
_, _ = fmt.Fprintf( connStatus, nick, bufInfo, target, unread)
ui.statusBar, " [%s] %s %s %s%s",
connStatus, nick, bufInfo, target, unread,
)
} }
func (ui *UI) getOrCreateBuffer(name string) *Buffer { func (ui *UI) getOrCreateBuffer(name string) *Buffer {

View File

@@ -88,7 +88,7 @@ func NewTest(dsn string) (*Database, error) {
} }
// Item 9: Enable foreign keys // Item 9: Enable foreign keys
_, err = d.Exec("PRAGMA foreign_keys = ON") //nolint:noctx // no context in sql.Open path _, err = d.ExecContext(context.Background(), "PRAGMA foreign_keys = ON")
if err != nil { if err != nil {
_ = d.Close() _ = d.Close()
@@ -164,8 +164,8 @@ func (s *Database) GetChannelByID(
return c, nil return c, nil
} }
// GetUserByNickModel looks up a user by their nick. // GetUserByNick looks up a user by their nick.
func (s *Database) GetUserByNickModel( func (s *Database) GetUserByNick(
ctx context.Context, ctx context.Context,
nick string, nick string,
) (*models.User, error) { ) (*models.User, error) {
@@ -187,8 +187,8 @@ func (s *Database) GetUserByNickModel(
return u, nil return u, nil
} }
// GetUserByTokenModel looks up a user by their auth token. // GetUserByToken looks up a user by their auth token.
func (s *Database) GetUserByTokenModel( func (s *Database) GetUserByToken(
ctx context.Context, ctx context.Context,
token string, token string,
) (*models.User, error) { ) (*models.User, error) {
@@ -238,8 +238,8 @@ func (s *Database) UpdateUserLastSeen(
return err return err
} }
// CreateUserModel inserts a new user into the database. // CreateUser inserts a new user into the database.
func (s *Database) CreateUserModel( func (s *Database) CreateUser(
ctx context.Context, ctx context.Context,
id, nick, passwordHash string, id, nick, passwordHash string,
) (*models.User, error) { ) (*models.User, error) {
@@ -435,7 +435,8 @@ func (s *Database) AckMessages(
args[i] = id args[i] = id
} }
query := fmt.Sprintf( //nolint:gosec // placeholders are ?, not user input //nolint:gosec // G201: placeholders are all "?" literals, not user input
query := fmt.Sprintf(
"DELETE FROM message_queue WHERE id IN (%s)", "DELETE FROM message_queue WHERE id IN (%s)",
strings.Join(placeholders, ","), strings.Join(placeholders, ","),
) )
@@ -661,28 +662,7 @@ func (s *Database) applyMigrations(
migrations []migration, migrations []migration,
) error { ) error {
for _, m := range migrations { for _, m := range migrations {
var exists int err := s.applyOneMigration(ctx, m)
err := s.db.QueryRowContext(ctx,
"SELECT COUNT(*) FROM schema_migrations WHERE version = ?",
m.version,
).Scan(&exists)
if err != nil {
return fmt.Errorf(
"check migration %d: %w", m.version, err,
)
}
if exists > 0 {
continue
}
s.log.Info(
"applying migration",
"version", m.version, "name", m.name,
)
err = s.executeMigration(ctx, m)
if err != nil { if err != nil {
return err return err
} }
@@ -691,25 +671,33 @@ func (s *Database) applyMigrations(
return nil return nil
} }
func (s *Database) executeMigration( func (s *Database) applyOneMigration(ctx context.Context, m migration) error {
ctx context.Context, var exists int
m migration,
) error { err := s.db.QueryRowContext(ctx,
"SELECT COUNT(*) FROM schema_migrations WHERE version = ?",
m.version,
).Scan(&exists)
if err != nil {
return fmt.Errorf("check migration %d: %w", m.version, err)
}
if exists > 0 {
return nil
}
s.log.Info("applying migration", "version", m.version, "name", m.name)
tx, err := s.db.BeginTx(ctx, nil) tx, err := s.db.BeginTx(ctx, nil)
if err != nil { if err != nil {
return fmt.Errorf( return fmt.Errorf("begin tx for migration %d: %w", m.version, err)
"begin tx for migration %d: %w", m.version, err,
)
} }
_, err = tx.ExecContext(ctx, m.sql) _, err = tx.ExecContext(ctx, m.sql)
if err != nil { if err != nil {
_ = tx.Rollback() _ = tx.Rollback()
return fmt.Errorf( return fmt.Errorf("apply migration %d (%s): %w", m.version, m.name, err)
"apply migration %d (%s): %w",
m.version, m.name, err,
)
} }
_, err = tx.ExecContext(ctx, _, err = tx.ExecContext(ctx,
@@ -719,17 +707,8 @@ func (s *Database) executeMigration(
if err != nil { if err != nil {
_ = tx.Rollback() _ = tx.Rollback()
return fmt.Errorf( return fmt.Errorf("record migration %d: %w", m.version, err)
"record migration %d: %w", m.version, err,
)
} }
err = tx.Commit() return tx.Commit()
if err != nil {
return fmt.Errorf(
"commit migration %d: %w", m.version, err,
)
}
return nil
} }

View File

@@ -43,119 +43,213 @@ func TestCreateUser(t *testing.T) {
d := setupTestDB(t) d := setupTestDB(t)
ctx := context.Background() ctx := context.Background()
id, token, err := d.CreateUser(ctx, nickAlice) u, err := d.CreateUser(ctx, "u1", nickAlice, "hash1")
if err != nil { if err != nil {
t.Fatalf("CreateUser: %v", err) t.Fatalf("CreateUser: %v", err)
} }
if id <= 0 { if u.ID != "u1" || u.Nick != nickAlice {
t.Errorf("expected positive id, got %d", id) t.Errorf("got user %+v", u)
}
if token == "" {
t.Error("expected non-empty token")
} }
} }
func TestGetUserByToken(t *testing.T) { func TestCreateAuthToken(t *testing.T) {
t.Parallel() t.Parallel()
d := setupTestDB(t) d := setupTestDB(t)
ctx := context.Background() ctx := context.Background()
_, token, _ := d.CreateUser(ctx, nickAlice) _, err := d.CreateUser(ctx, "u1", nickAlice, "h")
id, nick, err := d.GetUserByToken(ctx, token)
if err != nil { if err != nil {
t.Fatalf("GetUserByToken: %v", err) t.Fatalf("CreateUser: %v", err)
} }
if id <= 0 || nick != nickAlice { tok, err := d.CreateAuthToken(ctx, "tok1", "u1")
t.Errorf( if err != nil {
"got id=%d nick=%s, want nick=%s", t.Fatalf("CreateAuthToken: %v", err)
id, nick, nickAlice, }
if tok.Token != "tok1" || tok.UserID != "u1" {
t.Errorf("unexpected token: %+v", tok)
}
u, err := tok.User(ctx)
if err != nil {
t.Fatalf("AuthToken.User: %v", err)
}
if u.ID != "u1" || u.Nick != nickAlice {
t.Errorf("AuthToken.User got %+v", u)
}
}
func TestCreateChannel(t *testing.T) {
t.Parallel()
d := setupTestDB(t)
ctx := context.Background()
ch, err := d.CreateChannel(
ctx, "c1", "#general", "welcome", "+n",
) )
if err != nil {
t.Fatalf("CreateChannel: %v", err)
}
if ch.ID != "c1" || ch.Name != "#general" {
t.Errorf("unexpected channel: %+v", ch)
} }
} }
func TestGetUserByNick(t *testing.T) { func TestAddChannelMember(t *testing.T) {
t.Parallel() t.Parallel()
d := setupTestDB(t) d := setupTestDB(t)
ctx := context.Background() ctx := context.Background()
origID, _, _ := d.CreateUser(ctx, nickAlice) _, _ = d.CreateUser(ctx, "u1", nickAlice, "h")
_, _ = d.CreateChannel(ctx, "c1", "#general", "", "")
id, err := d.GetUserByNick(ctx, nickAlice) cm, err := d.AddChannelMember(ctx, "c1", "u1", "+o")
if err != nil { if err != nil {
t.Fatalf("GetUserByNick: %v", err) t.Fatalf("AddChannelMember: %v", err)
} }
if id != origID { if cm.ChannelID != "c1" || cm.Modes != "+o" {
t.Errorf("got id %d, want %d", id, origID) t.Errorf("unexpected member: %+v", cm)
} }
} }
func TestGetOrCreateChannel(t *testing.T) { func TestCreateMessage(t *testing.T) {
t.Parallel() t.Parallel()
d := setupTestDB(t) d := setupTestDB(t)
ctx := context.Background() ctx := context.Background()
id1, err := d.GetOrCreateChannel(ctx, "#general") _, _ = d.CreateUser(ctx, "u1", nickAlice, "h")
msg, err := d.CreateMessage(
ctx, "m1", "u1", nickAlice,
"#general", "message", "hello",
)
if err != nil { if err != nil {
t.Fatalf("GetOrCreateChannel: %v", err) t.Fatalf("CreateMessage: %v", err)
} }
if id1 <= 0 { if msg.ID != "m1" || msg.Body != "hello" {
t.Errorf("expected positive id, got %d", id1) t.Errorf("unexpected message: %+v", msg)
}
// Same channel returns same ID.
id2, err := d.GetOrCreateChannel(ctx, "#general")
if err != nil {
t.Fatalf("GetOrCreateChannel(2): %v", err)
}
if id1 != id2 {
t.Errorf("got different ids: %d vs %d", id1, id2)
} }
} }
func TestJoinAndListChannels(t *testing.T) { func TestQueueMessage(t *testing.T) {
t.Parallel() t.Parallel()
d := setupTestDB(t) d := setupTestDB(t)
ctx := context.Background() ctx := context.Background()
uid, _, _ := d.CreateUser(ctx, nickAlice) _, _ = d.CreateUser(ctx, "u1", nickAlice, "h")
ch1, _ := d.GetOrCreateChannel(ctx, "#alpha") _, _ = d.CreateUser(ctx, "u2", nickBob, "h")
ch2, _ := d.GetOrCreateChannel(ctx, "#beta") _, _ = d.CreateMessage(
ctx, "m1", "u1", nickAlice, "u2", "message", "hi",
)
_ = d.JoinChannel(ctx, ch1, uid) mq, err := d.QueueMessage(ctx, "u2", "m1")
_ = d.JoinChannel(ctx, ch2, uid)
channels, err := d.ListChannels(ctx, uid)
if err != nil { if err != nil {
t.Fatalf("ListChannels: %v", err) t.Fatalf("QueueMessage: %v", err)
}
if mq.UserID != "u2" || mq.MessageID != "m1" {
t.Errorf("unexpected queue entry: %+v", mq)
}
}
func TestCreateSession(t *testing.T) {
t.Parallel()
d := setupTestDB(t)
ctx := context.Background()
_, _ = d.CreateUser(ctx, "u1", nickAlice, "h")
sess, err := d.CreateSession(ctx, "s1", "u1")
if err != nil {
t.Fatalf("CreateSession: %v", err)
}
if sess.ID != "s1" || sess.UserID != "u1" {
t.Errorf("unexpected session: %+v", sess)
}
u, err := sess.User(ctx)
if err != nil {
t.Fatalf("Session.User: %v", err)
}
if u.ID != "u1" {
t.Errorf("Session.User got %v, want u1", u.ID)
}
}
func TestCreateServerLink(t *testing.T) {
t.Parallel()
d := setupTestDB(t)
ctx := context.Background()
sl, err := d.CreateServerLink(
ctx, "sl1", "peer1",
"https://peer.example.com", "keyhash", true,
)
if err != nil {
t.Fatalf("CreateServerLink: %v", err)
}
if sl.ID != "sl1" || !sl.IsActive {
t.Errorf("unexpected server link: %+v", sl)
}
}
func TestUserChannels(t *testing.T) {
t.Parallel()
d := setupTestDB(t)
ctx := context.Background()
u, _ := d.CreateUser(ctx, "u1", nickAlice, "h")
_, _ = d.CreateChannel(ctx, "c1", "#alpha", "", "")
_, _ = d.CreateChannel(ctx, "c2", "#beta", "", "")
_, _ = d.AddChannelMember(ctx, "c1", "u1", "")
_, _ = d.AddChannelMember(ctx, "c2", "u1", "")
channels, err := u.Channels(ctx)
if err != nil {
t.Fatalf("User.Channels: %v", err)
} }
if len(channels) != 2 { if len(channels) != 2 {
t.Fatalf("expected 2 channels, got %d", len(channels)) t.Fatalf("expected 2 channels, got %d", len(channels))
} }
if channels[0].Name != "#alpha" {
t.Errorf("first channel: got %s", channels[0].Name)
}
if channels[1].Name != "#beta" {
t.Errorf("second channel: got %s", channels[1].Name)
}
} }
func TestListChannelsEmpty(t *testing.T) { func TestUserChannelsEmpty(t *testing.T) {
t.Parallel() t.Parallel()
d := setupTestDB(t) d := setupTestDB(t)
ctx := context.Background() ctx := context.Background()
uid, _, _ := d.CreateUser(ctx, nickAlice) u, _ := d.CreateUser(ctx, "u1", nickAlice, "h")
channels, err := d.ListChannels(ctx, uid) channels, err := u.Channels(ctx)
if err != nil { if err != nil {
t.Fatalf("ListChannels: %v", err) t.Fatalf("User.Channels: %v", err)
} }
if len(channels) != 0 { if len(channels) != 0 {
@@ -163,57 +257,60 @@ func TestListChannelsEmpty(t *testing.T) {
} }
} }
func TestPartChannel(t *testing.T) { func TestUserQueuedMessages(t *testing.T) {
t.Parallel() t.Parallel()
d := setupTestDB(t) d := setupTestDB(t)
ctx := context.Background() ctx := context.Background()
uid, _, _ := d.CreateUser(ctx, nickAlice) u, _ := d.CreateUser(ctx, "u1", nickAlice, "h")
chID, _ := d.GetOrCreateChannel(ctx, "#general") _, _ = d.CreateUser(ctx, "u2", nickBob, "h")
_ = d.JoinChannel(ctx, chID, uid) for i := range 3 {
_ = d.PartChannel(ctx, chID, uid) id := fmt.Sprintf("m%d", i)
channels, err := d.ListChannels(ctx, uid) _, _ = d.CreateMessage(
if err != nil { ctx, id, "u2", nickBob, "u1",
t.Fatalf("ListChannels: %v", err) "message", fmt.Sprintf("msg%d", i),
)
time.Sleep(10 * time.Millisecond)
_, _ = d.QueueMessage(ctx, "u1", id)
} }
if len(channels) != 0 { msgs, err := u.QueuedMessages(ctx)
t.Errorf("expected 0 after part, got %d", len(channels)) if err != nil {
t.Fatalf("User.QueuedMessages: %v", err)
}
if len(msgs) != 3 {
t.Fatalf("expected 3 messages, got %d", len(msgs))
}
for i, msg := range msgs {
want := fmt.Sprintf("msg%d", i)
if msg.Body != want {
t.Errorf("msg %d: got %q, want %q", i, msg.Body, want)
}
} }
} }
func TestSendAndGetMessages(t *testing.T) { func TestUserQueuedMessagesEmpty(t *testing.T) {
t.Parallel() t.Parallel()
d := setupTestDB(t) d := setupTestDB(t)
ctx := context.Background() ctx := context.Background()
uid, _, _ := d.CreateUser(ctx, nickAlice) u, _ := d.CreateUser(ctx, "u1", nickAlice, "h")
chID, _ := d.GetOrCreateChannel(ctx, "#general")
_ = d.JoinChannel(ctx, chID, uid)
_, err := d.SendMessage(ctx, chID, uid, "hello world") msgs, err := u.QueuedMessages(ctx)
if err != nil { if err != nil {
t.Fatalf("SendMessage: %v", err) t.Fatalf("User.QueuedMessages: %v", err)
} }
msgs, err := d.GetMessages(ctx, chID, 0, 0) if len(msgs) != 0 {
if err != nil { t.Errorf("expected 0 messages, got %d", len(msgs))
t.Fatalf("GetMessages: %v", err)
}
if len(msgs) != 1 {
t.Fatalf("expected 1 message, got %d", len(msgs))
}
if msgs[0].Content != "hello world" {
t.Errorf(
"got content %q, want %q",
msgs[0].Content, "hello world",
)
} }
} }
@@ -223,23 +320,35 @@ func TestChannelMembers(t *testing.T) {
d := setupTestDB(t) d := setupTestDB(t)
ctx := context.Background() ctx := context.Background()
uid1, _, _ := d.CreateUser(ctx, nickAlice) ch, _ := d.CreateChannel(ctx, "c1", "#general", "", "")
uid2, _, _ := d.CreateUser(ctx, nickBob) _, _ = d.CreateUser(ctx, "u1", nickAlice, "h")
uid3, _, _ := d.CreateUser(ctx, nickCharlie) _, _ = d.CreateUser(ctx, "u2", nickBob, "h")
chID, _ := d.GetOrCreateChannel(ctx, "#general") _, _ = d.CreateUser(ctx, "u3", nickCharlie, "h")
_, _ = d.AddChannelMember(ctx, "c1", "u1", "+o")
_, _ = d.AddChannelMember(ctx, "c1", "u2", "+v")
_, _ = d.AddChannelMember(ctx, "c1", "u3", "")
_ = d.JoinChannel(ctx, chID, uid1) members, err := ch.Members(ctx)
_ = d.JoinChannel(ctx, chID, uid2)
_ = d.JoinChannel(ctx, chID, uid3)
members, err := d.ChannelMembers(ctx, chID)
if err != nil { if err != nil {
t.Fatalf("ChannelMembers: %v", err) t.Fatalf("Channel.Members: %v", err)
} }
if len(members) != 3 { if len(members) != 3 {
t.Fatalf("expected 3 members, got %d", len(members)) t.Fatalf("expected 3 members, got %d", len(members))
} }
nicks := map[string]bool{}
for _, m := range members {
nicks[m.Nick] = true
}
for _, want := range []string{
nickAlice, nickBob, nickCharlie,
} {
if !nicks[want] {
t.Errorf("missing nick %q", want)
}
}
} }
func TestChannelMembersEmpty(t *testing.T) { func TestChannelMembersEmpty(t *testing.T) {
@@ -248,11 +357,11 @@ func TestChannelMembersEmpty(t *testing.T) {
d := setupTestDB(t) d := setupTestDB(t)
ctx := context.Background() ctx := context.Background()
chID, _ := d.GetOrCreateChannel(ctx, "#empty") ch, _ := d.CreateChannel(ctx, "c1", "#empty", "", "")
members, err := d.ChannelMembers(ctx, chID) members, err := ch.Members(ctx)
if err != nil { if err != nil {
t.Fatalf("ChannelMembers: %v", err) t.Fatalf("Channel.Members: %v", err)
} }
if len(members) != 0 { if len(members) != 0 {
@@ -260,166 +369,126 @@ func TestChannelMembersEmpty(t *testing.T) {
} }
} }
func TestSendDM(t *testing.T) { func TestChannelRecentMessages(t *testing.T) {
t.Parallel() t.Parallel()
d := setupTestDB(t) d := setupTestDB(t)
ctx := context.Background() ctx := context.Background()
uid1, _, _ := d.CreateUser(ctx, nickAlice) ch, _ := d.CreateChannel(ctx, "c1", "#general", "", "")
uid2, _, _ := d.CreateUser(ctx, nickBob) _, _ = d.CreateUser(ctx, "u1", nickAlice, "h")
msgID, err := d.SendDM(ctx, uid1, uid2, "hey bob")
if err != nil {
t.Fatalf("SendDM: %v", err)
}
if msgID <= 0 {
t.Errorf("expected positive msgID, got %d", msgID)
}
msgs, err := d.GetDMs(ctx, uid1, uid2, 0, 0)
if err != nil {
t.Fatalf("GetDMs: %v", err)
}
if len(msgs) != 1 {
t.Fatalf("expected 1 DM, got %d", len(msgs))
}
if msgs[0].Content != "hey bob" {
t.Errorf("got %q, want %q", msgs[0].Content, "hey bob")
}
}
func TestPollMessages(t *testing.T) {
t.Parallel()
d := setupTestDB(t)
ctx := context.Background()
uid1, _, _ := d.CreateUser(ctx, nickAlice)
uid2, _, _ := d.CreateUser(ctx, nickBob)
chID, _ := d.GetOrCreateChannel(ctx, "#general")
_ = d.JoinChannel(ctx, chID, uid1)
_ = d.JoinChannel(ctx, chID, uid2)
_, _ = d.SendMessage(ctx, chID, uid2, "hello")
_, _ = d.SendDM(ctx, uid2, uid1, "private")
time.Sleep(10 * time.Millisecond)
msgs, err := d.PollMessages(ctx, uid1, 0, 0)
if err != nil {
t.Fatalf("PollMessages: %v", err)
}
if len(msgs) < 2 {
t.Fatalf("expected >=2 messages, got %d", len(msgs))
}
}
func TestChangeNick(t *testing.T) {
t.Parallel()
d := setupTestDB(t)
ctx := context.Background()
_, token, _ := d.CreateUser(ctx, nickAlice)
err := d.ChangeNick(ctx, 1, "alice2")
if err != nil {
t.Fatalf("ChangeNick: %v", err)
}
_, nick, err := d.GetUserByToken(ctx, token)
if err != nil {
t.Fatalf("GetUserByToken: %v", err)
}
if nick != "alice2" {
t.Errorf("got nick %q, want alice2", nick)
}
}
func TestSetTopic(t *testing.T) {
t.Parallel()
d := setupTestDB(t)
ctx := context.Background()
uid, _, _ := d.CreateUser(ctx, nickAlice)
_, _ = d.GetOrCreateChannel(ctx, "#general")
err := d.SetTopic(ctx, "#general", uid, "new topic")
if err != nil {
t.Fatalf("SetTopic: %v", err)
}
channels, err := d.ListAllChannels(ctx)
if err != nil {
t.Fatalf("ListAllChannels: %v", err)
}
found := false
for _, ch := range channels {
if ch.Name == "#general" && ch.Topic == "new topic" {
found = true
}
}
if !found {
t.Error("topic was not updated")
}
}
func TestGetMessagesBefore(t *testing.T) {
t.Parallel()
d := setupTestDB(t)
ctx := context.Background()
uid, _, _ := d.CreateUser(ctx, nickAlice)
chID, _ := d.GetOrCreateChannel(ctx, "#general")
_ = d.JoinChannel(ctx, chID, uid)
for i := range 5 { for i := range 5 {
_, _ = d.SendMessage( id := fmt.Sprintf("m%d", i)
ctx, chID, uid,
fmt.Sprintf("msg%d", i), _, _ = d.CreateMessage(
ctx, id, "u1", nickAlice, "#general",
"message", fmt.Sprintf("msg%d", i),
) )
time.Sleep(10 * time.Millisecond) time.Sleep(10 * time.Millisecond)
} }
msgs, err := d.GetMessagesBefore(ctx, chID, 0, 3) msgs, err := ch.RecentMessages(ctx, 3)
if err != nil { if err != nil {
t.Fatalf("GetMessagesBefore: %v", err) t.Fatalf("RecentMessages: %v", err)
} }
if len(msgs) != 3 { if len(msgs) != 3 {
t.Fatalf("expected 3, got %d", len(msgs)) t.Fatalf("expected 3, got %d", len(msgs))
} }
if msgs[0].Body != "msg4" {
t.Errorf("first: got %q, want msg4", msgs[0].Body)
}
if msgs[2].Body != "msg2" {
t.Errorf("last: got %q, want msg2", msgs[2].Body)
}
} }
func TestListAllChannels(t *testing.T) { func TestChannelRecentMessagesLargeLimit(t *testing.T) {
t.Parallel() t.Parallel()
d := setupTestDB(t) d := setupTestDB(t)
ctx := context.Background() ctx := context.Background()
_, _ = d.GetOrCreateChannel(ctx, "#alpha") ch, _ := d.CreateChannel(ctx, "c1", "#general", "", "")
_, _ = d.GetOrCreateChannel(ctx, "#beta") _, _ = d.CreateUser(ctx, "u1", nickAlice, "h")
_, _ = d.CreateMessage(
ctx, "m1", "u1", nickAlice,
"#general", "message", "only",
)
channels, err := d.ListAllChannels(ctx) msgs, err := ch.RecentMessages(ctx, 100)
if err != nil { if err != nil {
t.Fatalf("ListAllChannels: %v", err) t.Fatalf("RecentMessages: %v", err)
} }
if len(channels) != 2 { if len(msgs) != 1 {
t.Errorf("expected 2, got %d", len(channels)) t.Errorf("expected 1, got %d", len(msgs))
}
}
func TestChannelMemberUser(t *testing.T) {
t.Parallel()
d := setupTestDB(t)
ctx := context.Background()
_, _ = d.CreateUser(ctx, "u1", nickAlice, "h")
_, _ = d.CreateChannel(ctx, "c1", "#general", "", "")
cm, _ := d.AddChannelMember(ctx, "c1", "u1", "+o")
u, err := cm.User(ctx)
if err != nil {
t.Fatalf("ChannelMember.User: %v", err)
}
if u.ID != "u1" || u.Nick != nickAlice {
t.Errorf("got %+v", u)
}
}
func TestChannelMemberChannel(t *testing.T) {
t.Parallel()
d := setupTestDB(t)
ctx := context.Background()
_, _ = d.CreateUser(ctx, "u1", nickAlice, "h")
_, _ = d.CreateChannel(ctx, "c1", "#general", "topic", "+n")
cm, _ := d.AddChannelMember(ctx, "c1", "u1", "")
ch, err := cm.Channel(ctx)
if err != nil {
t.Fatalf("ChannelMember.Channel: %v", err)
}
if ch.ID != "c1" || ch.Topic != "topic" {
t.Errorf("got %+v", ch)
}
}
func TestDMMessage(t *testing.T) {
t.Parallel()
d := setupTestDB(t)
ctx := context.Background()
_, _ = d.CreateUser(ctx, "u1", nickAlice, "h")
_, _ = d.CreateUser(ctx, "u2", nickBob, "h")
msg, err := d.CreateMessage(
ctx, "m1", "u1", nickAlice, "u2", "message", "hey",
)
if err != nil {
t.Fatalf("CreateMessage DM: %v", err)
}
if msg.Target != "u2" {
t.Errorf("target: got %q, want u2", msg.Target)
} }
} }

View File

@@ -2,140 +2,44 @@ package db
import ( import (
"context" "context"
"crypto/rand"
"database/sql" "database/sql"
"encoding/hex"
"fmt" "fmt"
"time" "time"
) )
const ( // GetOrCreateChannel returns the channel id, creating it if needed.
defaultMessageLimit = 50 func (s *Database) GetOrCreateChannel(ctx context.Context, name string) (string, error) {
defaultPollLimit = 100 var id string
tokenBytes = 32
)
func generateToken() string { err := s.db.QueryRowContext(ctx, "SELECT id FROM channels WHERE name = ?", name).Scan(&id)
b := make([]byte, tokenBytes)
_, _ = rand.Read(b)
return hex.EncodeToString(b)
}
// CreateUser registers a new user with the given nick and
// returns the user with token.
func (s *Database) CreateUser(
ctx context.Context,
nick string,
) (int64, string, error) {
token := generateToken()
now := time.Now()
res, err := s.db.ExecContext(ctx,
"INSERT INTO users (nick, token, created_at, last_seen) VALUES (?, ?, ?, ?)",
nick, token, now, now)
if err != nil {
return 0, "", fmt.Errorf("create user: %w", err)
}
id, _ := res.LastInsertId()
return id, token, nil
}
// GetUserByToken returns user id and nick for a given auth
// token.
func (s *Database) GetUserByToken(
ctx context.Context,
token string,
) (int64, string, error) {
var id int64
var nick string
err := s.db.QueryRowContext(
ctx,
"SELECT id, nick FROM users WHERE token = ?",
token,
).Scan(&id, &nick)
if err != nil {
return 0, "", err
}
// Update last_seen
_, _ = s.db.ExecContext(
ctx,
"UPDATE users SET last_seen = ? WHERE id = ?",
time.Now(), id,
)
return id, nick, nil
}
// GetUserByNick returns user id for a given nick.
func (s *Database) GetUserByNick(
ctx context.Context,
nick string,
) (int64, error) {
var id int64
err := s.db.QueryRowContext(
ctx,
"SELECT id FROM users WHERE nick = ?",
nick,
).Scan(&id)
return id, err
}
// GetOrCreateChannel returns the channel id, creating it if
// needed.
func (s *Database) GetOrCreateChannel(
ctx context.Context,
name string,
) (int64, error) {
var id int64
err := s.db.QueryRowContext(
ctx,
"SELECT id FROM channels WHERE name = ?",
name,
).Scan(&id)
if err == nil { if err == nil {
return id, nil return id, nil
} }
now := time.Now() now := time.Now()
id = fmt.Sprintf("ch-%d", now.UnixNano())
res, err := s.db.ExecContext(ctx, _, err = s.db.ExecContext(ctx,
"INSERT INTO channels (name, created_at, updated_at) VALUES (?, ?, ?)", "INSERT INTO channels (id, name, topic, modes, created_at, updated_at) VALUES (?, ?, '', '', ?, ?)",
name, now, now) id, name, now, now)
if err != nil { if err != nil {
return 0, fmt.Errorf("create channel: %w", err) return "", fmt.Errorf("create channel: %w", err)
} }
id, _ = res.LastInsertId()
return id, nil return id, nil
} }
// JoinChannel adds a user to a channel. // JoinChannel adds a user to a channel.
func (s *Database) JoinChannel( func (s *Database) JoinChannel(ctx context.Context, channelID, userID string) error {
ctx context.Context,
channelID, userID int64,
) error {
_, err := s.db.ExecContext(ctx, _, err := s.db.ExecContext(ctx,
"INSERT OR IGNORE INTO channel_members (channel_id, user_id, joined_at) VALUES (?, ?, ?)", "INSERT OR IGNORE INTO channel_members (channel_id, user_id, modes, joined_at) VALUES (?, ?, '', ?)",
channelID, userID, time.Now()) channelID, userID, time.Now())
return err return err
} }
// PartChannel removes a user from a channel. // PartChannel removes a user from a channel.
func (s *Database) PartChannel( func (s *Database) PartChannel(ctx context.Context, channelID, userID string) error {
ctx context.Context,
channelID, userID int64,
) error {
_, err := s.db.ExecContext(ctx, _, err := s.db.ExecContext(ctx,
"DELETE FROM channel_members WHERE channel_id = ? AND user_id = ?", "DELETE FROM channel_members WHERE channel_id = ? AND user_id = ?",
channelID, userID) channelID, userID)
@@ -143,18 +47,8 @@ func (s *Database) PartChannel(
return err return err
} }
// ChannelInfo is a lightweight channel representation.
type ChannelInfo struct {
ID int64 `json:"id"`
Name string `json:"name"`
Topic string `json:"topic"`
}
// ListChannels returns all channels the user has joined. // ListChannels returns all channels the user has joined.
func (s *Database) ListChannels( func (s *Database) ListChannels(ctx context.Context, userID string) ([]ChannelInfo, error) {
ctx context.Context,
userID int64,
) ([]ChannelInfo, error) {
rows, err := s.db.QueryContext(ctx, rows, err := s.db.QueryContext(ctx,
`SELECT c.id, c.name, c.topic FROM channels c `SELECT c.id, c.name, c.topic FROM channels c
INNER JOIN channel_members cm ON cm.channel_id = c.id INNER JOIN channel_members cm ON cm.channel_id = c.id
@@ -165,7 +59,7 @@ func (s *Database) ListChannels(
defer func() { _ = rows.Close() }() defer func() { _ = rows.Close() }()
var channels []ChannelInfo channels := []ChannelInfo{}
for rows.Next() { for rows.Next() {
var ch ChannelInfo var ch ChannelInfo
@@ -178,32 +72,20 @@ func (s *Database) ListChannels(
channels = append(channels, ch) channels = append(channels, ch)
} }
err = rows.Err() return channels, rows.Err()
if err != nil {
return nil, err
}
if channels == nil {
channels = []ChannelInfo{}
}
return channels, nil
} }
// MemberInfo represents a channel member. // ChannelInfo is a lightweight channel representation.
type MemberInfo struct { type ChannelInfo struct {
ID int64 `json:"id"` ID string `json:"id"`
Nick string `json:"nick"` Name string `json:"name"`
LastSeen time.Time `json:"lastSeen"` Topic string `json:"topic"`
} }
// ChannelMembers returns all members of a channel. // ChannelMembers returns all members of a channel.
func (s *Database) ChannelMembers( func (s *Database) ChannelMembers(ctx context.Context, channelID string) ([]MemberInfo, error) {
ctx context.Context,
channelID int64,
) ([]MemberInfo, error) {
rows, err := s.db.QueryContext(ctx, rows, err := s.db.QueryContext(ctx,
`SELECT u.id, u.nick, u.last_seen FROM users u `SELECT u.id, u.nick, u.last_seen_at FROM users u
INNER JOIN channel_members cm ON cm.user_id = u.id INNER JOIN channel_members cm ON cm.user_id = u.id
WHERE cm.channel_id = ? ORDER BY u.nick`, channelID) WHERE cm.channel_id = ? ORDER BY u.nick`, channelID)
if err != nil { if err != nil {
@@ -212,7 +94,7 @@ func (s *Database) ChannelMembers(
defer func() { _ = rows.Close() }() defer func() { _ = rows.Close() }()
var members []MemberInfo members := []MemberInfo{}
for rows.Next() { for rows.Next() {
var m MemberInfo var m MemberInfo
@@ -225,21 +107,19 @@ func (s *Database) ChannelMembers(
members = append(members, m) members = append(members, m)
} }
err = rows.Err() return members, rows.Err()
if err != nil { }
return nil, err
}
if members == nil { // MemberInfo represents a channel member.
members = []MemberInfo{} type MemberInfo struct {
} ID string `json:"id"`
Nick string `json:"nick"`
return members, nil LastSeen *time.Time `json:"lastSeen"`
} }
// MessageInfo represents a chat message. // MessageInfo represents a chat message.
type MessageInfo struct { type MessageInfo struct {
ID int64 `json:"id"` ID string `json:"id"`
Channel string `json:"channel,omitempty"` Channel string `json:"channel,omitempty"`
Nick string `json:"nick"` Nick string `json:"nick"`
Content string `json:"content"` Content string `json:"content"`
@@ -248,223 +128,117 @@ type MessageInfo struct {
CreatedAt time.Time `json:"createdAt"` CreatedAt time.Time `json:"createdAt"`
} }
// GetMessages returns messages for a channel, optionally
// after a given ID.
func (s *Database) GetMessages(
ctx context.Context,
channelID int64,
afterID int64,
limit int,
) ([]MessageInfo, error) {
if limit <= 0 {
limit = defaultMessageLimit
}
rows, err := s.db.QueryContext(ctx,
`SELECT m.id, c.name, u.nick, m.content, m.created_at
FROM messages m
INNER JOIN users u ON u.id = m.user_id
INNER JOIN channels c ON c.id = m.channel_id
WHERE m.channel_id = ? AND m.is_dm = 0 AND m.id > ?
ORDER BY m.id ASC LIMIT ?`, channelID, afterID, limit)
if err != nil {
return nil, err
}
defer func() { _ = rows.Close() }()
var msgs []MessageInfo
for rows.Next() {
var m MessageInfo
err := rows.Scan(
&m.ID, &m.Channel, &m.Nick,
&m.Content, &m.CreatedAt,
)
if err != nil {
return nil, err
}
msgs = append(msgs, m)
}
err = rows.Err()
if err != nil {
return nil, err
}
if msgs == nil {
msgs = []MessageInfo{}
}
return msgs, nil
}
// SendMessage inserts a channel message. // SendMessage inserts a channel message.
func (s *Database) SendMessage( func (s *Database) SendMessage(ctx context.Context, channelID, userID, nick, content string) (string, error) {
ctx context.Context, now := time.Now()
channelID, userID int64, id := fmt.Sprintf("msg-%d", now.UnixNano())
content string,
) (int64, error) { _, err := s.db.ExecContext(ctx,
res, err := s.db.ExecContext(ctx, `INSERT INTO messages (id, ts, from_user_id, from_nick, target, type, body, meta, created_at)
"INSERT INTO messages (channel_id, user_id, content, is_dm, created_at) VALUES (?, ?, ?, 0, ?)", VALUES (?, ?, ?, ?, ?, 'message', ?, '{}', ?)`,
channelID, userID, content, time.Now()) id, now, userID, nick, channelID, content, now)
if err != nil { if err != nil {
return 0, err return "", err
} }
return res.LastInsertId() return id, nil
} }
// SendDM inserts a direct message. // SendDM inserts a direct message.
func (s *Database) SendDM( func (s *Database) SendDM(ctx context.Context, fromID, fromNick, toID, content string) (string, error) {
ctx context.Context, now := time.Now()
fromID, toID int64, id := fmt.Sprintf("msg-%d", now.UnixNano())
content string,
) (int64, error) { _, err := s.db.ExecContext(ctx,
res, err := s.db.ExecContext(ctx, `INSERT INTO messages (id, ts, from_user_id, from_nick, target, type, body, meta, created_at)
"INSERT INTO messages (user_id, content, is_dm, dm_target_id, created_at) VALUES (?, ?, 1, ?, ?)", VALUES (?, ?, ?, ?, ?, 'message', ?, '{}', ?)`,
fromID, content, toID, time.Now()) id, now, fromID, fromNick, toID, content, now)
if err != nil { if err != nil {
return 0, err return "", err
} }
return res.LastInsertId() return id, nil
} }
// GetDMs returns direct messages between two users after a // PollMessages returns all new messages for a user's joined channels, ordered by timestamp.
// given ID. func (s *Database) PollMessages(ctx context.Context, userID string, afterTS string, limit int) ([]MessageInfo, error) {
func (s *Database) GetDMs(
ctx context.Context,
userA, userB int64,
afterID int64,
limit int,
) ([]MessageInfo, error) {
if limit <= 0 { if limit <= 0 {
limit = defaultMessageLimit limit = 100
} }
rows, err := s.db.QueryContext(ctx, rows, err := s.db.QueryContext(ctx,
`SELECT m.id, u.nick, m.content, t.nick, m.created_at `SELECT m.id, m.target, m.from_nick, m.body, m.created_at
FROM messages m FROM messages m
INNER JOIN users u ON u.id = m.user_id WHERE m.created_at > COALESCE(NULLIF(?, ''), '1970-01-01')
INNER JOIN users t ON t.id = m.dm_target_id AND (
WHERE m.is_dm = 1 AND m.id > ? m.target IN (SELECT cm.channel_id FROM channel_members cm WHERE cm.user_id = ?)
AND ((m.user_id = ? AND m.dm_target_id = ?) OR m.target = ?
OR (m.user_id = ? AND m.dm_target_id = ?)) OR m.from_user_id = ?
ORDER BY m.id ASC LIMIT ?`, )
afterID, userA, userB, userB, userA, limit) ORDER BY m.created_at ASC LIMIT ?`,
afterTS, userID, userID, userID, limit)
if err != nil { if err != nil {
return nil, err return nil, err
} }
defer func() { _ = rows.Close() }() defer func() { _ = rows.Close() }()
var msgs []MessageInfo msgs := []MessageInfo{}
for rows.Next() { for rows.Next() {
var m MessageInfo var m MessageInfo
err := rows.Scan( err := rows.Scan(&m.ID, &m.Channel, &m.Nick, &m.Content, &m.CreatedAt)
&m.ID, &m.Nick, &m.Content,
&m.DMTarget, &m.CreatedAt,
)
if err != nil { if err != nil {
return nil, err return nil, err
} }
m.IsDM = true
msgs = append(msgs, m) msgs = append(msgs, m)
} }
err = rows.Err() return msgs, rows.Err()
if err != nil {
return nil, err
}
if msgs == nil {
msgs = []MessageInfo{}
}
return msgs, nil
} }
// PollMessages returns all new messages (channel + DM) for // GetMessagesBefore returns channel messages before a given timestamp (for history scrollback).
// a user after a given ID. func (s *Database) GetMessagesBefore(
func (s *Database) PollMessages( ctx context.Context, target string, beforeTS string, limit int,
ctx context.Context,
userID int64,
afterID int64,
limit int,
) ([]MessageInfo, error) { ) ([]MessageInfo, error) {
if limit <= 0 { if limit <= 0 {
limit = defaultPollLimit limit = 50
} }
rows, err := s.db.QueryContext(ctx, var rows *sql.Rows
`SELECT m.id, COALESCE(c.name, ''), u.nick, m.content,
m.is_dm, COALESCE(t.nick, ''), m.created_at var err error
if beforeTS != "" {
rows, err = s.db.QueryContext(ctx,
`SELECT m.id, m.target, m.from_nick, m.body, m.created_at
FROM messages m FROM messages m
INNER JOIN users u ON u.id = m.user_id WHERE m.target = ? AND m.created_at < ?
LEFT JOIN channels c ON c.id = m.channel_id ORDER BY m.created_at DESC LIMIT ?`,
LEFT JOIN users t ON t.id = m.dm_target_id target, beforeTS, limit)
WHERE m.id > ? AND ( } else {
(m.is_dm = 0 AND m.channel_id IN rows, err = s.db.QueryContext(ctx,
(SELECT channel_id FROM channel_members `SELECT m.id, m.target, m.from_nick, m.body, m.created_at
WHERE user_id = ?)) FROM messages m
OR (m.is_dm = 1 WHERE m.target = ?
AND (m.user_id = ? OR m.dm_target_id = ?)) ORDER BY m.created_at DESC LIMIT ?`,
) target, limit)
ORDER BY m.id ASC LIMIT ?`, }
afterID, userID, userID, userID, limit)
if err != nil { if err != nil {
return nil, err return nil, err
} }
defer func() { _ = rows.Close() }() defer func() { _ = rows.Close() }()
msgs := make([]MessageInfo, 0) msgs := []MessageInfo{}
for rows.Next() {
var (
m MessageInfo
isDM int
)
err := rows.Scan(
&m.ID, &m.Channel, &m.Nick, &m.Content,
&isDM, &m.DMTarget, &m.CreatedAt,
)
if err != nil {
return nil, err
}
m.IsDM = isDM == 1
msgs = append(msgs, m)
}
err = rows.Err()
if err != nil {
return nil, err
}
return msgs, nil
}
func scanChannelMessages(
rows *sql.Rows,
) ([]MessageInfo, error) {
var msgs []MessageInfo
for rows.Next() { for rows.Next() {
var m MessageInfo var m MessageInfo
err := rows.Scan( err := rows.Scan(&m.ID, &m.Channel, &m.Nick, &m.Content, &m.CreatedAt)
&m.ID, &m.Channel, &m.Nick,
&m.Content, &m.CreatedAt,
)
if err != nil { if err != nil {
return nil, err return nil, err
} }
@@ -472,209 +246,94 @@ func scanChannelMessages(
msgs = append(msgs, m) msgs = append(msgs, m)
} }
err := rows.Err() // Reverse to ascending order.
if err != nil {
return nil, err
}
if msgs == nil {
msgs = []MessageInfo{}
}
return msgs, nil
}
func scanDMMessages(
rows *sql.Rows,
) ([]MessageInfo, error) {
var msgs []MessageInfo
for rows.Next() {
var m MessageInfo
err := rows.Scan(
&m.ID, &m.Nick, &m.Content,
&m.DMTarget, &m.CreatedAt,
)
if err != nil {
return nil, err
}
m.IsDM = true
msgs = append(msgs, m)
}
err := rows.Err()
if err != nil {
return nil, err
}
if msgs == nil {
msgs = []MessageInfo{}
}
return msgs, nil
}
func reverseMessages(msgs []MessageInfo) {
for i, j := 0, len(msgs)-1; i < j; i, j = i+1, j-1 { for i, j := 0, len(msgs)-1; i < j; i, j = i+1, j-1 {
msgs[i], msgs[j] = msgs[j], msgs[i] msgs[i], msgs[j] = msgs[j], msgs[i]
} }
return msgs, rows.Err()
} }
// GetMessagesBefore returns channel messages before a given // GetDMsBefore returns DMs between two users before a given timestamp.
// ID (for history scrollback).
func (s *Database) GetMessagesBefore(
ctx context.Context,
channelID int64,
beforeID int64,
limit int,
) ([]MessageInfo, error) {
if limit <= 0 {
limit = defaultMessageLimit
}
var query string
var args []any
if beforeID > 0 {
query = `SELECT m.id, c.name, u.nick, m.content,
m.created_at
FROM messages m
INNER JOIN users u ON u.id = m.user_id
INNER JOIN channels c ON c.id = m.channel_id
WHERE m.channel_id = ? AND m.is_dm = 0
AND m.id < ?
ORDER BY m.id DESC LIMIT ?`
args = []any{channelID, beforeID, limit}
} else {
query = `SELECT m.id, c.name, u.nick, m.content,
m.created_at
FROM messages m
INNER JOIN users u ON u.id = m.user_id
INNER JOIN channels c ON c.id = m.channel_id
WHERE m.channel_id = ? AND m.is_dm = 0
ORDER BY m.id DESC LIMIT ?`
args = []any{channelID, limit}
}
rows, err := s.db.QueryContext(ctx, query, args...)
if err != nil {
return nil, err
}
defer func() { _ = rows.Close() }()
msgs, scanErr := scanChannelMessages(rows)
if scanErr != nil {
return nil, scanErr
}
// Reverse to ascending order.
reverseMessages(msgs)
return msgs, nil
}
// GetDMsBefore returns DMs between two users before a given
// ID (for history scrollback).
func (s *Database) GetDMsBefore( func (s *Database) GetDMsBefore(
ctx context.Context, ctx context.Context, userA, userB string, beforeTS string, limit int,
userA, userB int64,
beforeID int64,
limit int,
) ([]MessageInfo, error) { ) ([]MessageInfo, error) {
if limit <= 0 { if limit <= 0 {
limit = defaultMessageLimit limit = 50
} }
var query string var rows *sql.Rows
var args []any var err error
if beforeID > 0 { if beforeTS != "" {
query = `SELECT m.id, u.nick, m.content, t.nick, rows, err = s.db.QueryContext(ctx,
m.created_at `SELECT m.id, m.from_nick, m.body, m.target, m.created_at
FROM messages m FROM messages m
INNER JOIN users u ON u.id = m.user_id WHERE m.created_at < ?
INNER JOIN users t ON t.id = m.dm_target_id AND ((m.from_user_id = ? AND m.target = ?) OR (m.from_user_id = ? AND m.target = ?))
WHERE m.is_dm = 1 AND m.id < ? ORDER BY m.created_at DESC LIMIT ?`,
AND ((m.user_id = ? AND m.dm_target_id = ?) beforeTS, userA, userB, userB, userA, limit)
OR (m.user_id = ? AND m.dm_target_id = ?))
ORDER BY m.id DESC LIMIT ?`
args = []any{
beforeID, userA, userB, userB, userA, limit,
}
} else { } else {
query = `SELECT m.id, u.nick, m.content, t.nick, rows, err = s.db.QueryContext(ctx,
m.created_at `SELECT m.id, m.from_nick, m.body, m.target, m.created_at
FROM messages m FROM messages m
INNER JOIN users u ON u.id = m.user_id WHERE (m.from_user_id = ? AND m.target = ?) OR (m.from_user_id = ? AND m.target = ?)
INNER JOIN users t ON t.id = m.dm_target_id ORDER BY m.created_at DESC LIMIT ?`,
WHERE m.is_dm = 1 userA, userB, userB, userA, limit)
AND ((m.user_id = ? AND m.dm_target_id = ?)
OR (m.user_id = ? AND m.dm_target_id = ?))
ORDER BY m.id DESC LIMIT ?`
args = []any{userA, userB, userB, userA, limit}
} }
rows, err := s.db.QueryContext(ctx, query, args...)
if err != nil { if err != nil {
return nil, err return nil, err
} }
defer func() { _ = rows.Close() }() defer func() { _ = rows.Close() }()
msgs, scanErr := scanDMMessages(rows) msgs := []MessageInfo{}
if scanErr != nil {
return nil, scanErr for rows.Next() {
var m MessageInfo
err := rows.Scan(&m.ID, &m.Nick, &m.Content, &m.DMTarget, &m.CreatedAt)
if err != nil {
return nil, err
}
m.IsDM = true
msgs = append(msgs, m)
} }
// Reverse to ascending order. // Reverse to ascending order.
reverseMessages(msgs) for i, j := 0, len(msgs)-1; i < j; i, j = i+1, j-1 {
msgs[i], msgs[j] = msgs[j], msgs[i]
}
return msgs, nil return msgs, rows.Err()
} }
// ChangeNick updates a user's nickname. // ChangeNick updates a user's nickname.
func (s *Database) ChangeNick( func (s *Database) ChangeNick(ctx context.Context, userID string, newNick string) error {
ctx context.Context,
userID int64,
newNick string,
) error {
_, err := s.db.ExecContext(ctx, _, err := s.db.ExecContext(ctx,
"UPDATE users SET nick = ? WHERE id = ?", "UPDATE users SET nick = ? WHERE id = ?", newNick, userID)
newNick, userID)
return err return err
} }
// SetTopic sets the topic for a channel. // SetTopic sets the topic for a channel.
func (s *Database) SetTopic( func (s *Database) SetTopic(ctx context.Context, channelName string, _ string, topic string) error {
ctx context.Context,
channelName string,
_ int64,
topic string,
) error {
_, err := s.db.ExecContext(ctx, _, err := s.db.ExecContext(ctx,
"UPDATE channels SET topic = ? WHERE name = ?", "UPDATE channels SET topic = ? WHERE name = ?", topic, channelName)
topic, channelName)
return err return err
} }
// GetServerName returns the server name (unused, config // GetServerName returns the server name (unused, config provides this).
// provides this).
func (s *Database) GetServerName() string { func (s *Database) GetServerName() string {
return "" return ""
} }
// ListAllChannels returns all channels. // ListAllChannels returns all channels.
func (s *Database) ListAllChannels( func (s *Database) ListAllChannels(ctx context.Context) ([]ChannelInfo, error) {
ctx context.Context,
) ([]ChannelInfo, error) {
rows, err := s.db.QueryContext(ctx, rows, err := s.db.QueryContext(ctx,
"SELECT id, name, topic FROM channels ORDER BY name") "SELECT id, name, topic FROM channels ORDER BY name")
if err != nil { if err != nil {
@@ -683,14 +342,12 @@ func (s *Database) ListAllChannels(
defer func() { _ = rows.Close() }() defer func() { _ = rows.Close() }()
var channels []ChannelInfo channels := []ChannelInfo{}
for rows.Next() { for rows.Next() {
var ch ChannelInfo var ch ChannelInfo
err := rows.Scan( err := rows.Scan(&ch.ID, &ch.Name, &ch.Topic)
&ch.ID, &ch.Name, &ch.Topic,
)
if err != nil { if err != nil {
return nil, err return nil, err
} }
@@ -698,14 +355,5 @@ func (s *Database) ListAllChannels(
channels = append(channels, ch) channels = append(channels, ch)
} }
err = rows.Err() return channels, rows.Err()
if err != nil {
return nil, err
}
if channels == nil {
channels = []ChannelInfo{}
}
return channels, nil
} }

View File

@@ -1,53 +1,4 @@
-- Migration 003: Replace UUID-based tables with simple integer-keyed -- Migration 003: no-op (schema already created by 002_schema.sql)
-- tables for the HTTP API. Drops the 002 tables and recreates them. -- This migration previously conflicted with 002 by attempting to recreate
-- tables with incompatible column types (INTEGER vs TEXT IDs).
PRAGMA foreign_keys = OFF; SELECT 1;
DROP TABLE IF EXISTS message_queue;
DROP TABLE IF EXISTS sessions;
DROP TABLE IF EXISTS server_links;
DROP TABLE IF EXISTS messages;
DROP TABLE IF EXISTS channel_members;
DROP TABLE IF EXISTS auth_tokens;
DROP TABLE IF EXISTS channels;
DROP TABLE IF EXISTS users;
CREATE TABLE users (
id INTEGER PRIMARY KEY AUTOINCREMENT,
nick TEXT NOT NULL UNIQUE,
token TEXT NOT NULL UNIQUE,
created_at DATETIME DEFAULT CURRENT_TIMESTAMP,
last_seen DATETIME DEFAULT CURRENT_TIMESTAMP
);
CREATE TABLE channels (
id INTEGER PRIMARY KEY AUTOINCREMENT,
name TEXT NOT NULL UNIQUE,
topic TEXT NOT NULL DEFAULT '',
created_at DATETIME DEFAULT CURRENT_TIMESTAMP,
updated_at DATETIME DEFAULT CURRENT_TIMESTAMP
);
CREATE TABLE channel_members (
id INTEGER PRIMARY KEY AUTOINCREMENT,
channel_id INTEGER NOT NULL REFERENCES channels(id) ON DELETE CASCADE,
user_id INTEGER NOT NULL REFERENCES users(id) ON DELETE CASCADE,
joined_at DATETIME DEFAULT CURRENT_TIMESTAMP,
UNIQUE(channel_id, user_id)
);
CREATE TABLE messages (
id INTEGER PRIMARY KEY AUTOINCREMENT,
channel_id INTEGER REFERENCES channels(id) ON DELETE CASCADE,
user_id INTEGER NOT NULL REFERENCES users(id) ON DELETE CASCADE,
content TEXT NOT NULL,
is_dm INTEGER NOT NULL DEFAULT 0,
dm_target_id INTEGER REFERENCES users(id) ON DELETE CASCADE,
created_at DATETIME DEFAULT CURRENT_TIMESTAMP
);
CREATE INDEX idx_messages_channel ON messages(channel_id, created_at);
CREATE INDEX idx_messages_dm ON messages(user_id, dm_target_id, created_at);
CREATE INDEX idx_users_token ON users(token);
PRAGMA foreign_keys = ON;

View File

@@ -1,7 +1,9 @@
package handlers package handlers
import ( import (
"crypto/rand"
"database/sql" "database/sql"
"encoding/hex"
"encoding/json" "encoding/json"
"net/http" "net/http"
"strconv" "strconv"
@@ -11,93 +13,51 @@ import (
"github.com/go-chi/chi" "github.com/go-chi/chi"
) )
const ( // authUser extracts the user from the Authorization header (Bearer token).
maxNickLen = 32 func (s *Handlers) authUser(r *http.Request) (string, string, error) {
defaultHistory = 50
)
// authUser extracts the user from the Authorization header
// (Bearer token).
func (s *Handlers) authUser(
r *http.Request,
) (int64, string, error) {
auth := r.Header.Get("Authorization") auth := r.Header.Get("Authorization")
if !strings.HasPrefix(auth, "Bearer ") { if !strings.HasPrefix(auth, "Bearer ") {
return 0, "", sql.ErrNoRows return "", "", sql.ErrNoRows
} }
token := strings.TrimPrefix(auth, "Bearer ") token := strings.TrimPrefix(auth, "Bearer ")
return s.params.Database.GetUserByToken(r.Context(), token) u, err := s.params.Database.GetUserByToken(r.Context(), token)
if err != nil {
return "", "", err
}
return u.ID, u.Nick, nil
} }
func (s *Handlers) requireAuth( func (s *Handlers) requireAuth(w http.ResponseWriter, r *http.Request) (string, string, bool) {
w http.ResponseWriter,
r *http.Request,
) (int64, string, bool) {
uid, nick, err := s.authUser(r) uid, nick, err := s.authUser(r)
if err != nil { if err != nil {
s.respondJSON( s.respondJSON(w, r, map[string]string{"error": "unauthorized"}, http.StatusUnauthorized)
w, r,
map[string]string{"error": "unauthorized"},
http.StatusUnauthorized,
)
return 0, "", false return "", "", false
} }
return uid, nick, true return uid, nick, true
} }
func (s *Handlers) respondError( const idBytes = 16
w http.ResponseWriter,
r *http.Request, func generateID() string {
msg string, b := make([]byte, idBytes)
code int, _, _ = rand.Read(b)
) {
s.respondJSON(w, r, map[string]string{"error": msg}, code) return hex.EncodeToString(b)
} }
func (s *Handlers) internalError( // HandleCreateSession creates a new user session and returns the auth token.
w http.ResponseWriter,
r *http.Request,
msg string,
err error,
) {
s.log.Error(msg, "error", err)
s.respondError(w, r, "internal error", http.StatusInternalServerError)
}
// bodyLines extracts body as string lines from a request body
// field.
func bodyLines(body any) []string {
switch v := body.(type) {
case []any:
lines := make([]string, 0, len(v))
for _, item := range v {
if s, ok := item.(string); ok {
lines = append(lines, s)
}
}
return lines
case []string:
return v
default:
return nil
}
}
// HandleCreateSession creates a new user session and returns
// the auth token.
func (s *Handlers) HandleCreateSession() http.HandlerFunc { func (s *Handlers) HandleCreateSession() http.HandlerFunc {
type request struct { type request struct {
Nick string `json:"nick"` Nick string `json:"nick"`
} }
type response struct { type response struct {
ID int64 `json:"id"` ID string `json:"id"`
Nick string `json:"nick"` Nick string `json:"nick"`
Token string `json:"token"` Token string `json:"token"`
} }
@@ -107,56 +67,52 @@ func (s *Handlers) HandleCreateSession() http.HandlerFunc {
err := json.NewDecoder(r.Body).Decode(&req) err := json.NewDecoder(r.Body).Decode(&req)
if err != nil { if err != nil {
s.respondError( s.respondJSON(w, r, map[string]string{"error": "invalid request"}, http.StatusBadRequest)
w, r, "invalid request",
http.StatusBadRequest,
)
return return
} }
req.Nick = strings.TrimSpace(req.Nick) req.Nick = strings.TrimSpace(req.Nick)
if req.Nick == "" || len(req.Nick) > 32 {
if req.Nick == "" || len(req.Nick) > maxNickLen { s.respondJSON(w, r, map[string]string{"error": "nick must be 1-32 characters"}, http.StatusBadRequest)
s.respondError(
w, r, "nick must be 1-32 characters",
http.StatusBadRequest,
)
return return
} }
id, token, err := s.params.Database.CreateUser( id := generateID()
r.Context(), req.Nick,
) u, err := s.params.Database.CreateUser(r.Context(), id, req.Nick, "")
if err != nil { if err != nil {
if strings.Contains(err.Error(), "UNIQUE") { if strings.Contains(err.Error(), "UNIQUE") {
s.respondError( s.respondJSON(w, r, map[string]string{"error": "nick already taken"}, http.StatusConflict)
w, r, "nick already taken",
http.StatusConflict,
)
return return
} }
s.internalError(w, r, "create user failed", err) s.log.Error("create user failed", "error", err)
s.respondJSON(w, r, map[string]string{"error": "internal error"}, http.StatusInternalServerError)
return return
} }
s.respondJSON( tokenStr := generateID()
w, r,
&response{ID: id, Nick: req.Nick, Token: token}, _, err = s.params.Database.CreateAuthToken(r.Context(), tokenStr, u.ID)
http.StatusCreated, if err != nil {
) s.log.Error("create auth token failed", "error", err)
s.respondJSON(w, r, map[string]string{"error": "internal error"}, http.StatusInternalServerError)
return
}
s.respondJSON(w, r, &response{ID: u.ID, Nick: req.Nick, Token: tokenStr}, http.StatusCreated)
} }
} }
// HandleState returns the current user's info and joined // HandleState returns the current user's info and joined channels.
// channels.
func (s *Handlers) HandleState() http.HandlerFunc { func (s *Handlers) HandleState() http.HandlerFunc {
type response struct { type response struct {
ID int64 `json:"id"` ID string `json:"id"`
Nick string `json:"nick"` Nick string `json:"nick"`
Channels []db.ChannelInfo `json:"channels"` Channels []db.ChannelInfo `json:"channels"`
} }
@@ -167,25 +123,15 @@ func (s *Handlers) HandleState() http.HandlerFunc {
return return
} }
channels, err := s.params.Database.ListChannels( channels, err := s.params.Database.ListChannels(r.Context(), uid)
r.Context(), uid,
)
if err != nil { if err != nil {
s.internalError( s.log.Error("list channels failed", "error", err)
w, r, "list channels failed", err, s.respondJSON(w, r, map[string]string{"error": "internal error"}, http.StatusInternalServerError)
)
return return
} }
s.respondJSON( s.respondJSON(w, r, &response{ID: uid, Nick: nick, Channels: channels}, http.StatusOK)
w, r,
&response{
ID: uid, Nick: nick,
Channels: channels,
},
http.StatusOK,
)
} }
} }
@@ -197,13 +143,10 @@ func (s *Handlers) HandleListAllChannels() http.HandlerFunc {
return return
} }
channels, err := s.params.Database.ListAllChannels( channels, err := s.params.Database.ListAllChannels(r.Context())
r.Context(),
)
if err != nil { if err != nil {
s.internalError( s.log.Error("list all channels failed", "error", err)
w, r, "list all channels failed", err, s.respondJSON(w, r, map[string]string{"error": "internal error"}, http.StatusInternalServerError)
)
return return
} }
@@ -222,29 +165,21 @@ func (s *Handlers) HandleChannelMembers() http.HandlerFunc {
name := "#" + chi.URLParam(r, "channel") name := "#" + chi.URLParam(r, "channel")
var chID int64 var chID string
err := s.params.Database.GetDB().QueryRowContext( //nolint:gosec // parameterized query //nolint:gosec // G701: parameterized query with ? placeholder, not injection
r.Context(), err := s.params.Database.GetDB().QueryRowContext(r.Context(),
"SELECT id FROM channels WHERE name = ?", "SELECT id FROM channels WHERE name = ?", name).Scan(&chID)
name,
).Scan(&chID)
if err != nil { if err != nil {
s.respondError( s.respondJSON(w, r, map[string]string{"error": "channel not found"}, http.StatusNotFound)
w, r, "channel not found",
http.StatusNotFound,
)
return return
} }
members, err := s.params.Database.ChannelMembers( members, err := s.params.Database.ChannelMembers(r.Context(), chID)
r.Context(), chID,
)
if err != nil { if err != nil {
s.internalError( s.log.Error("channel members failed", "error", err)
w, r, "channel members failed", err, s.respondJSON(w, r, map[string]string{"error": "internal error"}, http.StatusInternalServerError)
)
return return
} }
@@ -253,8 +188,8 @@ func (s *Handlers) HandleChannelMembers() http.HandlerFunc {
} }
} }
// HandleGetMessages returns all new messages (channel + DM) // HandleGetMessages returns all new messages (channel + DM) for the user via long-polling.
// for the user via long-polling. // This is the single unified message stream — replaces separate channel/DM/poll endpoints.
func (s *Handlers) HandleGetMessages() http.HandlerFunc { func (s *Handlers) HandleGetMessages() http.HandlerFunc {
return func(w http.ResponseWriter, r *http.Request) { return func(w http.ResponseWriter, r *http.Request) {
uid, _, ok := s.requireAuth(w, r) uid, _, ok := s.requireAuth(w, r)
@@ -262,21 +197,13 @@ func (s *Handlers) HandleGetMessages() http.HandlerFunc {
return return
} }
afterID, _ := strconv.ParseInt( afterTS := r.URL.Query().Get("after")
r.URL.Query().Get("after"), 10, 64, limit, _ := strconv.Atoi(r.URL.Query().Get("limit"))
)
limit, _ := strconv.Atoi( msgs, err := s.params.Database.PollMessages(r.Context(), uid, afterTS, limit)
r.URL.Query().Get("limit"),
)
msgs, err := s.params.Database.PollMessages(
r.Context(), uid, afterID, limit,
)
if err != nil { if err != nil {
s.internalError( s.log.Error("get messages failed", "error", err)
w, r, "get messages failed", err, s.respondJSON(w, r, map[string]string{"error": "internal error"}, http.StatusInternalServerError)
)
return return
} }
@@ -285,389 +212,284 @@ func (s *Handlers) HandleGetMessages() http.HandlerFunc {
} }
} }
type sendRequest struct { // HandleSendCommand handles all C2S commands via POST /messages.
// The "command" field dispatches to the appropriate logic.
func (s *Handlers) HandleSendCommand() http.HandlerFunc {
type request struct {
Command string `json:"command"` Command string `json:"command"`
To string `json:"to"` To string `json:"to"`
Params []string `json:"params,omitempty"` Params []string `json:"params,omitempty"`
Body any `json:"body,omitempty"` Body any `json:"body,omitempty"`
} }
// HandleSendCommand handles all C2S commands via POST
// /messages.
func (s *Handlers) HandleSendCommand() http.HandlerFunc {
return func(w http.ResponseWriter, r *http.Request) { return func(w http.ResponseWriter, r *http.Request) {
uid, nick, ok := s.requireAuth(w, r) uid, nick, ok := s.requireAuth(w, r)
if !ok { if !ok {
return return
} }
var req sendRequest var req request
err := json.NewDecoder(r.Body).Decode(&req) err := json.NewDecoder(r.Body).Decode(&req)
if err != nil { if err != nil {
s.respondError( s.respondJSON(w, r, map[string]string{"error": "invalid request"}, http.StatusBadRequest)
w, r, "invalid request",
http.StatusBadRequest,
)
return return
} }
req.Command = strings.ToUpper( req.Command = strings.ToUpper(strings.TrimSpace(req.Command))
strings.TrimSpace(req.Command),
)
req.To = strings.TrimSpace(req.To) req.To = strings.TrimSpace(req.To)
lines := extractBodyLines(req.Body)
s.dispatchCommand(w, r, uid, nick, &req) s.dispatchCommand(w, r, uid, nick, req.Command, req.To, lines)
}
}
// extractBodyLines converts the request body to string lines.
func extractBodyLines(body any) []string {
switch v := body.(type) {
case []any:
lines := make([]string, 0, len(v))
for _, item := range v {
if str, ok := item.(string); ok {
lines = append(lines, str)
}
}
return lines
case []string:
return v
default:
return nil
} }
} }
func (s *Handlers) dispatchCommand( func (s *Handlers) dispatchCommand(
w http.ResponseWriter, w http.ResponseWriter, r *http.Request,
r *http.Request, uid, nick, command, to string, lines []string,
uid int64,
nick string,
req *sendRequest,
) { ) {
switch req.Command { switch command {
case "PRIVMSG", "NOTICE": case "PRIVMSG", "NOTICE":
s.handlePrivmsg(w, r, uid, req) s.handlePrivmsg(w, r, uid, nick, to, lines)
case "JOIN": case "JOIN":
s.handleJoin(w, r, uid, req) s.handleJoin(w, r, uid, to)
case "PART": case "PART":
s.handlePart(w, r, uid, req) s.handlePart(w, r, uid, to)
case "NICK": case "NICK":
s.handleNick(w, r, uid, req) s.handleNick(w, r, uid, lines)
case "TOPIC": case "TOPIC":
s.handleTopic(w, r, uid, req) s.handleTopic(w, r, uid, to, lines)
case "PING": case "PING":
s.respondJSON( s.respondJSON(w, r, map[string]string{"command": "PONG", "from": s.params.Config.ServerName}, http.StatusOK)
w, r,
map[string]string{
"command": "PONG",
"from": s.params.Config.ServerName,
},
http.StatusOK,
)
default: default:
_ = nick _ = nick
s.respondError( s.respondJSON(w, r, map[string]string{"error": "unknown command: " + command}, http.StatusBadRequest)
w, r,
"unknown command: "+req.Command,
http.StatusBadRequest,
)
} }
} }
func (s *Handlers) handlePrivmsg( func (s *Handlers) handlePrivmsg(w http.ResponseWriter, r *http.Request, uid, nick, to string, lines []string) {
w http.ResponseWriter, if to == "" {
r *http.Request, s.respondJSON(w, r, map[string]string{"error": "to field required"}, http.StatusBadRequest)
uid int64,
req *sendRequest,
) {
if req.To == "" {
s.respondError(
w, r, "to field required",
http.StatusBadRequest,
)
return return
} }
lines := bodyLines(req.Body)
if len(lines) == 0 { if len(lines) == 0 {
s.respondError( s.respondJSON(w, r, map[string]string{"error": "body required"}, http.StatusBadRequest)
w, r, "body required", http.StatusBadRequest,
)
return return
} }
content := strings.Join(lines, "\n") content := strings.Join(lines, "\n")
if strings.HasPrefix(req.To, "#") { if strings.HasPrefix(to, "#") {
s.sendChannelMsg(w, r, uid, req.To, content) s.sendChannelMessage(w, r, uid, nick, to, content)
} else {
s.sendDM(w, r, uid, req.To, content) return
} }
// DM.
s.sendDirectMessage(w, r, uid, nick, to, content)
} }
func (s *Handlers) sendChannelMsg( func (s *Handlers) sendChannelMessage(
w http.ResponseWriter, w http.ResponseWriter, r *http.Request,
r *http.Request, uid, nick, channel, content string,
uid int64,
channel, content string,
) { ) {
var chID int64 var chID string
err := s.params.Database.GetDB().QueryRowContext( //nolint:gosec // parameterized query //nolint:gosec // G701: parameterized query, not injection
r.Context(), err := s.params.Database.GetDB().QueryRowContext(r.Context(),
"SELECT id FROM channels WHERE name = ?", "SELECT id FROM channels WHERE name = ?", channel).Scan(&chID)
channel,
).Scan(&chID)
if err != nil { if err != nil {
s.respondError( s.respondJSON(w, r, map[string]string{"error": "channel not found"}, http.StatusNotFound)
w, r, "channel not found",
http.StatusNotFound,
)
return return
} }
msgID, err := s.params.Database.SendMessage( msgID, err := s.params.Database.SendMessage(r.Context(), chID, uid, nick, content)
r.Context(), chID, uid, content,
)
if err != nil { if err != nil {
s.internalError(w, r, "send message failed", err) s.log.Error("send message failed", "error", err)
s.respondJSON(w, r, map[string]string{"error": "internal error"}, http.StatusInternalServerError)
return return
} }
s.respondJSON( s.respondJSON(w, r, map[string]any{"id": msgID, "status": "sent"}, http.StatusCreated)
w, r,
map[string]any{"id": msgID, "status": "sent"},
http.StatusCreated,
)
} }
func (s *Handlers) sendDM( func (s *Handlers) sendDirectMessage(
w http.ResponseWriter, w http.ResponseWriter, r *http.Request,
r *http.Request, uid, nick, to, content string,
uid int64,
toNick, content string,
) { ) {
targetID, err := s.params.Database.GetUserByNick( targetUser, err := s.params.Database.GetUserByNick(r.Context(), to)
r.Context(), toNick,
)
if err != nil { if err != nil {
s.respondError( s.respondJSON(w, r, map[string]string{"error": "user not found"}, http.StatusNotFound)
w, r, "user not found", http.StatusNotFound,
)
return return
} }
msgID, err := s.params.Database.SendDM( msgID, err := s.params.Database.SendDM(r.Context(), uid, nick, targetUser.ID, content)
r.Context(), uid, targetID, content,
)
if err != nil { if err != nil {
s.internalError(w, r, "send dm failed", err) s.log.Error("send dm failed", "error", err)
s.respondJSON(w, r, map[string]string{"error": "internal error"}, http.StatusInternalServerError)
return return
} }
s.respondJSON( s.respondJSON(w, r, map[string]any{"id": msgID, "status": "sent"}, http.StatusCreated)
w, r,
map[string]any{"id": msgID, "status": "sent"},
http.StatusCreated,
)
} }
func (s *Handlers) handleJoin( func (s *Handlers) handleJoin(w http.ResponseWriter, r *http.Request, uid, to string) {
w http.ResponseWriter, if to == "" {
r *http.Request, s.respondJSON(w, r, map[string]string{"error": "to field required"}, http.StatusBadRequest)
uid int64,
req *sendRequest,
) {
if req.To == "" {
s.respondError(
w, r, "to field required",
http.StatusBadRequest,
)
return return
} }
channel := req.To channel := to
if !strings.HasPrefix(channel, "#") { if !strings.HasPrefix(channel, "#") {
channel = "#" + channel channel = "#" + channel
} }
chID, err := s.params.Database.GetOrCreateChannel( chID, err := s.params.Database.GetOrCreateChannel(r.Context(), channel)
r.Context(), channel,
)
if err != nil { if err != nil {
s.internalError( s.log.Error("get/create channel failed", "error", err)
w, r, "get/create channel failed", err, s.respondJSON(w, r, map[string]string{"error": "internal error"}, http.StatusInternalServerError)
)
return return
} }
err = s.params.Database.JoinChannel( err = s.params.Database.JoinChannel(r.Context(), chID, uid)
r.Context(), chID, uid,
)
if err != nil { if err != nil {
s.internalError(w, r, "join channel failed", err) s.log.Error("join channel failed", "error", err)
s.respondJSON(w, r, map[string]string{"error": "internal error"}, http.StatusInternalServerError)
return return
} }
s.respondJSON( s.respondJSON(w, r, map[string]string{"status": "joined", "channel": channel}, http.StatusOK)
w, r,
map[string]string{
"status": "joined", "channel": channel,
},
http.StatusOK,
)
} }
func (s *Handlers) handlePart( func (s *Handlers) handlePart(w http.ResponseWriter, r *http.Request, uid, to string) {
w http.ResponseWriter, if to == "" {
r *http.Request, s.respondJSON(w, r, map[string]string{"error": "to field required"}, http.StatusBadRequest)
uid int64,
req *sendRequest,
) {
if req.To == "" {
s.respondError(
w, r, "to field required",
http.StatusBadRequest,
)
return return
} }
channel := req.To channel := to
if !strings.HasPrefix(channel, "#") { if !strings.HasPrefix(channel, "#") {
channel = "#" + channel channel = "#" + channel
} }
var chID int64 var chID string
err := s.params.Database.GetDB().QueryRowContext( //nolint:gosec // parameterized query //nolint:gosec // G701: parameterized query, not injection
r.Context(), err := s.params.Database.GetDB().QueryRowContext(r.Context(),
"SELECT id FROM channels WHERE name = ?", "SELECT id FROM channels WHERE name = ?", channel).Scan(&chID)
channel,
).Scan(&chID)
if err != nil { if err != nil {
s.respondError( s.respondJSON(w, r, map[string]string{"error": "channel not found"}, http.StatusNotFound)
w, r, "channel not found",
http.StatusNotFound,
)
return return
} }
err = s.params.Database.PartChannel( err = s.params.Database.PartChannel(r.Context(), chID, uid)
r.Context(), chID, uid,
)
if err != nil { if err != nil {
s.internalError(w, r, "part channel failed", err) s.log.Error("part channel failed", "error", err)
s.respondJSON(w, r, map[string]string{"error": "internal error"}, http.StatusInternalServerError)
return return
} }
s.respondJSON( s.respondJSON(w, r, map[string]string{"status": "parted", "channel": channel}, http.StatusOK)
w, r,
map[string]string{
"status": "parted", "channel": channel,
},
http.StatusOK,
)
} }
func (s *Handlers) handleNick( func (s *Handlers) handleNick(w http.ResponseWriter, r *http.Request, uid string, lines []string) {
w http.ResponseWriter,
r *http.Request,
uid int64,
req *sendRequest,
) {
lines := bodyLines(req.Body)
if len(lines) == 0 { if len(lines) == 0 {
s.respondError( s.respondJSON(w, r, map[string]string{"error": "body required (new nick)"}, http.StatusBadRequest)
w, r, "body required (new nick)",
http.StatusBadRequest,
)
return return
} }
newNick := strings.TrimSpace(lines[0]) newNick := strings.TrimSpace(lines[0])
if newNick == "" || len(newNick) > maxNickLen { if newNick == "" || len(newNick) > 32 {
s.respondError( s.respondJSON(w, r, map[string]string{"error": "nick must be 1-32 characters"}, http.StatusBadRequest)
w, r, "nick must be 1-32 characters",
http.StatusBadRequest,
)
return return
} }
err := s.params.Database.ChangeNick( err := s.params.Database.ChangeNick(r.Context(), uid, newNick)
r.Context(), uid, newNick,
)
if err != nil { if err != nil {
if strings.Contains(err.Error(), "UNIQUE") { if strings.Contains(err.Error(), "UNIQUE") {
s.respondError( s.respondJSON(w, r, map[string]string{"error": "nick already in use"}, http.StatusConflict)
w, r, "nick already in use",
http.StatusConflict,
)
return return
} }
s.internalError(w, r, "change nick failed", err) s.log.Error("change nick failed", "error", err)
s.respondJSON(w, r, map[string]string{"error": "internal error"}, http.StatusInternalServerError)
return return
} }
s.respondJSON( s.respondJSON(w, r, map[string]string{"status": "ok", "nick": newNick}, http.StatusOK)
w, r,
map[string]string{"status": "ok", "nick": newNick},
http.StatusOK,
)
} }
func (s *Handlers) handleTopic( func (s *Handlers) handleTopic(w http.ResponseWriter, r *http.Request, uid, to string, lines []string) {
w http.ResponseWriter, if to == "" {
r *http.Request, s.respondJSON(w, r, map[string]string{"error": "to field required"}, http.StatusBadRequest)
uid int64,
req *sendRequest,
) {
if req.To == "" {
s.respondError(
w, r, "to field required",
http.StatusBadRequest,
)
return return
} }
lines := bodyLines(req.Body)
if len(lines) == 0 { if len(lines) == 0 {
s.respondError( s.respondJSON(w, r, map[string]string{"error": "body required (topic text)"}, http.StatusBadRequest)
w, r, "body required (topic text)",
http.StatusBadRequest,
)
return return
} }
topic := strings.Join(lines, " ") topic := strings.Join(lines, " ")
channel := req.To channel := to
if !strings.HasPrefix(channel, "#") { if !strings.HasPrefix(channel, "#") {
channel = "#" + channel channel = "#" + channel
} }
err := s.params.Database.SetTopic( err := s.params.Database.SetTopic(r.Context(), channel, uid, topic)
r.Context(), channel, uid, topic,
)
if err != nil { if err != nil {
s.internalError(w, r, "set topic failed", err) s.log.Error("set topic failed", "error", err)
s.respondJSON(w, r, map[string]string{"error": "internal error"}, http.StatusInternalServerError)
return return
} }
s.respondJSON( s.respondJSON(w, r, map[string]string{"status": "ok", "topic": topic}, http.StatusOK)
w, r,
map[string]string{"status": "ok", "topic": topic},
http.StatusOK,
)
} }
// HandleGetHistory returns message history for a specific // HandleGetHistory returns message history for a specific target (channel or DM).
// target (channel or DM).
func (s *Handlers) HandleGetHistory() http.HandlerFunc { func (s *Handlers) HandleGetHistory() http.HandlerFunc {
return func(w http.ResponseWriter, r *http.Request) { return func(w http.ResponseWriter, r *http.Request) {
uid, _, ok := s.requireAuth(w, r) uid, _, ok := s.requireAuth(w, r)
@@ -677,65 +499,47 @@ func (s *Handlers) HandleGetHistory() http.HandlerFunc {
target := r.URL.Query().Get("target") target := r.URL.Query().Get("target")
if target == "" { if target == "" {
s.respondError( s.respondJSON(w, r, map[string]string{"error": "target required"}, http.StatusBadRequest)
w, r, "target required",
http.StatusBadRequest,
)
return return
} }
beforeID, _ := strconv.ParseInt( beforeTS := r.URL.Query().Get("before")
r.URL.Query().Get("before"), 10, 64, limit, _ := strconv.Atoi(r.URL.Query().Get("limit"))
)
limit, _ := strconv.Atoi(
r.URL.Query().Get("limit"),
)
if limit <= 0 { if limit <= 0 {
limit = defaultHistory limit = 50
} }
if strings.HasPrefix(target, "#") { if strings.HasPrefix(target, "#") {
s.getChannelHistory( s.getChannelHistory(w, r, target, beforeTS, limit)
w, r, target, beforeID, limit,
) return
} else {
s.getDMHistory(
w, r, uid, target, beforeID, limit,
)
} }
s.getDMHistory(w, r, uid, target, beforeTS, limit)
} }
} }
func (s *Handlers) getChannelHistory( func (s *Handlers) getChannelHistory(
w http.ResponseWriter, w http.ResponseWriter, r *http.Request,
r *http.Request, channel, beforeTS string, limit int,
target string,
beforeID int64,
limit int,
) { ) {
var chID int64 var chID string
err := s.params.Database.GetDB().QueryRowContext( //nolint:gosec // parameterized query //nolint:gosec // G701: parameterized query, not injection
r.Context(), err := s.params.Database.GetDB().QueryRowContext(r.Context(),
"SELECT id FROM channels WHERE name = ?", "SELECT id FROM channels WHERE name = ?", channel).Scan(&chID)
target,
).Scan(&chID)
if err != nil { if err != nil {
s.respondError( s.respondJSON(w, r, map[string]string{"error": "channel not found"}, http.StatusNotFound)
w, r, "channel not found",
http.StatusNotFound,
)
return return
} }
msgs, err := s.params.Database.GetMessagesBefore( msgs, err := s.params.Database.GetMessagesBefore(r.Context(), chID, beforeTS, limit)
r.Context(), chID, beforeID, limit,
)
if err != nil { if err != nil {
s.internalError(w, r, "get history failed", err) s.log.Error("get history failed", "error", err)
s.respondJSON(w, r, map[string]string{"error": "internal error"}, http.StatusInternalServerError)
return return
} }
@@ -744,31 +548,20 @@ func (s *Handlers) getChannelHistory(
} }
func (s *Handlers) getDMHistory( func (s *Handlers) getDMHistory(
w http.ResponseWriter, w http.ResponseWriter, r *http.Request,
r *http.Request, uid, target, beforeTS string, limit int,
uid int64,
target string,
beforeID int64,
limit int,
) { ) {
targetID, err := s.params.Database.GetUserByNick( targetUser, err := s.params.Database.GetUserByNick(r.Context(), target)
r.Context(), target,
)
if err != nil { if err != nil {
s.respondError( s.respondJSON(w, r, map[string]string{"error": "user not found"}, http.StatusNotFound)
w, r, "user not found", http.StatusNotFound,
)
return return
} }
msgs, err := s.params.Database.GetDMsBefore( msgs, err := s.params.Database.GetDMsBefore(r.Context(), uid, targetUser.ID, beforeTS, limit)
r.Context(), uid, targetID, beforeID, limit,
)
if err != nil { if err != nil {
s.internalError( s.log.Error("get dm history failed", "error", err)
w, r, "get dm history failed", err, s.respondJSON(w, r, map[string]string{"error": "internal error"}, http.StatusInternalServerError)
)
return return
} }

View File

@@ -9,6 +9,13 @@ import (
"errors" "errors"
) )
var (
// ErrUserLookupNotAvailable is returned when the user lookup interface is not set.
ErrUserLookupNotAvailable = errors.New("user lookup not available")
// ErrChannelLookupNotAvailable is returned when the channel lookup interface is not set.
ErrChannelLookupNotAvailable = errors.New("channel lookup not available")
)
// DB is the interface that models use to query the database. // DB is the interface that models use to query the database.
// This avoids a circular import with the db package. // This avoids a circular import with the db package.
type DB interface { type DB interface {
@@ -25,12 +32,6 @@ type ChannelLookup interface {
GetChannelByID(ctx context.Context, id string) (*Channel, error) GetChannelByID(ctx context.Context, id string) (*Channel, error)
} }
// Sentinel errors for model lookup methods.
var (
ErrUserLookupNotAvailable = errors.New("user lookup not available")
ErrChannelLookupNotAvailable = errors.New("channel lookup not available")
)
// Base is embedded in all model structs to provide database access. // Base is embedded in all model structs to provide database access.
type Base struct { type Base struct {
db DB db DB
@@ -47,7 +48,7 @@ func (b *Base) GetDB() *sql.DB {
} }
// GetUserLookup returns the DB as a UserLookup if it implements the interface. // GetUserLookup returns the DB as a UserLookup if it implements the interface.
func (b *Base) GetUserLookup() UserLookup { //nolint:ireturn func (b *Base) GetUserLookup() UserLookup { //nolint:ireturn // intentional interface return for dependency inversion
if ul, ok := b.db.(UserLookup); ok { if ul, ok := b.db.(UserLookup); ok {
return ul return ul
} }
@@ -55,8 +56,11 @@ func (b *Base) GetUserLookup() UserLookup { //nolint:ireturn
return nil return nil
} }
// GetChannelLookup returns the DB as a ChannelLookup if it implements the interface. // GetChannelLookup returns the DB as a ChannelLookup
func (b *Base) GetChannelLookup() ChannelLookup { //nolint:ireturn // if it implements the interface.
//
//nolint:ireturn // intentional interface return for dependency inversion
func (b *Base) GetChannelLookup() ChannelLookup {
if cl, ok := b.db.(ChannelLookup); ok { if cl, ok := b.db.(ChannelLookup); ok {
return cl return cl
} }

View File

@@ -65,33 +65,27 @@ func (s *Server) SetupRoutes() {
r.Get("/channels/{channel}/members", s.h.HandleChannelMembers()) r.Get("/channels/{channel}/members", s.h.HandleChannelMembers())
}) })
// Serve embedded SPA s.setupSPA()
}
func (s *Server) setupSPA() {
distFS, err := fs.Sub(web.Dist, "dist") distFS, err := fs.Sub(web.Dist, "dist")
if err != nil { if err != nil {
s.log.Error("failed to get web dist filesystem", "error", err) s.log.Error("failed to get web dist filesystem", "error", err)
} else {
fileServer := http.FileServer(http.FS(distFS))
s.router.Get("/*", func(w http.ResponseWriter, r *http.Request) {
s.serveSPA(distFS, fileServer, w, r)
})
}
}
func (s *Server) serveSPA(
distFS fs.FS,
fileServer http.Handler,
w http.ResponseWriter,
r *http.Request,
) {
readFS, ok := distFS.(fs.ReadFileFS)
if !ok {
http.Error(w, "filesystem error", http.StatusInternalServerError)
return return
} }
// Try to serve the file; fall back to index.html for SPA routing. fileServer := http.FileServer(http.FS(distFS))
s.router.Get("/*", func(w http.ResponseWriter, r *http.Request) {
readFS, ok := distFS.(fs.ReadFileFS)
if !ok {
http.Error(w, "internal error", http.StatusInternalServerError)
return
}
f, err := readFS.ReadFile(r.URL.Path[1:]) f, err := readFS.ReadFile(r.URL.Path[1:])
if err != nil || len(f) == 0 { if err != nil || len(f) == 0 {
indexHTML, _ := readFS.ReadFile("index.html") indexHTML, _ := readFS.ReadFile("index.html")
@@ -104,4 +98,5 @@ func (s *Server) serveSPA(
} }
fileServer.ServeHTTP(w, r) fileServer.ServeHTTP(w, r)
})
} }