From e0da78f17cbca5ae9c6f99b7730e9f2c3ef26b76 Mon Sep 17 00:00:00 2001 From: user Date: Fri, 20 Feb 2026 03:26:06 -0800 Subject: [PATCH] fix: resolve wsl_v5, lll, noinlineerr, and gosec lint issues --- cmd/chat-cli/api/client.go | 2 +- internal/db/db.go | 4 +++- internal/handlers/api.go | 5 +++++ internal/models/model.go | 7 +++++-- 4 files changed, 14 insertions(+), 4 deletions(-) diff --git a/cmd/chat-cli/api/client.go b/cmd/chat-cli/api/client.go index 66836ee..b014491 100644 --- a/cmd/chat-cli/api/client.go +++ b/cmd/chat-cli/api/client.go @@ -114,7 +114,7 @@ func (c *Client) PollMessages(afterID string, timeout int) ([]Message, error) { req.Header.Set("Authorization", "Bearer "+c.Token) - resp, err := client.Do(req) + resp, err := client.Do(req) //nolint:gosec // G704: BaseURL is set by user at connect time, not tainted input if err != nil { return nil, err } diff --git a/internal/db/db.go b/internal/db/db.go index cf4376f..406fd0b 100644 --- a/internal/db/db.go +++ b/internal/db/db.go @@ -88,7 +88,8 @@ func NewTest(dsn string) (*Database, error) { } // Item 9: Enable foreign keys - if _, err := d.ExecContext(context.Background(), "PRAGMA foreign_keys = ON"); err != nil { + _, err = d.ExecContext(context.Background(), "PRAGMA foreign_keys = ON") + if err != nil { _ = d.Close() return nil, fmt.Errorf("enable foreign keys: %w", err) @@ -434,6 +435,7 @@ func (s *Database) AckMessages( args[i] = id } + //nolint:gosec // G201: placeholders are all "?" literals, not user input query := fmt.Sprintf( "DELETE FROM message_queue WHERE id IN (%s)", strings.Join(placeholders, ","), diff --git a/internal/handlers/api.go b/internal/handlers/api.go index bbf3b1f..7182105 100644 --- a/internal/handlers/api.go +++ b/internal/handlers/api.go @@ -64,6 +64,7 @@ func (s *Handlers) HandleCreateSession() http.HandlerFunc { return func(w http.ResponseWriter, r *http.Request) { var req request + err := json.NewDecoder(r.Body).Decode(&req) if err != nil { s.respondJSON(w, r, map[string]string{"error": "invalid request"}, http.StatusBadRequest) @@ -166,6 +167,7 @@ func (s *Handlers) HandleChannelMembers() http.HandlerFunc { var chID string + //nolint:gosec // G701: parameterized query with ? placeholder, not injection err := s.params.Database.GetDB().QueryRowContext(r.Context(), "SELECT id FROM channels WHERE name = ?", name).Scan(&chID) if err != nil { @@ -304,6 +306,7 @@ func (s *Handlers) handlePrivmsg(w http.ResponseWriter, r *http.Request, uid, ni // Channel message. var chID string + //nolint:gosec // G701: parameterized query, not injection err := s.params.Database.GetDB().QueryRowContext(r.Context(), "SELECT id FROM channels WHERE name = ?", to).Scan(&chID) if err != nil { @@ -387,6 +390,7 @@ func (s *Handlers) handlePart(w http.ResponseWriter, r *http.Request, uid, to st var chID string + //nolint:gosec // G701: parameterized query, not injection err := s.params.Database.GetDB().QueryRowContext(r.Context(), "SELECT id FROM channels WHERE name = ?", channel).Scan(&chID) if err != nil { @@ -494,6 +498,7 @@ func (s *Handlers) HandleGetHistory() http.HandlerFunc { // Channel history — look up channel by name to get its ID for target matching. var chID string + //nolint:gosec // G701: parameterized query, not injection err := s.params.Database.GetDB().QueryRowContext(r.Context(), "SELECT id FROM channels WHERE name = ?", target).Scan(&chID) if err != nil { diff --git a/internal/models/model.go b/internal/models/model.go index 68739cd..103934b 100644 --- a/internal/models/model.go +++ b/internal/models/model.go @@ -56,8 +56,11 @@ func (b *Base) GetUserLookup() UserLookup { //nolint:ireturn // intentional inte return nil } -// GetChannelLookup returns the DB as a ChannelLookup if it implements the interface. -func (b *Base) GetChannelLookup() ChannelLookup { //nolint:ireturn // intentional interface return for dependency inversion +// GetChannelLookup returns the DB as a ChannelLookup +// if it implements the interface. +// +//nolint:ireturn // intentional interface return for dependency inversion +func (b *Base) GetChannelLookup() ChannelLookup { if cl, ok := b.db.(ChannelLookup); ok { return cl }