fix: resolve nlreturn, modernize, perfsprint, wsl_v5, and partial err113 lint issues

cmd/chat-cli/api/client.go

@@ -5,6 +5,7 @@ import (
 	"encoding/json"
 	"fmt"
 	"io"
+	"strconv"
 	"net/http"
 	"net/url"
 	"time"
@@ -27,13 +28,15 @@ func NewClient(baseURL string) *Client {
 	}
 }
 
-func (c *Client) do(method, path string, body interface{}) ([]byte, error) {
+func (c *Client) do(method, path string, body any) ([]byte, error) {
 	var bodyReader io.Reader
+
 	if body != nil {
 		data, err := json.Marshal(body)
 		if err != nil {
 			return nil, fmt.Errorf("marshal: %w", err)
 		}
+
 		bodyReader = bytes.NewReader(data)
 	}
 
@@ -41,7 +44,9 @@ func (c *Client) do(method, path string, body interface{}) ([]byte, error) {
 	if err != nil {
 		return nil, fmt.Errorf("request: %w", err)
 	}
+
 	req.Header.Set("Content-Type", "application/json")
+
 	if c.Token != "" {
 		req.Header.Set("Authorization", "Bearer "+c.Token)
 	}
@@ -70,11 +75,14 @@ func (c *Client) CreateSession(nick string) (*SessionResponse, error) {
 	if err != nil {
 		return nil, err
 	}
+
 	var resp SessionResponse
 	if err := json.Unmarshal(data, &resp); err != nil {
 		return nil, fmt.Errorf("decode session: %w", err)
 	}
+
 	c.Token = resp.Token
+
 	return &resp, nil
 }
 
@@ -84,16 +92,19 @@ func (c *Client) GetState() (*StateResponse, error) {
 	if err != nil {
 		return nil, err
 	}
+
 	var resp StateResponse
 	if err := json.Unmarshal(data, &resp); err != nil {
 		return nil, fmt.Errorf("decode state: %w", err)
 	}
+
 	return &resp, nil
 }
 
 // SendMessage sends a message (any IRC command).
 func (c *Client) SendMessage(msg *Message) error {
 	_, err := c.do("POST", "/api/v1/messages", msg)
+
 	return err
 }
 
@@ -106,17 +117,19 @@ func (c *Client) PollMessages(afterID string, timeout int) ([]Message, error) {
 	if afterID != "" {
 		params.Set("after", afterID)
 	}
-	params.Set("timeout", fmt.Sprintf("%d", timeout))
+
+	params.Set("timeout", strconv.Itoa(timeout))
 
 	path := "/api/v1/messages"
 	if len(params) > 0 {
 		path += "?" + params.Encode()
 	}
 
-	req, err := http.NewRequest("GET", c.BaseURL+path, nil)
+	req, err := http.NewRequest(http.MethodGet, c.BaseURL+path, nil)
 	if err != nil {
 		return nil, err
 	}
+
 	req.Header.Set("Authorization", "Bearer "+c.Token)
 
 	resp, err := client.Do(req)
@@ -139,9 +152,11 @@ func (c *Client) PollMessages(afterID string, timeout int) ([]Message, error) {
 	if err := json.Unmarshal(data, &msgs); err != nil {
 		// Try wrapped format.
 		var wrapped MessagesResponse
-		if err2 := json.Unmarshal(data, &wrapped); err2 != nil {
+		err2 := json.Unmarshal(data, &wrapped)
+		if err2 != nil {
 			return nil, fmt.Errorf("decode messages: %w (raw: %s)", err, string(data))
 		}
+
 		msgs = wrapped.Messages
 	}
 
@@ -164,10 +179,12 @@ func (c *Client) ListChannels() ([]Channel, error) {
 	if err != nil {
 		return nil, err
 	}
+
 	var channels []Channel
 	if err := json.Unmarshal(data, &channels); err != nil {
 		return nil, err
 	}
+
 	return channels, nil
 }
 
@@ -177,16 +194,19 @@ func (c *Client) GetMembers(channel string) ([]string, error) {
 	if err != nil {
 		return nil, err
 	}
+
 	var members []string
 	if err := json.Unmarshal(data, &members); err != nil {
 		// Try object format.
-		var obj map[string]interface{}
-		if err2 := json.Unmarshal(data, &obj); err2 != nil {
+		var obj map[string]any
+		err2 := json.Unmarshal(data, &obj)
+		if err2 != nil {
 			return nil, err
 		}
 		// Extract member names from whatever format.
 		return nil, fmt.Errorf("unexpected members format: %s", string(data))
 	}
+
 	return members, nil
 }
 
@@ -196,9 +216,11 @@ func (c *Client) GetServerInfo() (*ServerInfo, error) {
 	if err != nil {
 		return nil, err
 	}
+
 	var info ServerInfo
 	if err := json.Unmarshal(data, &info); err != nil {
 		return nil, err
 	}
+
 	return &info, nil
 }

cmd/chat-cli/api/types.go

@@ -25,26 +25,27 @@ type StateResponse struct {
 
 // Message represents a chat message envelope.
 type Message struct {
-	Command string      `json:"command"`
-	From    string      `json:"from,omitempty"`
-	To      string      `json:"to,omitempty"`
-	Params  []string    `json:"params,omitempty"`
-	Body    interface{} `json:"body,omitempty"`
-	ID      string      `json:"id,omitempty"`
-	TS      string      `json:"ts,omitempty"`
-	Meta    interface{} `json:"meta,omitempty"`
+	Command string   `json:"command"`
+	From    string   `json:"from,omitempty"`
+	To      string   `json:"to,omitempty"`
+	Params  []string `json:"params,omitempty"`
+	Body    any      `json:"body,omitempty"`
+	ID      string   `json:"id,omitempty"`
+	TS      string   `json:"ts,omitempty"`
+	Meta    any      `json:"meta,omitempty"`
 }
 
 // BodyLines returns the body as a slice of strings (for text messages).
 func (m *Message) BodyLines() []string {
 	switch v := m.Body.(type) {
-	case []interface{}:
+	case []any:
 		lines := make([]string, 0, len(v))
 		for _, item := range v {
 			if s, ok := item.(string); ok {
 				lines = append(lines, s)
 			}
 		}
+
 		return lines
 	case []string:
 		return v
@@ -79,5 +80,6 @@ func (m *Message) ParseTS() time.Time {
 	if err != nil {
 		return time.Now()
 	}
+
 	return t
 }