Files

check / check (push) Successful in 29s

Details

security: make DEBUG a build-time flag defaulting to off (closes #149 )

DEBUG was hardcoded to true in src/shared/constants.js, so every wallet
created from a build of main received the publicly committed test recovery
phrase and was instantly drainable. There was no way to produce a non-debug
build at all: the real entropy path in generateMnemonic() was dead code in
every artifact.

DEBUG is now a build-time constant injected by esbuild's define in build.js,
alongside the existing __BUILD_* defines, and read by constants.js with the
same typeof guard buildInfo.js uses. It is false unless the build was run
with AUTISTMASK_DEBUG=1 — an exact match, so an unset, empty or mistyped
value fails safe towards a release build. The build prints which mode it
used, and make build-debug is a shim for the debug case.

What DEBUG does when enabled is unchanged: the red banner plus the hardcoded
test phrase, no new conditionals. Mnemonic generation deliberately keeps
reading the compile-time constant rather than isDebug() from log.js, which
also ORs in the runtime debugMode flag the settings toggle drives; routing it
through isDebug() would let a user of a release build re-enable the known
test phrase for real wallets. That is now recorded at the call site, in the
README DEBUG Mode Policy, and covered by a regression test.

New tests/wallet.test.js covers both build modes: with the flag off, two
successive generateMnemonic() calls differ, both validate as BIP-39 phrases,
both are 12 words, neither is DEBUG_MNEMONIC, and the result still derives a
usable HD wallet — including with the runtime toggle forced on. With the flag
on, DEBUG is true and the test phrase is returned, so the debug path stays
proven rather than silently removed.

Verified with make check (55 tests, lint, fmt-check all green), and with
make build and make build-debug: all four bundles across dist/chrome and
dist/firefox export DEBUG:!1 in a release build and DEBUG:!0 in a debug
build, and AUTISTMASK_DEBUG=true likewise yields DEBUG:!1.

2026-08-09 01:55:13 +00:00

4.1 KiB

Raw Blame History

Workflow

branch (from main)
do the work in Next Step
move Next Step to the top of Completed Steps
move the top item of Future Steps into Next Step
commit (TODO.md changes in the same commit as the work)
merge to main if the branch is not protected, otherwise open a PR
push

Status

pre-1.0, working towards the 1.0.0 milestone. Tagged v0.1.0 on 2026-02-27. No other branch is in flight: the settings About well landed as #145 on 2026-07-26 and scripts-to-rule-them-all landed as #148, so the scripts/ directory question is resolved. Full policy file set present. make check verified passing on main at 23aeae4 on 2026-08-09. The 1.0.0 backlog is filed as #149-#168.

Next Step

Land #149: make DEBUG a build-time constant that defaults to off, injected as the __BUILD_DEBUG__ esbuild define from AUTISTMASK_DEBUG=1, so a plain make build stops handing every newly created wallet the publicly committed test recovery phrase. Branch fix/issue-149-debug-build-flag; PR open, awaiting review.

Completed Steps

2026-08-09: Reviewed the repo end to end and filed the 1.0.0 backlog (#149-#168).
2026-07-26: About well in settings with build info, repo link and the version click easter egg (#145); proper view navigation stack (#146).
2026-07-07 Adopted scripts-to-rule-them-all: script/ entrypoints, Makefile shims, README Entrypoints section (#148)
2026-03-01: USD display suppressed on testnets (#142); estimated USD for ETH in approve-tx view (#141).
Sepolia testnet support (#137); etherscan links go to token-specific URLs (#136).
Transaction detail improvements: Type field and on-chain details (#130), txid-first reordering (#133), swap display corrections (#128), expanded confirm-tx warnings (#118).
Dark mode theme setting (Light/Dark/System) with contrast fixes (#126); timestamps include timezone offset (#120); layout shift audit, reserved space for error messages (#124).
Copy-flash visual feedback with timing tune (#113, #121); cross-wallet-type duplicate detection (#115).
2026-02-27: v0.1.0 tagged.
2026-02-24: Initial scaffolding: popup UI, BIP-39 wallet creation via ethers.js, wallet persistence, real ETH balances over RPC, ENS forward and reverse resolution.

Future Steps

Fix the two ReferenceError crashes that make whole screens unreachable: AddToken (#150) and TransactionDetail for every ERC-20 transfer (#151).
Add ESLint to script/lint (#152). make check is prettier --check only and cannot catch undefined identifiers, which is how #150 and #151 shipped.
Make the Firefox target functional: Chrome callback APIs are used against the promise-only browser namespace (#153).
Send and transaction-flow correctness: gas fee excluded from the insufficient-balance check (#154), WaitTx 60s timeout overwriting a rendered success screen (#155), last-wallet deletion leaving inconsistent state (#156).
Security: plaintext password crossing the extension messaging boundary during dApp approvals (#157); MV3 service worker termination killing the background refresh and the 24h phishing list update (#158).
Test the crypto core — wallet.js derivation and vault.js encryption (#159) — and the address-poisoning defense in transactions.js (#160).
Wallet features for 1.0: show a wallet's recovery phrase behind the password (#161), delete an address from an HD wallet (#162).
Docs: docs/README.md contradicts the code on external services and names competitors (#163); README Screen Map omits three shipped screens (#164).
Owner decisions: Sepolia support versus "Non-Goals for 1.0", and isMetaMask naming a competitor in shipped code (#165).
Repo policy compliance sweep: test rerun pattern, yarn/npx, frozen lockfile, undocumented Makefile targets (#166).
Prune the 24 stale remote feature branches (#167).
Remove dead exports and de-duplicate copy-pasted view helpers (#168).
Pre-1.0 security review of the extension (key handling, DEBUG mode policy, RPC input validation) before any 1.0rc tag; #149 and #157 are parts of it, but the review is broader than either.
Cut 1.0.0 once the milestone is empty, then continue tagging as milestones land.