([^<]*)<\/span><\/span>/)[1];
+}
+
+// The popup on Home over one address holding `eth` ETH and `usdc` USDC.
+function bootHolding(eth, usdc) {
+ const profile = unversionedValidProfile({
+ trackedTokens: [{ address: USDC, symbol: "USDC", decimals: 6 }],
+ });
+ profile.wallets[0].addresses[0] = {
+ address: ADDRESS,
+ balance: eth,
+ tokenBalances: [
+ { address: USDC, symbol: "USDC", decimals: 6, balance: usdc },
+ ],
+ };
+ return bootPopup(profile);
+}
+
+// The balance row for `token` in Home's wallet list.
+function homeRow(page, token) {
+ return page
+ .node("wallet-list")
+ .innerHTML.split(" row.includes('data-token="' + token + '"'));
+}
+
+describe("balanceLine", () => {
+ test("cuts 0.99996 to 0.9999, never rounding it up to 1.0000", () => {
+ expect(quantity(balanceLine("ETH", "0.99996", null, "ETH"))).toBe(
+ "0.9999",
+ );
+ });
+
+ test("cuts 0.00004 to 0.0000", () => {
+ expect(quantity(balanceLine("USDC", "0.00004", null, USDC))).toBe(
+ "0.0000",
+ );
+ });
+});
+
+describe("Home", () => {
+ test("the ETH line and the balance list read 0.99996 ETH as 0.9999", async () => {
+ const page = await bootHolding("0.99996", "0.00004");
+
+ expect(page.visibleViews()).toEqual(["main"]);
+ expect(page.text("total-value")).toBe("0.9999 ETH");
+ expect(quantity(homeRow(page, "ETH"))).toBe("0.9999");
+ });
+
+ test("the balance list reads 0.00004 USDC as 0.0000", async () => {
+ const page = await bootHolding("0.99996", "0.00004");
+
+ expect(quantity(homeRow(page, USDC.toLowerCase()))).toBe("0.0000");
+ });
+});
diff --git a/tests/deleteAddress.test.js b/tests/deleteAddress.test.js
index 42b157a..b9061a7 100644
--- a/tests/deleteAddress.test.js
+++ b/tests/deleteAddress.test.js
@@ -4,8 +4,8 @@
// the copy is the substance and is tested as such. Two things it must not
// get wrong: what it takes to get the address back — the app refuses both
// obvious routes — and what counts as holding something, which is any
-// ERC-20 as well as ETH, at any size, including a balance that rounds to
-// zero at the four decimals the balance lines render. The DOM behaviour
+// ERC-20 as well as ETH, at any size, including a balance below the four
+// decimals the balance lines render. The DOM behaviour
// around them is driven against the real popup by tests/e2e/run.js.
// helpers.js pulls in state.js, which reads chrome.storage.local at load.
diff --git a/tests/e2e/run.js b/tests/e2e/run.js
index eaab238..634c6ea 100644
--- a/tests/e2e/run.js
+++ b/tests/e2e/run.js
@@ -829,12 +829,11 @@ test("a common-token quick-pick fills in the contract address (#150)", async (en
await visible(env.page, "#view-address");
});
-// The native amount as the transaction list writes it (four decimals) and
-// as the detail screen writes it (full precision). Both are rendered here
-// from the fixture rather than read off the screen, so the assertions
-// compare against the wei the stub served.
-const NATIVE_ROW_TEXT =
- parseFloat(formatEther(STUB_NATIVE_VALUE_WEI)).toFixed(4) + " ETH";
+// The native amount as the transaction list writes it (cut to four decimals,
+// quantity() below) and as the detail screen writes it (full precision). Both
+// are rendered here from the fixture rather than read off the screen, so the
+// assertions compare against the wei the stub served.
+const NATIVE_ROW_TEXT = quantity(STUB_NATIVE_VALUE_WEI) + " ETH";
const NATIVE_DETAIL_TEXT = formatEther(STUB_NATIVE_VALUE_WEI) + " ETH";
test("the native ETH transaction detail still renders (#151)", async (env) => {
@@ -2724,10 +2723,11 @@ async function goToConfirm(page, send) {
await assertAddressesFit(page, "the confirmation screen");
}
-// A balance as the main view renders it: balanceLinesForAddress() writes
-// every quantity with four decimal places.
+// An amount in wei as the main view's balance lines and the transaction list
+// write it: cut to four decimal places, never rounded, as feeEth() does.
function quantity(wei) {
- return parseFloat(formatEther(wei)).toFixed(4);
+ const [whole, frac = ""] = formatEther(wei).split(".");
+ return whole + "." + (frac + "0000").slice(0, 4);
}
// Wait on the main view until a changed balance fixture has been picked up.
diff --git a/tests/transactions.test.js b/tests/transactions.test.js
index 631aa70..4b05357 100644
--- a/tests/transactions.test.js
+++ b/tests/transactions.test.js
@@ -1361,6 +1361,31 @@ describe("fetchRecentTransactions merge and dedup", () => {
expect(txs[0].holders).toBe(3500000);
});
+ // README.md, Amounts: a history row cuts to four decimals, with no floor.
+ test("a token transfer below 0.0001 reads 0.0000", async () => {
+ respondWith(
+ [],
+ [
+ {
+ transaction_hash: "0x" + "4".repeat(64),
+ block_number: 21000040,
+ timestamp: TS,
+ from: { hash: ORDINARY_PEER },
+ to: { hash: VICTIM },
+ total: { value: "40", decimals: "6" },
+ token: {
+ symbol: "USDC",
+ address_hash: USDC_CONTRACT,
+ holders_count: "3500000",
+ },
+ },
+ ],
+ );
+
+ const txs = await fetchRecentTransactions(VICTIM, BLOCKSCOUT, "0x1");
+ expect(txs[0].value).toBe("0.0000");
+ });
+
test("two transfers of the same token in one transaction collapse to one entry", async () => {
const hash = "0x" + "3".repeat(64);
const leg = (value) => ({
diff --git a/tests/unknownScaleDisplay.test.js b/tests/unknownScaleDisplay.test.js
index e83be6e..e054f0a 100644
--- a/tests/unknownScaleDisplay.test.js
+++ b/tests/unknownScaleDisplay.test.js
@@ -96,7 +96,7 @@ afterEach(() => {
describe("balanceLine", () => {
test("an unknown quantity and a zero one render differently", () => {
const unknown = balanceLine("NOVEL", null, null, NOVEL);
- const zero = balanceLine("NOVEL", 0, null, NOVEL);
+ const zero = balanceLine("NOVEL", "0", null, NOVEL);
expect(unknown).not.toBe(zero);
expect(quantities(unknown)).toEqual(["NOVEL", "quantity unknown"]);
expect(quantities(zero)).toEqual(["NOVEL", "0.0000"]);
@@ -105,7 +105,7 @@ describe("balanceLine", () => {
test("an unknown quantity produces no fiat figure, a zero one does", () => {
prices[NOVEL] = 3;
const unknown = balanceLine("NOVEL", null, 3, NOVEL);
- const zero = balanceLine("NOVEL", 0, 3, NOVEL);
+ const zero = balanceLine("NOVEL", "0", 3, NOVEL);
// A price times an unknown quantity is not $0.00: that is the same
// claim of "nothing here" the quantity cell just refused to make.
expect(unknown).toContain(