the block number on 'success-tx' should have an external link to uniswap, and should be click-to-copyable #99
Labels
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: sneak/AutistMask#99
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
the block number is a blockchain entity available on etherscan just like addresses and txids. it should be displayed as similarly as possible - click to copy, external site link suffix, everything. this is the kind of thing i mean when i say consistency. logical consistency that results in similar treatment of similar concepts.
go through the entire codebase carefully and make a list of each atom of data we display anywhere in any view, and how it's styled, and what it represents. group them into ways of being styled, and see what falls out.
PR #107 addresses this. Block number on success-tx now has click-to-copy and an external link to etherscan.io/block/, consistent with how addresses and tx hashes are styled throughout the extension.
Full audit of all blockchain data atoms confirmed consistent treatment across all views.