SuccessTx: isRenderableDecoded() in src/popup/viewRouter.js, success-tx-summary in src/popup/index.html, and decodedAddressHtml() in src/popup/views/txStatus.js.
isRenderableDecoded() still refuses saved records that decodedDetailsHtml() now handles. Reopening the popup on such a SuccessTx shows the main view, and the function's comment on what decodedDetailsHtml() needs is false.
success-tx-summary has no wrap class, so a long amount is cut off at the screen's edge.
The symbol on the Allowance token line has no wrap class, so a long symbol is cut off on WaitTx, ErrorTx and SuccessTx.
What should happen
A saved SuccessTx reopens as itself. No amount or symbol is cut off with no sign of it.
Severity: minor
Definition of done
isRenderableDecoded() and its call in the success-tx case are gone. A Jest test reopens the popup on such a record, failing on next.
break-words on success-tx-summary and on the symbol's div in decodedAddressHtml().
Model: opus-5-5
## Where
SuccessTx: `isRenderableDecoded()` in `src/popup/viewRouter.js`, `success-tx-summary` in `src/popup/index.html`, and `decodedAddressHtml()` in `src/popup/views/txStatus.js`.
## What happens
Found by the review of https://git.eeqj.de/sneak/AutistMask/pulls/739.
- `isRenderableDecoded()` still refuses saved records that `decodedDetailsHtml()` now handles. Reopening the popup on such a SuccessTx shows the main view, and the function's comment on what `decodedDetailsHtml()` needs is false.
- `success-tx-summary` has no wrap class, so a long amount is cut off at the screen's edge.
- The symbol on the `Allowance token` line has no wrap class, so a long symbol is cut off on WaitTx, ErrorTx and SuccessTx.
## What should happen
A saved SuccessTx reopens as itself. No amount or symbol is cut off with no sign of it.
Severity: minor
## Definition of done
- [ ] `isRenderableDecoded()` and its call in the `success-tx` case are gone. A Jest test reopens the popup on such a record, failing on `next`.
- [ ] `break-words` on `success-tx-summary` and on the symbol's `div` in `decodedAddressHtml()`.
Model: opus-5-5
clawbot
self-assigned this 2026-11-03 10:14:09 +01:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Where
SuccessTx:
isRenderableDecoded()insrc/popup/viewRouter.js,success-tx-summaryinsrc/popup/index.html, anddecodedAddressHtml()insrc/popup/views/txStatus.js.What happens
Found by the review of #739.
isRenderableDecoded()still refuses saved records thatdecodedDetailsHtml()now handles. Reopening the popup on such a SuccessTx shows the main view, and the function's comment on whatdecodedDetailsHtml()needs is false.success-tx-summaryhas no wrap class, so a long amount is cut off at the screen's edge.Allowance tokenline has no wrap class, so a long symbol is cut off on WaitTx, ErrorTx and SuccessTx.What should happen
A saved SuccessTx reopens as itself. No amount or symbol is cut off with no sign of it.
Severity: minor
Definition of done
isRenderableDecoded()and its call in thesuccess-txcase are gone. A Jest test reopens the popup on such a record, failing onnext.break-wordsonsuccess-tx-summaryand on the symbol'sdivindecodedAddressHtml().Model: opus-5-5