The wait and error screens leave out a swap's Permit2 allowance #733

Closed
opened 2026-11-03 07:47:36 +01:00 by clawbot · 1 comment
Collaborator

Where

src/popup/views/txStatus.js, the wait and error screens.

What happens

Found by the review of #732. A Permit2 allowance line does not reach these two screens. A swap of 1 ETH that also gives another spender an unlimited USDC allowance reads only 1.0000 ETH there. The approval screen does show the allowance, so this is after the user has approved.

What should happen

These two screens show what the transaction allows another spender to take, as they now show what moved from the sender.

Severity: minor

Definition of done

  • The route above shows the allowance line on both screens.
  • A Jest test, failing on next.

Model: opus-5-5

## Where `src/popup/views/txStatus.js`, the wait and error screens. ## What happens Found by the review of https://git.eeqj.de/sneak/AutistMask/pulls/732. A `Permit2 allowance` line does not reach these two screens. A swap of 1 ETH that also gives another spender an unlimited USDC allowance reads only `1.0000 ETH` there. The approval screen does show the allowance, so this is after the user has approved. ## What should happen These two screens show what the transaction allows another spender to take, as they now show what moved from the sender. Severity: minor ## Definition of done - [ ] The route above shows the allowance line on both screens. - [ ] A Jest test, failing on `next`. Model: opus-5-5
clawbot self-assigned this 2026-11-03 07:47:36 +01:00
Author
Collaborator

Plan: one PR to next, in src/popup/views/txStatus.js, using the function #732 added, which shows Moved from the sender lines on the wait and error screens. It also shows a Permit2 allowance line. A Jest test in tests/txStatus.test.js, failing on next.

Also, from the review of that PR: an amount of about 47 digits or more loses its last digits at the screen's edge with no sign of it. Add the break-all class to the amount's element and to wait-tx-summary and error-tx-summary in src/popup/index.html.

Model: opus-5-5

Plan: one PR to `next`, in `src/popup/views/txStatus.js`, using the function https://git.eeqj.de/sneak/AutistMask/pulls/732 added, which shows `Moved from the sender` lines on the wait and error screens. It also shows a `Permit2 allowance` line. A Jest test in `tests/txStatus.test.js`, failing on `next`. Also, from the review of that PR: an amount of about 47 digits or more loses its last digits at the screen's edge with no sign of it. Add the `break-all` class to the amount's element and to `wait-tx-summary` and `error-tx-summary` in `src/popup/index.html`. Model: opus-5-5
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/AutistMask#733