The wait and error screens after a swap is approved (src/popup/views/txStatus.js), which show only the decoder's Amount figure.
What happens
Found by the review of #679. A WRAP_ETH of 1 ETH into the router, an UNWRAP_WETH into the router, then a V4 swap of 1 ETH the user settles reads 1.0000 ETH on those screens, though up to 2 ETH can leave. The approval screen gives the Up to line and the transaction's value, so this is after the user has approved. Read from the code; not run on a chain.
What should happen
A status screen never reads as if less left the wallet than can have left.
Severity: minor
Definition of done
When a swap has Moved from the sender lines of its own, the wait and error screens show the transaction's value, or those lines, as well as the Amount figure.
A Jest test of the route above, failing on next.
Model: opus-5-5
## Where
The wait and error screens after a swap is approved (`src/popup/views/txStatus.js`), which show only the decoder's `Amount` figure.
## What happens
Found by the review of https://git.eeqj.de/sneak/AutistMask/pulls/679. A `WRAP_ETH` of 1 ETH into the router, an `UNWRAP_WETH` into the router, then a V4 swap of 1 ETH the user settles reads `1.0000 ETH` on those screens, though up to 2 ETH can leave. The approval screen gives the `Up to` line and the transaction's value, so this is after the user has approved. Read from the code; not run on a chain.
## What should happen
A status screen never reads as if less left the wallet than can have left.
Severity: minor
## Definition of done
- [ ] When a swap has `Moved from the sender` lines of its own, the wait and error screens show the transaction's value, or those lines, as well as the `Amount` figure.
- [ ] A Jest test of the route above, failing on `next`.
Model: opus-5-5
clawbot
self-assigned this 2026-11-03 03:02:19 +01:00
Plan: one PR to next, after #721, which shares the decoder's lines. src/popup/views/txStatus.js shows d.amount and d.symbol on the wait and error screens. When the decoded details include a Moved from the sender line, those two screens also show that line's amount under the summary, using the details they already receive. The decoder is unchanged. A Jest test of the route in the issue, failing on next. README's sentence on these two screens says so.
Model: opus-5-5
Plan: one PR to `next`, after https://git.eeqj.de/sneak/AutistMask/issues/721, which shares the decoder's lines. `src/popup/views/txStatus.js` shows `d.amount` and `d.symbol` on the wait and error screens. When the decoded details include a `Moved from the sender` line, those two screens also show that line's amount under the summary, using the details they already receive. The decoder is unchanged. A Jest test of the route in the issue, failing on `next`. README's sentence on these two screens says so.
Model: opus-5-5
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Where
The wait and error screens after a swap is approved (
src/popup/views/txStatus.js), which show only the decoder'sAmountfigure.What happens
Found by the review of #679. A
WRAP_ETHof 1 ETH into the router, anUNWRAP_WETHinto the router, then a V4 swap of 1 ETH the user settles reads1.0000 ETHon those screens, though up to 2 ETH can leave. The approval screen gives theUp toline and the transaction's value, so this is after the user has approved. Read from the code; not run on a chain.What should happen
A status screen never reads as if less left the wallet than can have left.
Severity: minor
Definition of done
Moved from the senderlines of its own, the wait and error screens show the transaction's value, or those lines, as well as theAmountfigure.next.Model: opus-5-5
Plan: one PR to
next, after #721, which shares the decoder's lines.src/popup/views/txStatus.jsshowsd.amountandd.symbolon the wait and error screens. When the decoded details include aMoved from the senderline, those two screens also show that line's amount under the summary, using the details they already receive. The decoder is unchanged. A Jest test of the route in the issue, failing onnext. README's sentence on these two screens says so.Model: opus-5-5