A test that leaves a timer running only warns; the gate stays green #711

Closed
opened 2026-10-28 01:09:23 +01:00 by clawbot · 1 comment
Collaborator

Since #710 the suite leaves no timer running and exits without --forceExit. A test that later leaves one running does not turn the gate red: jest stops the stuck worker after 500 ms, prints "A worker process has failed to exit gracefully and has been force exited", and the run passes. So the leak that #585 removed can come back unnoticed. Seen by the review of #710.

Definition of done: make test fails when jest prints that warning, through the test target or the gate's own scripts, not by a pattern on the whole log of another tool; a test that leaves a setInterval running, tried in a scratch copy, turns make test red; the current suite stays green.

Model: opus-5-5

Since https://git.eeqj.de/sneak/AutistMask/pulls/710 the suite leaves no timer running and exits without `--forceExit`. A test that later leaves one running does not turn the gate red: jest stops the stuck worker after 500 ms, prints "A worker process has failed to exit gracefully and has been force exited", and the run passes. So the leak that https://git.eeqj.de/sneak/AutistMask/issues/585 removed can come back unnoticed. Seen by the review of https://git.eeqj.de/sneak/AutistMask/pulls/710. Definition of done: `make test` fails when jest prints that warning, through the test target or the gate's own scripts, not by a pattern on the whole log of another tool; a test that leaves a `setInterval` running, tried in a scratch copy, turns `make test` red; the current suite stays green. Model: opus-5-5
clawbot self-assigned this 2026-10-28 01:09:23 +01:00
Author
Collaborator

Plan: one PR to next, in package.json's test script or script/ only. make test exits non-zero when jest reports that a worker had to be force-stopped ("A worker process has failed to exit gracefully"). Prefer a jest option that does this; if jest has none, the test script checks jest's own output for that line and fails. A test that leaves a setInterval running, tried in a scratch copy, turns make test red; the current suite stays green. No test or product code changes.

Model: opus-5-5

Plan: one PR to `next`, in `package.json`'s test script or `script/` only. `make test` exits non-zero when jest reports that a worker had to be force-stopped ("A worker process has failed to exit gracefully"). Prefer a jest option that does this; if jest has none, the test script checks jest's own output for that line and fails. A test that leaves a `setInterval` running, tried in a scratch copy, turns `make test` red; the current suite stays green. No test or product code changes. Model: opus-5-5
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/AutistMask#711