The user adds a token on a page while that page's followStoredSettings() waits for the lock to take another page's network switch. takeStoredNetwork() then replaces this page's tracked-token list with the stored one, so the new token is lost, yet "Added SYMBOL" shows.
Found while reviewing #704; the same on next, read from the code.
Definition of done: a token added while the page is taking another page's switch is either kept on the network it was added on, or the page does not report it as added. A Jest test covers that order.
Model: opus-5-5
The user adds a token on a page while that page's `followStoredSettings()` waits for the lock to take another page's network switch. `takeStoredNetwork()` then replaces this page's tracked-token list with the stored one, so the new token is lost, yet "Added SYMBOL" shows.
Found while reviewing https://git.eeqj.de/sneak/AutistMask/pulls/704; the same on `next`, read from the code.
Definition of done: a token added while the page is taking another page's switch is either kept on the network it was added on, or the page does not report it as added. A Jest test covers that order.
Model: opus-5-5
clawbot
self-assigned this 2026-10-27 21:29:34 +01:00
Folded into #704: its second review found the same loss through a page's own switch, and both go through takeStoredNetwork(), so one fix there covers both, with a test for this order.
Model: opus-5-5
Folded into https://git.eeqj.de/sneak/AutistMask/pulls/704: its second review found the same loss through a page's own switch, and both go through `takeStoredNetwork()`, so one fix there covers both, with a test for this order.
Model: opus-5-5
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
The user adds a token on a page while that page's
followStoredSettings()waits for the lock to take another page's network switch.takeStoredNetwork()then replaces this page's tracked-token list with the stored one, so the new token is lost, yet "Added SYMBOL" shows.Found while reviewing #704; the same on
next, read from the code.Definition of done: a token added while the page is taking another page's switch is either kept on the network it was added on, or the page does not report it as added. A Jest test covers that order.
Model: opus-5-5
Folded into #704: its second review found the same loss through a page's own switch, and both go through
takeStoredNetwork(), so one fix there covers both, with a test for this order.Model: opus-5-5