Found by the third review of #689, outside its scope.
Where
A network switch in Settings (onChainSwitch() in src/shared/chainSwitch.js), against another popup page that saved since this page's last save.
What happens
Another page tracks a token, or records a fraud contract, on Ethereum Mainnet. This page then switches to Sepolia. The other page's token or contract ends up stored under Sepolia, the network it was not added on. Read from the code on next; not run in a browser.
What should happen
A token or fraud contract stays stored under the network it was added on, whichever page added it.
Severity: minor
Definition of done
After that switch, the other page's token and fraud contract are stored under Ethereum Mainnet, not Sepolia.
A test, failing on next.
Model: opus-5-5
Found by the third review of https://git.eeqj.de/sneak/AutistMask/pulls/689, outside its scope.
## Where
A network switch in Settings (`onChainSwitch()` in `src/shared/chainSwitch.js`), against another popup page that saved since this page's last save.
## What happens
Another page tracks a token, or records a fraud contract, on Ethereum Mainnet. This page then switches to Sepolia. The other page's token or contract ends up stored under Sepolia, the network it was not added on. Read from the code on `next`; not run in a browser.
## What should happen
A token or fraud contract stays stored under the network it was added on, whichever page added it.
Severity: minor
## Definition of done
- [ ] After that switch, the other page's token and fraud contract are stored under Ethereum Mainnet, not Sepolia.
- [ ] A test, failing on `next`.
Model: opus-5-5
clawbot
self-assigned this 2026-10-27 10:14:17 +01:00
Plan: one PR to next, in onChainSwitch() (src/shared/chainSwitch.js). Before the switch moves the active tracked tokens and fraud contracts into the per-network record of the previous network, it takes them from the stored record read inside the switch's save. Any token or fraud contract another page stored since this page's last save is then filed under the network it was added on. Every other field merges as on next. A Jest test has another page track a token on Ethereum Mainnet, switches this page to Sepolia, and finds the token under Ethereum Mainnet; it fails on next.
Model: opus-5-5
Plan: one PR to `next`, in `onChainSwitch()` (`src/shared/chainSwitch.js`). Before the switch moves the active tracked tokens and fraud contracts into the per-network record of the previous network, it takes them from the stored record read inside the switch's save. Any token or fraud contract another page stored since this page's last save is then filed under the network it was added on. Every other field merges as on `next`. A Jest test has another page track a token on Ethereum Mainnet, switches this page to Sepolia, and finds the token under Ethereum Mainnet; it fails on `next`.
Model: opus-5-5
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Found by the third review of #689, outside its scope.
Where
A network switch in Settings (
onChainSwitch()insrc/shared/chainSwitch.js), against another popup page that saved since this page's last save.What happens
Another page tracks a token, or records a fraud contract, on Ethereum Mainnet. This page then switches to Sepolia. The other page's token or contract ends up stored under Sepolia, the network it was not added on. Read from the code on
next; not run in a browser.What should happen
A token or fraud contract stays stored under the network it was added on, whichever page added it.
Severity: minor
Definition of done
next.Model: opus-5-5
Plan: one PR to
next, inonChainSwitch()(src/shared/chainSwitch.js). Before the switch moves the active tracked tokens and fraud contracts into the per-network record of the previous network, it takes them from the stored record read inside the switch's save. Any token or fraud contract another page stored since this page's last save is then filed under the network it was added on. Every other field merges as onnext. A Jest test has another page track a token on Ethereum Mainnet, switches this page to Sepolia, and finds the token under Ethereum Mainnet; it fails onnext.Model: opus-5-5