'transaction' view has inconsistent title #65
Labels
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: sneak/AutistMask#65
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
sometimes it's "Transacation" and sometimes it's "Swap", but then when it's Swap it says "Action" "Swap" right below that. The main title on 'transaction' view should always be the same.
Please audit the other views for title and layout inconsistencies and file issues for any others you find.
Fixed in PR #66.
What was changed: In
transactionDetail.js, the heading was being dynamically set totx.directionLabel(e.g. "Swap") for contract interactions. Changed to always setheadingEl.textContent = "Transaction"regardless of transaction type.Audit results: Reviewed all other views (Home, AddWallet, ImportKey, AddressDetail, AddressToken, Send, ConfirmTx, TxBroadcast, TxConfirmed, TxFailed, Receive, AddToken, Settings, DeleteWallet, ApproveTx, ApproveSign). All headings are static in the HTML and match the Screen Map in README.md. No other title inconsistencies found.