The swap decoder, src/shared/uniswap.js, and the approval and transaction detail screens. A PERMIT2_TRANSFER_FROM moves an amount of the user's tokens to a recipient. After #604 the recipient is named, but the amount it moves is never shown, whether it goes to another address or to the V2 pair the next swap spends.
What happens
A PERMIT2_TRANSFER_FROM of 1,000,000 USDT to another address, then a swap of 1 USDT, reads Amount 1.0000 USDT. The screen names the other address but not that a million USDT go to it.
What should happen
The approval screen states what the user is authorizing. Every amount of the user's tokens a step moves, and where it goes, is shown with its token, so the user can see what leaves the wallet.
Severity: major
Definition of done
Each PERMIT2_TRANSFER_FROM shows its token, its amount and its recipient.
The swap's Amount line is not left as the only amount shown when other amounts of the user's tokens move.
Tests with the move going to another address, to the V2 pair, and to the router.
Model: opus-5-5
Seen by the review of https://git.eeqj.de/sneak/AutistMask/pulls/604.
## Where
The swap decoder, `src/shared/uniswap.js`, and the approval and transaction detail screens. A `PERMIT2_TRANSFER_FROM` moves an amount of the user's tokens to a recipient. After https://git.eeqj.de/sneak/AutistMask/pulls/604 the recipient is named, but the amount it moves is never shown, whether it goes to another address or to the V2 pair the next swap spends.
## What happens
A `PERMIT2_TRANSFER_FROM` of 1,000,000 USDT to another address, then a swap of 1 USDT, reads `Amount 1.0000 USDT`. The screen names the other address but not that a million USDT go to it.
## What should happen
The approval screen states what the user is authorizing. Every amount of the user's tokens a step moves, and where it goes, is shown with its token, so the user can see what leaves the wallet.
Severity: major
## Definition of done
- [ ] Each `PERMIT2_TRANSFER_FROM` shows its token, its amount and its recipient.
- [ ] The swap's `Amount` line is not left as the only amount shown when other amounts of the user's tokens move.
- [ ] Tests with the move going to another address, to the V2 pair, and to the router.
Model: opus-5-5
clawbot
self-assigned this 2026-10-19 13:37:43 +02:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Seen by the review of #604.
Where
The swap decoder,
src/shared/uniswap.js, and the approval and transaction detail screens. APERMIT2_TRANSFER_FROMmoves an amount of the user's tokens to a recipient. After #604 the recipient is named, but the amount it moves is never shown, whether it goes to another address or to the V2 pair the next swap spends.What happens
A
PERMIT2_TRANSFER_FROMof 1,000,000 USDT to another address, then a swap of 1 USDT, readsAmount 1.0000 USDT. The screen names the other address but not that a million USDT go to it.What should happen
The approval screen states what the user is authorizing. Every amount of the user's tokens a step moves, and where it goes, is shown with its token, so the user can see what leaves the wallet.
Severity: major
Definition of done
PERMIT2_TRANSFER_FROMshows its token, its amount and its recipient.Amountline is not left as the only amount shown when other amounts of the user's tokens move.Model: opus-5-5