AddToken, adding a token by contract address (src/popup/views/addToken.js). When the contract lookup answers, the screen adds the token and goes to AddressDetail, whatever screen is showing by then.
What happens
On AddToken, enter a contract address and press Add, then open Settings (or go anywhere else) before the lookup answers. When it answers, the popup leaves the screen the user is on and shows AddressDetail. This happens on next with no network switch.
What should happen
README, AddToken: "Add" re-renders AddressDetail so the new token is listed. A lookup that answers after the user has left AddToken should still add the token (if the network has not changed), but leave the screen the user is on as it is.
Severity: minor
Definition of done
A lookup that answers after the user has left AddToken does not change the screen.
A test leaves AddToken while a lookup is pending and checks the screen stays.
Model: opus-5-5
Found by the worker on https://git.eeqj.de/sneak/AutistMask/pulls/572.
## Where
AddToken, adding a token by contract address (`src/popup/views/addToken.js`). When the contract lookup answers, the screen adds the token and goes to AddressDetail, whatever screen is showing by then.
## What happens
On AddToken, enter a contract address and press Add, then open Settings (or go anywhere else) before the lookup answers. When it answers, the popup leaves the screen the user is on and shows AddressDetail. This happens on `next` with no network switch.
## What should happen
README, AddToken: "Add" re-renders AddressDetail so the new token is listed. A lookup that answers after the user has left AddToken should still add the token (if the network has not changed), but leave the screen the user is on as it is.
Severity: minor
## Definition of done
- [ ] A lookup that answers after the user has left AddToken does not change the screen.
- [ ] A test leaves AddToken while a lookup is pending and checks the screen stays.
Model: opus-5-5
clawbot
self-assigned this 2026-10-19 10:55:47 +02:00
Plan: one PR to next, in src/popup/views/addToken.js. When the contract lookup answers, the token is still added if the network has not changed, but the screen goes to AddressDetail only if AddToken is still the screen showing; otherwise the screen the user is on stays as it is. Use the check other views already use to tell whether they are still showing, not a new one. A Jest test leaves AddToken for Settings while a lookup is pending, answers it, and finds Settings still showing and the token added; it fails on next.
Model: opus-5-5
Plan: one PR to `next`, in `src/popup/views/addToken.js`. When the contract lookup answers, the token is still added if the network has not changed, but the screen goes to AddressDetail only if AddToken is still the screen showing; otherwise the screen the user is on stays as it is. Use the check other views already use to tell whether they are still showing, not a new one. A Jest test leaves AddToken for Settings while a lookup is pending, answers it, and finds Settings still showing and the token added; it fails on `next`.
Model: opus-5-5
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Found by the worker on #572.
Where
AddToken, adding a token by contract address (
src/popup/views/addToken.js). When the contract lookup answers, the screen adds the token and goes to AddressDetail, whatever screen is showing by then.What happens
On AddToken, enter a contract address and press Add, then open Settings (or go anywhere else) before the lookup answers. When it answers, the popup leaves the screen the user is on and shows AddressDetail. This happens on
nextwith no network switch.What should happen
README, AddToken: "Add" re-renders AddressDetail so the new token is listed. A lookup that answers after the user has left AddToken should still add the token (if the network has not changed), but leave the screen the user is on as it is.
Severity: minor
Definition of done
Model: opus-5-5
Plan: one PR to
next, insrc/popup/views/addToken.js. When the contract lookup answers, the token is still added if the network has not changed, but the screen goes to AddressDetail only if AddToken is still the screen showing; otherwise the screen the user is on stays as it is. Use the check other views already use to tell whether they are still showing, not a new one. A Jest test leaves AddToken for Settings while a lookup is pending, answers it, and finds Settings still showing and the token added; it fails onnext.Model: opus-5-5