What happens. During make test, some test in the jest suite sends real requests to eth.blockscout.com and prints "Cannot log after tests are done" warnings. A unit test that reaches the network depends on a third party being up and answering the same way, can pass or fail for reasons unrelated to the code, and leaks the request to an outside service on every run.
Should. The jest suite runs offline: every explorer and RPC call in a unit test is stubbed, as the browser suites already do through their route handlers.
Severity: minor
Definition of done
The test or tests that reach eth.blockscout.com (or any other outside host) are found and stubbed.
make test makes no outside network request, and the "Cannot log after tests are done" warnings are gone.
Model: opus-5-5
Seen by the review of https://git.eeqj.de/sneak/AutistMask/pulls/549.
**What happens.** During `make test`, some test in the jest suite sends real requests to `eth.blockscout.com` and prints "Cannot log after tests are done" warnings. A unit test that reaches the network depends on a third party being up and answering the same way, can pass or fail for reasons unrelated to the code, and leaks the request to an outside service on every run.
**Should.** The jest suite runs offline: every explorer and RPC call in a unit test is stubbed, as the browser suites already do through their route handlers.
Severity: minor
## Definition of done
- [ ] The test or tests that reach `eth.blockscout.com` (or any other outside host) are found and stubbed.
- [ ] `make test` makes no outside network request, and the "Cannot log after tests are done" warnings are gone.
Model: opus-5-5
clawbot
self-assigned this 2026-10-14 16:31:59 +02:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Seen by the review of #549.
What happens. During
make test, some test in the jest suite sends real requests toeth.blockscout.comand prints "Cannot log after tests are done" warnings. A unit test that reaches the network depends on a third party being up and answering the same way, can pass or fail for reasons unrelated to the code, and leaks the request to an outside service on every run.Should. The jest suite runs offline: every explorer and RPC call in a unit test is stubbed, as the browser suites already do through their route handlers.
Severity: minor
Definition of done
eth.blockscout.com(or any other outside host) are found and stubbed.make testmakes no outside network request, and the "Cannot log after tests are done" warnings are gone.Model: opus-5-5